make Qt5 the default for Kinetic, fix issues #992
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@ros-pull-request-builder retest this please |
|
I'll have to disable PySide2 support for now as I had to do a lot of hacks to get Shiboken2 to do the code generation and even then the generated code results in invalid C++ code (which fails to compile). I'm going to defer fixing that until a future Kinetic release, so I've disabled PySide2 support for now. My work so far is in this branch: https://github.com/ros-visualization/rviz/tree/wjwwood-qt5-pyside2 /cc @dirk-thomas |
130s
pushed a commit
to 130s/rviz
that referenced
this pull request
Aug 21, 2024
rviz_common is the package that loads in various icons in svg format. In order to have them definitely be loaded in, make sure to depend on libqt5-svg. Signed-off-by: Chris Lalancette <clalancette@gmail.com> (cherry picked from commit a7b8784884fe35720b41ae3c2e703aac28de8832)
130s
pushed a commit
to 130s/rviz
that referenced
this pull request
Aug 21, 2024
…pr-992 Add a libqt5-svg dependency to rviz_common. (backport ros-visualization#992)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pr will make Qt5 the default option (rather than Qt4) in ROS Kinetic. It will also address some issues with Python support.