cleanup WrenchVisual #993
Merged
cleanup WrenchVisual #993
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@rhaschke can you rebase this? I just merged a pr that makes kinetic-devel build pass in CI. Rebasing this should actually test your changes now. |
rhaschke
force-pushed
the
cleanup-wrench-visual
branch
from
5ee60bb to
0240dc9
Compare
|
@wjwwood Rebased as requested. |
|
Lgtm, thanks. |
130s
pushed a commit
to 130s/rviz
that referenced
this pull request
Aug 21, 2024
…pr-992 Add a libqt5-svg dependency to rviz_common. (backport ros-visualization#992)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thanks for merging the #982. This is the cleanup for Kinetic, removing the deprecated code and renaming WrenchStampedVisual to WrenchVisual.