-
Notifications
You must be signed in to change notification settings - Fork 466
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
generalize WrenchVisual #982
generalize WrenchVisual #982
Conversation
@rhaschke I'll have to consider this for Kinetic-only. I think there's a good change others are already using the API as-is in Indigo/Jade. |
@wjwwood Targeting kinetic is fine. To maintain API stability, I can add the original setMessage() function, which would be a simple wrapper then. |
@rhaschke that would work fine. I would consider releasing for Indigo if this only added to the current API. |
- interface changed to receive a Wrench& only - renamed setMessage() to setWrench()
…reVector3 torque)
... to allow hiding of arrows if they become shorter than wide
7a51333
to
aea6a01
Compare
@wjwwood I fixed my changes to retain API and ABI compatibility. |
lgtm, I'm going to squash it somehow. |
* whitespace normalization in wrench_display.* + wrench_visual.* * generalized WrenchStampedVisual::setMessage() - interface changed to receive a Wrench& only - renamed setMessage() to setWrench() * alternative API: WrenchStampedVisual::setWrench(OgreVector3 force, OgreVector3 torque) * expose SceneNode::setVisible() * separate scene nodes for force and torque marker ... to allow hiding of arrows if they become shorter than wide * retain API compatibility * retain ABI compatibility
* whitespace normalization in wrench_display.* + wrench_visual.* * generalized WrenchStampedVisual::setMessage() - interface changed to receive a Wrench& only - renamed setMessage() to setWrench() * alternative API: WrenchStampedVisual::setWrench(OgreVector3 force, OgreVector3 torque) * expose SceneNode::setVisible() * separate scene nodes for force and torque marker ... to allow hiding of arrows if they become shorter than wide * retain API compatibility * retain ABI compatibility
This PR attempts to increase code-reusability for
rviz::WrenchStampedVisual
, which is currently used by the wrench display plugin.The visual itself doesn't handle or use the timestamp. Hence I suggest to:
setMessage()
to accept ageometry_msgs::Wrench
1c341c0setMessage()
tosetWrench()
1c341c0setWrench(Vector3 force, Vector3 torque)
24e4babFurthermore, I modified the code to allow for