Update forward declarations of rcl_lifecycle types
#1788
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Michel Hidalgo <michel@ekumenlabs.com>
|
CI above
|
clalancette
reviewed
Sep 28, 2021
Signed-off-by: Michel Hidalgo <michel@ekumenlabs.com>
clalancette
approved these changes
Sep 28, 2021
|
Nightlies + source builds are broken because ros2/rcl#938 was merged but this PR wasn't, e.g. https://ci.ros2.org/view/nightly/job/nightly_linux_release/2053/console#console-section-8 |
|
Argh! My bad. Merging! |
Ug, good call. This seems to have built for me locally with this patch in place, so I'm going to go ahead and merge it without further CI; it can't be worse than the current state. |
|
You beat me to it @clalancette. Sorry for the fallout 🤦♂️ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Connected to ros2/rcl#938.