[dashing] Support for API break on Fast DDS 2.0 #411
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Miguel Company <miguelcompany@eProsima.com>
|
@nuclearsandwich FYI |
ivanpauno
approved these changes
Sep 17, 2020
There was a problem hiding this comment.
IMO it's safe to merge this, as it won't affect our current Dashing builds.
@clalancette @nuclearsandwich do you think it can be merged?
nuclearsandwich
approved these changes
Oct 13, 2020
|
@nuclearsandwich @clalancette It's been a month since this was approved. Is there anything preventing it to be merged? |
|
CI running communication tests with this backport:
Edit: forgot to update the remote as well as the branch. |
CI hasn't been run yet. Assuming that it's comparable to recent builds of Dashing CI I will merge it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some users are trying to build dashing from sources using Fast DDS 2.0.x.
This PR contains changes equivalent to the ones in #370 to support that.
Signed-off-by: Miguel Company miguelcompany@eProsima.com