When generating service mappings cast pair to set to avoid duplicate pairs #268
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…rvice name cause redefinition errors Signed-off-by: Gavin Suddrey <g.suddrey@qut.edu.au>
peterpena
reviewed
May 28, 2020
Signed-off-by: Gavin Suddrey <g.suddrey@qut.edu.au>
|
Thanks for the patch. |
|
Should this be backported? |
@peterpena Into which ROS distro? |
|
@dirk-thomas I am not sure what ROS distro it will be. The bug seems to be introduced all the way back to Ardent. What is the protocol to decide the ROS distro? |
Only active distro can be patched (so the earliest would be Dashing). Another criteria is if it is necessary / severe enough. Based on the original issue it seems trivial to avoid this case by not defining a custom mapping which replicates the default behavior. So I would think the need to backport is fairly low. |
|
I see. Thanks for the explanation. I felt the need to ask if it needed to be backported, but based on what you said, it seems that it might not be necessary. |
hsd-dev
pushed a commit
to hsd-dev/ros1_bridge
that referenced
this pull request
Nov 17, 2020
…pairs (ros2#268) * Fixed issue where explicitly mapped packages with the same package/service name cause redefinition errors Signed-off-by: Gavin Suddrey <g.suddrey@qut.edu.au> * Removing unneeded whitespace Signed-off-by: Gavin Suddrey <g.suddrey@qut.edu.au> Signed-off-by: Harsh Deshpande <harshavardhan.deshpande@ipa.fraunhofer.de>
ErickKramer
added a commit
to ErickKramer/ros1_bridge
that referenced
this pull request
Jun 22, 2023
I was landing into a redefinition error when using `mapping_rules.yaml` to bridge ROS actions. I applied the patch done in ros2#268 for the ROS services to the ROS actions and it solved the redefinition error.
ErickKramer
added a commit
to ErickKramer/ros1_bridge
that referenced
this pull request
Jun 28, 2023
This fixes a redefinition error when using `mapping_rules.yaml` to bridge ROS actions. I applied the patch done in ros2#268 for the ROS services to the ROS actions and it solved the redefinition error. Additional improvements: - Iterate over both the ros1 and ros2 component directly in the for loop by using `zip`. Signed-off-by: Erick Kramer <e.kramer@rethinkrobotics.com>
ErickKramer
added a commit
to ErickKramer/ros1_bridge
that referenced
this pull request
Oct 26, 2023
This fixes a redefinition error when using `mapping_rules.yaml` to bridge ROS actions. I applied the patch done in ros2#268 for the ROS services to the ROS actions and it solved the redefinition error. Additional improvements: - Iterate over both the ros1 and ros2 component directly in the for loop by using `zip`. Signed-off-by: Erick Kramer <e.kramer@rethinkrobotics.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes issue #257
Recreation of PR #259 to do master->master