Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Monitor parameter changes: Add note to save callback handle #3102

Merged
merged 1 commit into from
Oct 17, 2022

Conversation

clalancette
Copy link
Contributor

Signed-off-by: Chris Lalancette clalancette@openrobotics.org

Signed-off-by: Chris Lalancette <clalancette@openrobotics.org>
Copy link
Collaborator

@fujitatomoya fujitatomoya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have seen a couple of issues related to this one, LGTM.

@clalancette clalancette added the backport-all backport at reviewers discretion; from rolling to all versions label Oct 17, 2022
@clalancette clalancette merged commit 1d24955 into rolling Oct 17, 2022
@delete-merged-branch delete-merged-branch bot deleted the clalancette/update-monitor-for-param branch October 17, 2022 18:06
mergify bot pushed a commit that referenced this pull request Oct 17, 2022
Signed-off-by: Chris Lalancette <clalancette@openrobotics.org>
(cherry picked from commit 1d24955)
mergify bot pushed a commit that referenced this pull request Oct 17, 2022
Signed-off-by: Chris Lalancette <clalancette@openrobotics.org>
(cherry picked from commit 1d24955)
mergify bot pushed a commit that referenced this pull request Oct 17, 2022
Signed-off-by: Chris Lalancette <clalancette@openrobotics.org>
(cherry picked from commit 1d24955)

# Conflicts:
#	source/Tutorials/Intermediate/Monitoring-For-Parameter-Changes-CPP.rst
clalancette added a commit that referenced this pull request Oct 17, 2022
…3104)

Signed-off-by: Chris Lalancette <clalancette@openrobotics.org>
(cherry picked from commit 1d24955)

Co-authored-by: Chris Lalancette <clalancette@openrobotics.org>
clalancette added a commit that referenced this pull request Oct 17, 2022
…3103)

Signed-off-by: Chris Lalancette <clalancette@openrobotics.org>
(cherry picked from commit 1d24955)

Co-authored-by: Chris Lalancette <clalancette@openrobotics.org>
ygoumaz added a commit to cyberbotics/ros2_documentation that referenced this pull request Nov 2, 2022
commit 72effa7
Author: Luke Schmitt <85308904+LSinterbotix@users.noreply.github.com>
Date:   Tue Nov 1 17:26:25 2022 -0500

    Fix list formatting on Contact page (ros2#3153)

commit dcd066f
Author: Dan Zimmerman <dan@danzimmerman.com>
Date:   Tue Nov 1 16:29:34 2022 -0400

    Update throttle logging docs with units and data type hints (re: rclcpp/issues/1929) (ros2#3143)

    * Note milliseconds on API Concepts page

    * Add units and types to About Logging page

    Co-authored-by: dan <dan@polarworks.no>
    Co-authored-by: Chris Lalancette <clalancette@openrobotics.org>

commit 375b6cf
Author: definitelyuncertain <saikirann94@gmail.com>
Date:   Fri Oct 28 14:30:22 2022 -0500

    Change to mention explicit requirement for folder names for .msg and .srv files (ros2#3144)

    * Change to mention explicit requirement for folder names for msg and srv files

    From ros2/tutorials#29

    * fix typo

    Co-authored-by: Tomoya Fujita <Tomoya.Fujita@sony.com>

    * fix rst formatting

    Co-authored-by: Chris Lalancette <clalancette@gmail.com>

    Co-authored-by: Tomoya Fujita <Tomoya.Fujita@sony.com>
    Co-authored-by: Chris Lalancette <clalancette@gmail.com>

commit da871ef
Author: Sergei Sergienko <divelix1@gmail.com>
Date:   Thu Oct 27 17:20:06 2022 +0300

    fix link to Gazebo-ROS2 bridge + CLI examples (ros2#3139)

    * fix link to Gazebo-ROS2 bridge + CLI examples

    Co-authored-by: Chris Lalancette <clalancette@gmail.com>

commit e19c9b5
Author: Chris Lalancette <clalancette@openrobotics.org>
Date:   Wed Oct 26 16:31:21 2022 -0400

    Update the language to match the source code. (ros2#3135)

    Fallout from ros2#2865

    Signed-off-by: Chris Lalancette <clalancette@openrobotics.org>

commit a5910a1
Author: Chris Lalancette <clalancette@openrobotics.org>
Date:   Wed Oct 26 08:38:36 2022 -0400

    Shorten the Windows build-from-source path. (ros2#3130)

    * Shorten the Windows build-from-source path.

    This is to keep the total length down below the 260 character
    limit imposed by Windows by default.

    Signed-off-by: Chris Lalancette <clalancette@openrobotics.org>

commit 8225686
Author: Chris Lalancette <clalancette@openrobotics.org>
Date:   Mon Oct 24 08:30:37 2022 -0400

    Fix up the variable name in the traveling in time (C++) tutorial. (ros2#3115)

    This is just to match what is in the code in the upstream
    repository.

    Signed-off-by: Chris Lalancette <clalancette@openrobotics.org>

commit 87ab121
Author: Ian Colwell <48106342+icolwell-as@users.noreply.github.com>
Date:   Fri Oct 21 11:07:30 2022 -0400

    Update default WORKING_DIRECTORY for ament_add_gtest() (ros2#3117)

commit 87bf20a
Author: chianfern <chianfern@gmail.com>
Date:   Tue Oct 18 21:36:57 2022 +0800

    Add ParameterDescriptor to 'Using parameters in a class (C++)' (ros2#2865)

    * Rename node name in "Using parameters" C++ tutorial to be consistent with Python tutorial.

    Signed-off-by: Tan Chian Fern <chianfern@gmail.com>
    Signed-off-by: Chris Lalancette <clalancette@openrobotics.org>

commit 77646ce
Author: George Stavrinos <gstavrinos@protonmail.com>
Date:   Tue Oct 18 15:29:37 2022 +0300

    Fixed Intel's robot SDK repo with the new devkit name + reference to MoveIt2 instead of 1. (ros2#3107)

commit 1d24955
Author: Chris Lalancette <clalancette@openrobotics.org>
Date:   Mon Oct 17 14:06:52 2022 -0400

    Monitor parameter changes: Add note to save callback handle (ros2#3102)

    Signed-off-by: Chris Lalancette <clalancette@openrobotics.org>

commit 8910a80
Author: David V. Lu!! <davidvlu@gmail.com>
Date:   Fri Oct 14 09:56:14 2022 -0400

    Some testing basics (ros2#3084)

    * Some testing basics

    Signed-off-by: David V. Lu <davidvlu@gmail.com>
    Signed-off-by: Chris Lalancette <clalancette@openrobotics.org>

commit 8771452
Author: Tomoya Fujita <Tomoya.Fujita@sony.com>
Date:   Fri Oct 14 05:34:20 2022 -0700

    Sony's task for Iron Release. (ros2#3089)

    * Sony's task for Iron Release.

    Signed-off-by: Tomoya.Fujita <Tomoya.Fujita@sony.com>

    * Rearrange and add in links.

    Signed-off-by: Chris Lalancette <clalancette@openrobotics.org>

    Signed-off-by: Tomoya.Fujita <Tomoya.Fujita@sony.com>
    Signed-off-by: Chris Lalancette <clalancette@openrobotics.org>
    Co-authored-by: Chris Lalancette <clalancette@openrobotics.org>

commit 2ea9e7d
Author: Yannick Goumaz <61198661+ygoumaz@users.noreply.github.com>
Date:   Fri Oct 14 14:23:13 2022 +0200

    Update Setting-up a Robot Simulation (Webots) tutorial (ros2#3090)

    * Update intro to WSL

    * Update world with declarations

    * Add supervisor node and environment var

    * Update tutorial with explanations

    Co-authored-by: ad-daniel <44834743+ad-daniel@users.noreply.github.com>

commit 0390a50
Author: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
Date:   Thu Oct 13 13:42:30 2022 -0400

    fix unresolved package requirement to install Humble on Ubuntu 20.04 (ros2#3086) (ros2#3088)

    * fix command to install humble on Ubuntu 20.04

    Co-authored-by: paolo.dimasi <paodimasi@outlook.com>
    Co-authored-by: Chris Lalancette <clalancette@openrobotics.org>
    (cherry picked from commit 5626af9)

    Co-authored-by: Paolo Dimasi <46300254+Pamasi@users.noreply.github.com>
ygoumaz added a commit to cyberbotics/ros2_documentation that referenced this pull request Nov 2, 2022
commit 72effa7
Author: Luke Schmitt <85308904+LSinterbotix@users.noreply.github.com>
Date:   Tue Nov 1 17:26:25 2022 -0500

    Fix list formatting on Contact page (ros2#3153)

commit dcd066f
Author: Dan Zimmerman <dan@danzimmerman.com>
Date:   Tue Nov 1 16:29:34 2022 -0400

    Update throttle logging docs with units and data type hints (re: rclcpp/issues/1929) (ros2#3143)

    * Note milliseconds on API Concepts page

    * Add units and types to About Logging page

    Co-authored-by: dan <dan@polarworks.no>
    Co-authored-by: Chris Lalancette <clalancette@openrobotics.org>

commit 375b6cf
Author: definitelyuncertain <saikirann94@gmail.com>
Date:   Fri Oct 28 14:30:22 2022 -0500

    Change to mention explicit requirement for folder names for .msg and .srv files (ros2#3144)

    * Change to mention explicit requirement for folder names for msg and srv files

    From ros2/tutorials#29

    * fix typo

    Co-authored-by: Tomoya Fujita <Tomoya.Fujita@sony.com>

    * fix rst formatting

    Co-authored-by: Chris Lalancette <clalancette@gmail.com>

    Co-authored-by: Tomoya Fujita <Tomoya.Fujita@sony.com>
    Co-authored-by: Chris Lalancette <clalancette@gmail.com>

commit da871ef
Author: Sergei Sergienko <divelix1@gmail.com>
Date:   Thu Oct 27 17:20:06 2022 +0300

    fix link to Gazebo-ROS2 bridge + CLI examples (ros2#3139)

    * fix link to Gazebo-ROS2 bridge + CLI examples

    Co-authored-by: Chris Lalancette <clalancette@gmail.com>

commit e19c9b5
Author: Chris Lalancette <clalancette@openrobotics.org>
Date:   Wed Oct 26 16:31:21 2022 -0400

    Update the language to match the source code. (ros2#3135)

    Fallout from ros2#2865

    Signed-off-by: Chris Lalancette <clalancette@openrobotics.org>

commit a5910a1
Author: Chris Lalancette <clalancette@openrobotics.org>
Date:   Wed Oct 26 08:38:36 2022 -0400

    Shorten the Windows build-from-source path. (ros2#3130)

    * Shorten the Windows build-from-source path.

    This is to keep the total length down below the 260 character
    limit imposed by Windows by default.

    Signed-off-by: Chris Lalancette <clalancette@openrobotics.org>

commit 8225686
Author: Chris Lalancette <clalancette@openrobotics.org>
Date:   Mon Oct 24 08:30:37 2022 -0400

    Fix up the variable name in the traveling in time (C++) tutorial. (ros2#3115)

    This is just to match what is in the code in the upstream
    repository.

    Signed-off-by: Chris Lalancette <clalancette@openrobotics.org>

commit 87ab121
Author: Ian Colwell <48106342+icolwell-as@users.noreply.github.com>
Date:   Fri Oct 21 11:07:30 2022 -0400

    Update default WORKING_DIRECTORY for ament_add_gtest() (ros2#3117)

commit 87bf20a
Author: chianfern <chianfern@gmail.com>
Date:   Tue Oct 18 21:36:57 2022 +0800

    Add ParameterDescriptor to 'Using parameters in a class (C++)' (ros2#2865)

    * Rename node name in "Using parameters" C++ tutorial to be consistent with Python tutorial.

    Signed-off-by: Tan Chian Fern <chianfern@gmail.com>
    Signed-off-by: Chris Lalancette <clalancette@openrobotics.org>

commit 77646ce
Author: George Stavrinos <gstavrinos@protonmail.com>
Date:   Tue Oct 18 15:29:37 2022 +0300

    Fixed Intel's robot SDK repo with the new devkit name + reference to MoveIt2 instead of 1. (ros2#3107)

commit 1d24955
Author: Chris Lalancette <clalancette@openrobotics.org>
Date:   Mon Oct 17 14:06:52 2022 -0400

    Monitor parameter changes: Add note to save callback handle (ros2#3102)

    Signed-off-by: Chris Lalancette <clalancette@openrobotics.org>

commit 8910a80
Author: David V. Lu!! <davidvlu@gmail.com>
Date:   Fri Oct 14 09:56:14 2022 -0400

    Some testing basics (ros2#3084)

    * Some testing basics

    Signed-off-by: David V. Lu <davidvlu@gmail.com>
    Signed-off-by: Chris Lalancette <clalancette@openrobotics.org>

commit 8771452
Author: Tomoya Fujita <Tomoya.Fujita@sony.com>
Date:   Fri Oct 14 05:34:20 2022 -0700

    Sony's task for Iron Release. (ros2#3089)

    * Sony's task for Iron Release.

    Signed-off-by: Tomoya.Fujita <Tomoya.Fujita@sony.com>

    * Rearrange and add in links.

    Signed-off-by: Chris Lalancette <clalancette@openrobotics.org>

    Signed-off-by: Tomoya.Fujita <Tomoya.Fujita@sony.com>
    Signed-off-by: Chris Lalancette <clalancette@openrobotics.org>
    Co-authored-by: Chris Lalancette <clalancette@openrobotics.org>

commit 2ea9e7d
Author: Yannick Goumaz <61198661+ygoumaz@users.noreply.github.com>
Date:   Fri Oct 14 14:23:13 2022 +0200

    Update Setting-up a Robot Simulation (Webots) tutorial (ros2#3090)

    * Update intro to WSL

    * Update world with declarations

    * Add supervisor node and environment var

    * Update tutorial with explanations

    Co-authored-by: ad-daniel <44834743+ad-daniel@users.noreply.github.com>

commit 0390a50
Author: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
Date:   Thu Oct 13 13:42:30 2022 -0400

    fix unresolved package requirement to install Humble on Ubuntu 20.04 (ros2#3086) (ros2#3088)

    * fix command to install humble on Ubuntu 20.04

    Co-authored-by: paolo.dimasi <paodimasi@outlook.com>
    Co-authored-by: Chris Lalancette <clalancette@openrobotics.org>
    (cherry picked from commit 5626af9)

    Co-authored-by: Paolo Dimasi <46300254+Pamasi@users.noreply.github.com>
audrow pushed a commit that referenced this pull request Feb 13, 2023
…3317)

* Update intro to WSL

* Revert "Update intro to WSL"

This reverts commit 52a52d0.

* Update intro to wsl

* Remove windows tabs

* Add windows WSL tab for extern controller code

* Clean tutorial

* Update world with declarations

* Add supervisor node and environment var

* Add ros2supervisorlauncher node creation in launch files

* add env variable for linux

* Update tutorial with explanations

* Update source/Tutorials/Advanced/Simulators/Webots.rst

Co-authored-by: ad-daniel <44834743+ad-daniel@users.noreply.github.com>

* include correct file for supervisor part

* Add WEBOTS_CONTROLLER_URL wsl infos

* cleanup

* Update source/Tutorials/Advanced/Simulators/Webots.rst

Co-authored-by: Olivier Michel <Olivier.Michel@cyberbotics.com>

* Remove confusing sentence

* Update source/Tutorials/Advanced/Simulators/Webots.rst

Co-authored-by: Olivier Michel <Olivier.Michel@cyberbotics.com>

* Squashed commit of the following:

commit 72effa7
Author: Luke Schmitt <85308904+LSinterbotix@users.noreply.github.com>
Date:   Tue Nov 1 17:26:25 2022 -0500

    Fix list formatting on Contact page (#3153)

commit dcd066f
Author: Dan Zimmerman <dan@danzimmerman.com>
Date:   Tue Nov 1 16:29:34 2022 -0400

    Update throttle logging docs with units and data type hints (re: rclcpp/issues/1929) (#3143)

    * Note milliseconds on API Concepts page

    * Add units and types to About Logging page

    Co-authored-by: dan <dan@polarworks.no>
    Co-authored-by: Chris Lalancette <clalancette@openrobotics.org>

commit 375b6cf
Author: definitelyuncertain <saikirann94@gmail.com>
Date:   Fri Oct 28 14:30:22 2022 -0500

    Change to mention explicit requirement for folder names for .msg and .srv files (#3144)

    * Change to mention explicit requirement for folder names for msg and srv files

    From ros2/tutorials#29

    * fix typo

    Co-authored-by: Tomoya Fujita <Tomoya.Fujita@sony.com>

    * fix rst formatting

    Co-authored-by: Chris Lalancette <clalancette@gmail.com>

    Co-authored-by: Tomoya Fujita <Tomoya.Fujita@sony.com>
    Co-authored-by: Chris Lalancette <clalancette@gmail.com>

commit da871ef
Author: Sergei Sergienko <divelix1@gmail.com>
Date:   Thu Oct 27 17:20:06 2022 +0300

    fix link to Gazebo-ROS2 bridge + CLI examples (#3139)

    * fix link to Gazebo-ROS2 bridge + CLI examples

    Co-authored-by: Chris Lalancette <clalancette@gmail.com>

commit e19c9b5
Author: Chris Lalancette <clalancette@openrobotics.org>
Date:   Wed Oct 26 16:31:21 2022 -0400

    Update the language to match the source code. (#3135)

    Fallout from #2865

    Signed-off-by: Chris Lalancette <clalancette@openrobotics.org>

commit a5910a1
Author: Chris Lalancette <clalancette@openrobotics.org>
Date:   Wed Oct 26 08:38:36 2022 -0400

    Shorten the Windows build-from-source path. (#3130)

    * Shorten the Windows build-from-source path.

    This is to keep the total length down below the 260 character
    limit imposed by Windows by default.

    Signed-off-by: Chris Lalancette <clalancette@openrobotics.org>

commit 8225686
Author: Chris Lalancette <clalancette@openrobotics.org>
Date:   Mon Oct 24 08:30:37 2022 -0400

    Fix up the variable name in the traveling in time (C++) tutorial. (#3115)

    This is just to match what is in the code in the upstream
    repository.

    Signed-off-by: Chris Lalancette <clalancette@openrobotics.org>

commit 87ab121
Author: Ian Colwell <48106342+icolwell-as@users.noreply.github.com>
Date:   Fri Oct 21 11:07:30 2022 -0400

    Update default WORKING_DIRECTORY for ament_add_gtest() (#3117)

commit 87bf20a
Author: chianfern <chianfern@gmail.com>
Date:   Tue Oct 18 21:36:57 2022 +0800

    Add ParameterDescriptor to 'Using parameters in a class (C++)' (#2865)

    * Rename node name in "Using parameters" C++ tutorial to be consistent with Python tutorial.

    Signed-off-by: Tan Chian Fern <chianfern@gmail.com>
    Signed-off-by: Chris Lalancette <clalancette@openrobotics.org>

commit 77646ce
Author: George Stavrinos <gstavrinos@protonmail.com>
Date:   Tue Oct 18 15:29:37 2022 +0300

    Fixed Intel's robot SDK repo with the new devkit name + reference to MoveIt2 instead of 1. (#3107)

commit 1d24955
Author: Chris Lalancette <clalancette@openrobotics.org>
Date:   Mon Oct 17 14:06:52 2022 -0400

    Monitor parameter changes: Add note to save callback handle (#3102)

    Signed-off-by: Chris Lalancette <clalancette@openrobotics.org>

commit 8910a80
Author: David V. Lu!! <davidvlu@gmail.com>
Date:   Fri Oct 14 09:56:14 2022 -0400

    Some testing basics (#3084)

    * Some testing basics

    Signed-off-by: David V. Lu <davidvlu@gmail.com>
    Signed-off-by: Chris Lalancette <clalancette@openrobotics.org>

commit 8771452
Author: Tomoya Fujita <Tomoya.Fujita@sony.com>
Date:   Fri Oct 14 05:34:20 2022 -0700

    Sony's task for Iron Release. (#3089)

    * Sony's task for Iron Release.

    Signed-off-by: Tomoya.Fujita <Tomoya.Fujita@sony.com>

    * Rearrange and add in links.

    Signed-off-by: Chris Lalancette <clalancette@openrobotics.org>

    Signed-off-by: Tomoya.Fujita <Tomoya.Fujita@sony.com>
    Signed-off-by: Chris Lalancette <clalancette@openrobotics.org>
    Co-authored-by: Chris Lalancette <clalancette@openrobotics.org>

commit 2ea9e7d
Author: Yannick Goumaz <61198661+ygoumaz@users.noreply.github.com>
Date:   Fri Oct 14 14:23:13 2022 +0200

    Update Setting-up a Robot Simulation (Webots) tutorial (#3090)

    * Update intro to WSL

    * Update world with declarations

    * Add supervisor node and environment var

    * Update tutorial with explanations

    Co-authored-by: ad-daniel <44834743+ad-daniel@users.noreply.github.com>

commit 0390a50
Author: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
Date:   Thu Oct 13 13:42:30 2022 -0400

    fix unresolved package requirement to install Humble on Ubuntu 20.04 (#3086) (#3088)

    * fix command to install humble on Ubuntu 20.04

    Co-authored-by: paolo.dimasi <paodimasi@outlook.com>
    Co-authored-by: Chris Lalancette <clalancette@openrobotics.org>
    (cherry picked from commit 5626af9)

    Co-authored-by: Paolo Dimasi <46300254+Pamasi@users.noreply.github.com>

* Update Webots.rst

* Update intro to wsl

* Remove windows tabs

* Add windows WSL tab for extern controller code

* Clean tutorial

* Add ros2supervisorlauncher node creation in launch files

* Update intro to WSL

* Update tutorial with explanations

* include correct file for supervisor part

* Add WEBOTS_CONTROLLER_URL wsl infos

* cleanup

* Remove confusing sentence

* Update source/Tutorials/Advanced/Simulators/Webots.rst

Co-authored-by: Olivier Michel <Olivier.Michel@cyberbotics.com>

* Update source/Tutorials/Advanced/Simulators/Webots.rst

Co-authored-by: Olivier Michel <Olivier.Michel@cyberbotics.com>

* Squashed commit of the following:

commit 72effa7
Author: Luke Schmitt <85308904+LSinterbotix@users.noreply.github.com>
Date:   Tue Nov 1 17:26:25 2022 -0500

    Fix list formatting on Contact page (#3153)

commit dcd066f
Author: Dan Zimmerman <dan@danzimmerman.com>
Date:   Tue Nov 1 16:29:34 2022 -0400

    Update throttle logging docs with units and data type hints (re: rclcpp/issues/1929) (#3143)

    * Note milliseconds on API Concepts page

    * Add units and types to About Logging page

    Co-authored-by: dan <dan@polarworks.no>
    Co-authored-by: Chris Lalancette <clalancette@openrobotics.org>

commit 375b6cf
Author: definitelyuncertain <saikirann94@gmail.com>
Date:   Fri Oct 28 14:30:22 2022 -0500

    Change to mention explicit requirement for folder names for .msg and .srv files (#3144)

    * Change to mention explicit requirement for folder names for msg and srv files

    From ros2/tutorials#29

    * fix typo

    Co-authored-by: Tomoya Fujita <Tomoya.Fujita@sony.com>

    * fix rst formatting

    Co-authored-by: Chris Lalancette <clalancette@gmail.com>

    Co-authored-by: Tomoya Fujita <Tomoya.Fujita@sony.com>
    Co-authored-by: Chris Lalancette <clalancette@gmail.com>

commit da871ef
Author: Sergei Sergienko <divelix1@gmail.com>
Date:   Thu Oct 27 17:20:06 2022 +0300

    fix link to Gazebo-ROS2 bridge + CLI examples (#3139)

    * fix link to Gazebo-ROS2 bridge + CLI examples

    Co-authored-by: Chris Lalancette <clalancette@gmail.com>

commit e19c9b5
Author: Chris Lalancette <clalancette@openrobotics.org>
Date:   Wed Oct 26 16:31:21 2022 -0400

    Update the language to match the source code. (#3135)

    Fallout from #2865

    Signed-off-by: Chris Lalancette <clalancette@openrobotics.org>

commit a5910a1
Author: Chris Lalancette <clalancette@openrobotics.org>
Date:   Wed Oct 26 08:38:36 2022 -0400

    Shorten the Windows build-from-source path. (#3130)

    * Shorten the Windows build-from-source path.

    This is to keep the total length down below the 260 character
    limit imposed by Windows by default.

    Signed-off-by: Chris Lalancette <clalancette@openrobotics.org>

commit 8225686
Author: Chris Lalancette <clalancette@openrobotics.org>
Date:   Mon Oct 24 08:30:37 2022 -0400

    Fix up the variable name in the traveling in time (C++) tutorial. (#3115)

    This is just to match what is in the code in the upstream
    repository.

    Signed-off-by: Chris Lalancette <clalancette@openrobotics.org>

commit 87ab121
Author: Ian Colwell <48106342+icolwell-as@users.noreply.github.com>
Date:   Fri Oct 21 11:07:30 2022 -0400

    Update default WORKING_DIRECTORY for ament_add_gtest() (#3117)

commit 87bf20a
Author: chianfern <chianfern@gmail.com>
Date:   Tue Oct 18 21:36:57 2022 +0800

    Add ParameterDescriptor to 'Using parameters in a class (C++)' (#2865)

    * Rename node name in "Using parameters" C++ tutorial to be consistent with Python tutorial.

    Signed-off-by: Tan Chian Fern <chianfern@gmail.com>
    Signed-off-by: Chris Lalancette <clalancette@openrobotics.org>

commit 77646ce
Author: George Stavrinos <gstavrinos@protonmail.com>
Date:   Tue Oct 18 15:29:37 2022 +0300

    Fixed Intel's robot SDK repo with the new devkit name + reference to MoveIt2 instead of 1. (#3107)

commit 1d24955
Author: Chris Lalancette <clalancette@openrobotics.org>
Date:   Mon Oct 17 14:06:52 2022 -0400

    Monitor parameter changes: Add note to save callback handle (#3102)

    Signed-off-by: Chris Lalancette <clalancette@openrobotics.org>

commit 8910a80
Author: David V. Lu!! <davidvlu@gmail.com>
Date:   Fri Oct 14 09:56:14 2022 -0400

    Some testing basics (#3084)

    * Some testing basics

    Signed-off-by: David V. Lu <davidvlu@gmail.com>
    Signed-off-by: Chris Lalancette <clalancette@openrobotics.org>

commit 8771452
Author: Tomoya Fujita <Tomoya.Fujita@sony.com>
Date:   Fri Oct 14 05:34:20 2022 -0700

    Sony's task for Iron Release. (#3089)

    * Sony's task for Iron Release.

    Signed-off-by: Tomoya.Fujita <Tomoya.Fujita@sony.com>

    * Rearrange and add in links.

    Signed-off-by: Chris Lalancette <clalancette@openrobotics.org>

    Signed-off-by: Tomoya.Fujita <Tomoya.Fujita@sony.com>
    Signed-off-by: Chris Lalancette <clalancette@openrobotics.org>
    Co-authored-by: Chris Lalancette <clalancette@openrobotics.org>

commit 2ea9e7d
Author: Yannick Goumaz <61198661+ygoumaz@users.noreply.github.com>
Date:   Fri Oct 14 14:23:13 2022 +0200

    Update Setting-up a Robot Simulation (Webots) tutorial (#3090)

    * Update intro to WSL

    * Update world with declarations

    * Add supervisor node and environment var

    * Update tutorial with explanations

    Co-authored-by: ad-daniel <44834743+ad-daniel@users.noreply.github.com>

commit 0390a50
Author: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
Date:   Thu Oct 13 13:42:30 2022 -0400

    fix unresolved package requirement to install Humble on Ubuntu 20.04 (#3086) (#3088)

    * fix command to install humble on Ubuntu 20.04

    Co-authored-by: paolo.dimasi <paodimasi@outlook.com>
    Co-authored-by: Chris Lalancette <clalancette@openrobotics.org>
    (cherry picked from commit 5626af9)

    Co-authored-by: Paolo Dimasi <46300254+Pamasi@users.noreply.github.com>

* Update Webots.rst

* Update Webots.rst

* Remove trailing white spaces

* Update to VM and no supervisor

* Remove wrong text

* Update source/Tutorials/Advanced/Simulators/Webots.rst

Co-authored-by: Olivier Michel <Olivier.Michel@cyberbotics.com>

---------

Co-authored-by: ad-daniel <44834743+ad-daniel@users.noreply.github.com>
Co-authored-by: Olivier Michel <Olivier.Michel@cyberbotics.com>
mergify bot pushed a commit that referenced this pull request Feb 13, 2023
…3317)

* Update intro to WSL

* Revert "Update intro to WSL"

This reverts commit 52a52d0.

* Update intro to wsl

* Remove windows tabs

* Add windows WSL tab for extern controller code

* Clean tutorial

* Update world with declarations

* Add supervisor node and environment var

* Add ros2supervisorlauncher node creation in launch files

* add env variable for linux

* Update tutorial with explanations

* Update source/Tutorials/Advanced/Simulators/Webots.rst

Co-authored-by: ad-daniel <44834743+ad-daniel@users.noreply.github.com>

* include correct file for supervisor part

* Add WEBOTS_CONTROLLER_URL wsl infos

* cleanup

* Update source/Tutorials/Advanced/Simulators/Webots.rst

Co-authored-by: Olivier Michel <Olivier.Michel@cyberbotics.com>

* Remove confusing sentence

* Update source/Tutorials/Advanced/Simulators/Webots.rst

Co-authored-by: Olivier Michel <Olivier.Michel@cyberbotics.com>

* Squashed commit of the following:

commit 72effa7
Author: Luke Schmitt <85308904+LSinterbotix@users.noreply.github.com>
Date:   Tue Nov 1 17:26:25 2022 -0500

    Fix list formatting on Contact page (#3153)

commit dcd066f
Author: Dan Zimmerman <dan@danzimmerman.com>
Date:   Tue Nov 1 16:29:34 2022 -0400

    Update throttle logging docs with units and data type hints (re: rclcpp/issues/1929) (#3143)

    * Note milliseconds on API Concepts page

    * Add units and types to About Logging page

    Co-authored-by: dan <dan@polarworks.no>
    Co-authored-by: Chris Lalancette <clalancette@openrobotics.org>

commit 375b6cf
Author: definitelyuncertain <saikirann94@gmail.com>
Date:   Fri Oct 28 14:30:22 2022 -0500

    Change to mention explicit requirement for folder names for .msg and .srv files (#3144)

    * Change to mention explicit requirement for folder names for msg and srv files

    From ros2/tutorials#29

    * fix typo

    Co-authored-by: Tomoya Fujita <Tomoya.Fujita@sony.com>

    * fix rst formatting

    Co-authored-by: Chris Lalancette <clalancette@gmail.com>

    Co-authored-by: Tomoya Fujita <Tomoya.Fujita@sony.com>
    Co-authored-by: Chris Lalancette <clalancette@gmail.com>

commit da871ef
Author: Sergei Sergienko <divelix1@gmail.com>
Date:   Thu Oct 27 17:20:06 2022 +0300

    fix link to Gazebo-ROS2 bridge + CLI examples (#3139)

    * fix link to Gazebo-ROS2 bridge + CLI examples

    Co-authored-by: Chris Lalancette <clalancette@gmail.com>

commit e19c9b5
Author: Chris Lalancette <clalancette@openrobotics.org>
Date:   Wed Oct 26 16:31:21 2022 -0400

    Update the language to match the source code. (#3135)

    Fallout from #2865

    Signed-off-by: Chris Lalancette <clalancette@openrobotics.org>

commit a5910a1
Author: Chris Lalancette <clalancette@openrobotics.org>
Date:   Wed Oct 26 08:38:36 2022 -0400

    Shorten the Windows build-from-source path. (#3130)

    * Shorten the Windows build-from-source path.

    This is to keep the total length down below the 260 character
    limit imposed by Windows by default.

    Signed-off-by: Chris Lalancette <clalancette@openrobotics.org>

commit 8225686
Author: Chris Lalancette <clalancette@openrobotics.org>
Date:   Mon Oct 24 08:30:37 2022 -0400

    Fix up the variable name in the traveling in time (C++) tutorial. (#3115)

    This is just to match what is in the code in the upstream
    repository.

    Signed-off-by: Chris Lalancette <clalancette@openrobotics.org>

commit 87ab121
Author: Ian Colwell <48106342+icolwell-as@users.noreply.github.com>
Date:   Fri Oct 21 11:07:30 2022 -0400

    Update default WORKING_DIRECTORY for ament_add_gtest() (#3117)

commit 87bf20a
Author: chianfern <chianfern@gmail.com>
Date:   Tue Oct 18 21:36:57 2022 +0800

    Add ParameterDescriptor to 'Using parameters in a class (C++)' (#2865)

    * Rename node name in "Using parameters" C++ tutorial to be consistent with Python tutorial.

    Signed-off-by: Tan Chian Fern <chianfern@gmail.com>
    Signed-off-by: Chris Lalancette <clalancette@openrobotics.org>

commit 77646ce
Author: George Stavrinos <gstavrinos@protonmail.com>
Date:   Tue Oct 18 15:29:37 2022 +0300

    Fixed Intel's robot SDK repo with the new devkit name + reference to MoveIt2 instead of 1. (#3107)

commit 1d24955
Author: Chris Lalancette <clalancette@openrobotics.org>
Date:   Mon Oct 17 14:06:52 2022 -0400

    Monitor parameter changes: Add note to save callback handle (#3102)

    Signed-off-by: Chris Lalancette <clalancette@openrobotics.org>

commit 8910a80
Author: David V. Lu!! <davidvlu@gmail.com>
Date:   Fri Oct 14 09:56:14 2022 -0400

    Some testing basics (#3084)

    * Some testing basics

    Signed-off-by: David V. Lu <davidvlu@gmail.com>
    Signed-off-by: Chris Lalancette <clalancette@openrobotics.org>

commit 8771452
Author: Tomoya Fujita <Tomoya.Fujita@sony.com>
Date:   Fri Oct 14 05:34:20 2022 -0700

    Sony's task for Iron Release. (#3089)

    * Sony's task for Iron Release.

    Signed-off-by: Tomoya.Fujita <Tomoya.Fujita@sony.com>

    * Rearrange and add in links.

    Signed-off-by: Chris Lalancette <clalancette@openrobotics.org>

    Signed-off-by: Tomoya.Fujita <Tomoya.Fujita@sony.com>
    Signed-off-by: Chris Lalancette <clalancette@openrobotics.org>
    Co-authored-by: Chris Lalancette <clalancette@openrobotics.org>

commit 2ea9e7d
Author: Yannick Goumaz <61198661+ygoumaz@users.noreply.github.com>
Date:   Fri Oct 14 14:23:13 2022 +0200

    Update Setting-up a Robot Simulation (Webots) tutorial (#3090)

    * Update intro to WSL

    * Update world with declarations

    * Add supervisor node and environment var

    * Update tutorial with explanations

    Co-authored-by: ad-daniel <44834743+ad-daniel@users.noreply.github.com>

commit 0390a50
Author: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
Date:   Thu Oct 13 13:42:30 2022 -0400

    fix unresolved package requirement to install Humble on Ubuntu 20.04 (#3086) (#3088)

    * fix command to install humble on Ubuntu 20.04

    Co-authored-by: paolo.dimasi <paodimasi@outlook.com>
    Co-authored-by: Chris Lalancette <clalancette@openrobotics.org>
    (cherry picked from commit 5626af9)

    Co-authored-by: Paolo Dimasi <46300254+Pamasi@users.noreply.github.com>

* Update Webots.rst

* Update intro to wsl

* Remove windows tabs

* Add windows WSL tab for extern controller code

* Clean tutorial

* Add ros2supervisorlauncher node creation in launch files

* Update intro to WSL

* Update tutorial with explanations

* include correct file for supervisor part

* Add WEBOTS_CONTROLLER_URL wsl infos

* cleanup

* Remove confusing sentence

* Update source/Tutorials/Advanced/Simulators/Webots.rst

Co-authored-by: Olivier Michel <Olivier.Michel@cyberbotics.com>

* Update source/Tutorials/Advanced/Simulators/Webots.rst

Co-authored-by: Olivier Michel <Olivier.Michel@cyberbotics.com>

* Squashed commit of the following:

commit 72effa7
Author: Luke Schmitt <85308904+LSinterbotix@users.noreply.github.com>
Date:   Tue Nov 1 17:26:25 2022 -0500

    Fix list formatting on Contact page (#3153)

commit dcd066f
Author: Dan Zimmerman <dan@danzimmerman.com>
Date:   Tue Nov 1 16:29:34 2022 -0400

    Update throttle logging docs with units and data type hints (re: rclcpp/issues/1929) (#3143)

    * Note milliseconds on API Concepts page

    * Add units and types to About Logging page

    Co-authored-by: dan <dan@polarworks.no>
    Co-authored-by: Chris Lalancette <clalancette@openrobotics.org>

commit 375b6cf
Author: definitelyuncertain <saikirann94@gmail.com>
Date:   Fri Oct 28 14:30:22 2022 -0500

    Change to mention explicit requirement for folder names for .msg and .srv files (#3144)

    * Change to mention explicit requirement for folder names for msg and srv files

    From ros2/tutorials#29

    * fix typo

    Co-authored-by: Tomoya Fujita <Tomoya.Fujita@sony.com>

    * fix rst formatting

    Co-authored-by: Chris Lalancette <clalancette@gmail.com>

    Co-authored-by: Tomoya Fujita <Tomoya.Fujita@sony.com>
    Co-authored-by: Chris Lalancette <clalancette@gmail.com>

commit da871ef
Author: Sergei Sergienko <divelix1@gmail.com>
Date:   Thu Oct 27 17:20:06 2022 +0300

    fix link to Gazebo-ROS2 bridge + CLI examples (#3139)

    * fix link to Gazebo-ROS2 bridge + CLI examples

    Co-authored-by: Chris Lalancette <clalancette@gmail.com>

commit e19c9b5
Author: Chris Lalancette <clalancette@openrobotics.org>
Date:   Wed Oct 26 16:31:21 2022 -0400

    Update the language to match the source code. (#3135)

    Fallout from #2865

    Signed-off-by: Chris Lalancette <clalancette@openrobotics.org>

commit a5910a1
Author: Chris Lalancette <clalancette@openrobotics.org>
Date:   Wed Oct 26 08:38:36 2022 -0400

    Shorten the Windows build-from-source path. (#3130)

    * Shorten the Windows build-from-source path.

    This is to keep the total length down below the 260 character
    limit imposed by Windows by default.

    Signed-off-by: Chris Lalancette <clalancette@openrobotics.org>

commit 8225686
Author: Chris Lalancette <clalancette@openrobotics.org>
Date:   Mon Oct 24 08:30:37 2022 -0400

    Fix up the variable name in the traveling in time (C++) tutorial. (#3115)

    This is just to match what is in the code in the upstream
    repository.

    Signed-off-by: Chris Lalancette <clalancette@openrobotics.org>

commit 87ab121
Author: Ian Colwell <48106342+icolwell-as@users.noreply.github.com>
Date:   Fri Oct 21 11:07:30 2022 -0400

    Update default WORKING_DIRECTORY for ament_add_gtest() (#3117)

commit 87bf20a
Author: chianfern <chianfern@gmail.com>
Date:   Tue Oct 18 21:36:57 2022 +0800

    Add ParameterDescriptor to 'Using parameters in a class (C++)' (#2865)

    * Rename node name in "Using parameters" C++ tutorial to be consistent with Python tutorial.

    Signed-off-by: Tan Chian Fern <chianfern@gmail.com>
    Signed-off-by: Chris Lalancette <clalancette@openrobotics.org>

commit 77646ce
Author: George Stavrinos <gstavrinos@protonmail.com>
Date:   Tue Oct 18 15:29:37 2022 +0300

    Fixed Intel's robot SDK repo with the new devkit name + reference to MoveIt2 instead of 1. (#3107)

commit 1d24955
Author: Chris Lalancette <clalancette@openrobotics.org>
Date:   Mon Oct 17 14:06:52 2022 -0400

    Monitor parameter changes: Add note to save callback handle (#3102)

    Signed-off-by: Chris Lalancette <clalancette@openrobotics.org>

commit 8910a80
Author: David V. Lu!! <davidvlu@gmail.com>
Date:   Fri Oct 14 09:56:14 2022 -0400

    Some testing basics (#3084)

    * Some testing basics

    Signed-off-by: David V. Lu <davidvlu@gmail.com>
    Signed-off-by: Chris Lalancette <clalancette@openrobotics.org>

commit 8771452
Author: Tomoya Fujita <Tomoya.Fujita@sony.com>
Date:   Fri Oct 14 05:34:20 2022 -0700

    Sony's task for Iron Release. (#3089)

    * Sony's task for Iron Release.

    Signed-off-by: Tomoya.Fujita <Tomoya.Fujita@sony.com>

    * Rearrange and add in links.

    Signed-off-by: Chris Lalancette <clalancette@openrobotics.org>

    Signed-off-by: Tomoya.Fujita <Tomoya.Fujita@sony.com>
    Signed-off-by: Chris Lalancette <clalancette@openrobotics.org>
    Co-authored-by: Chris Lalancette <clalancette@openrobotics.org>

commit 2ea9e7d
Author: Yannick Goumaz <61198661+ygoumaz@users.noreply.github.com>
Date:   Fri Oct 14 14:23:13 2022 +0200

    Update Setting-up a Robot Simulation (Webots) tutorial (#3090)

    * Update intro to WSL

    * Update world with declarations

    * Add supervisor node and environment var

    * Update tutorial with explanations

    Co-authored-by: ad-daniel <44834743+ad-daniel@users.noreply.github.com>

commit 0390a50
Author: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
Date:   Thu Oct 13 13:42:30 2022 -0400

    fix unresolved package requirement to install Humble on Ubuntu 20.04 (#3086) (#3088)

    * fix command to install humble on Ubuntu 20.04

    Co-authored-by: paolo.dimasi <paodimasi@outlook.com>
    Co-authored-by: Chris Lalancette <clalancette@openrobotics.org>
    (cherry picked from commit 5626af9)

    Co-authored-by: Paolo Dimasi <46300254+Pamasi@users.noreply.github.com>

* Update Webots.rst

* Update Webots.rst

* Remove trailing white spaces

* Update to VM and no supervisor

* Remove wrong text

* Update source/Tutorials/Advanced/Simulators/Webots.rst

Co-authored-by: Olivier Michel <Olivier.Michel@cyberbotics.com>

---------

Co-authored-by: ad-daniel <44834743+ad-daniel@users.noreply.github.com>
Co-authored-by: Olivier Michel <Olivier.Michel@cyberbotics.com>
(cherry picked from commit 588b10a)
mergify bot pushed a commit that referenced this pull request Feb 13, 2023
…3317)

* Update intro to WSL

* Revert "Update intro to WSL"

This reverts commit 52a52d0.

* Update intro to wsl

* Remove windows tabs

* Add windows WSL tab for extern controller code

* Clean tutorial

* Update world with declarations

* Add supervisor node and environment var

* Add ros2supervisorlauncher node creation in launch files

* add env variable for linux

* Update tutorial with explanations

* Update source/Tutorials/Advanced/Simulators/Webots.rst

Co-authored-by: ad-daniel <44834743+ad-daniel@users.noreply.github.com>

* include correct file for supervisor part

* Add WEBOTS_CONTROLLER_URL wsl infos

* cleanup

* Update source/Tutorials/Advanced/Simulators/Webots.rst

Co-authored-by: Olivier Michel <Olivier.Michel@cyberbotics.com>

* Remove confusing sentence

* Update source/Tutorials/Advanced/Simulators/Webots.rst

Co-authored-by: Olivier Michel <Olivier.Michel@cyberbotics.com>

* Squashed commit of the following:

commit 72effa7
Author: Luke Schmitt <85308904+LSinterbotix@users.noreply.github.com>
Date:   Tue Nov 1 17:26:25 2022 -0500

    Fix list formatting on Contact page (#3153)

commit dcd066f
Author: Dan Zimmerman <dan@danzimmerman.com>
Date:   Tue Nov 1 16:29:34 2022 -0400

    Update throttle logging docs with units and data type hints (re: rclcpp/issues/1929) (#3143)

    * Note milliseconds on API Concepts page

    * Add units and types to About Logging page

    Co-authored-by: dan <dan@polarworks.no>
    Co-authored-by: Chris Lalancette <clalancette@openrobotics.org>

commit 375b6cf
Author: definitelyuncertain <saikirann94@gmail.com>
Date:   Fri Oct 28 14:30:22 2022 -0500

    Change to mention explicit requirement for folder names for .msg and .srv files (#3144)

    * Change to mention explicit requirement for folder names for msg and srv files

    From ros2/tutorials#29

    * fix typo

    Co-authored-by: Tomoya Fujita <Tomoya.Fujita@sony.com>

    * fix rst formatting

    Co-authored-by: Chris Lalancette <clalancette@gmail.com>

    Co-authored-by: Tomoya Fujita <Tomoya.Fujita@sony.com>
    Co-authored-by: Chris Lalancette <clalancette@gmail.com>

commit da871ef
Author: Sergei Sergienko <divelix1@gmail.com>
Date:   Thu Oct 27 17:20:06 2022 +0300

    fix link to Gazebo-ROS2 bridge + CLI examples (#3139)

    * fix link to Gazebo-ROS2 bridge + CLI examples

    Co-authored-by: Chris Lalancette <clalancette@gmail.com>

commit e19c9b5
Author: Chris Lalancette <clalancette@openrobotics.org>
Date:   Wed Oct 26 16:31:21 2022 -0400

    Update the language to match the source code. (#3135)

    Fallout from #2865

    Signed-off-by: Chris Lalancette <clalancette@openrobotics.org>

commit a5910a1
Author: Chris Lalancette <clalancette@openrobotics.org>
Date:   Wed Oct 26 08:38:36 2022 -0400

    Shorten the Windows build-from-source path. (#3130)

    * Shorten the Windows build-from-source path.

    This is to keep the total length down below the 260 character
    limit imposed by Windows by default.

    Signed-off-by: Chris Lalancette <clalancette@openrobotics.org>

commit 8225686
Author: Chris Lalancette <clalancette@openrobotics.org>
Date:   Mon Oct 24 08:30:37 2022 -0400

    Fix up the variable name in the traveling in time (C++) tutorial. (#3115)

    This is just to match what is in the code in the upstream
    repository.

    Signed-off-by: Chris Lalancette <clalancette@openrobotics.org>

commit 87ab121
Author: Ian Colwell <48106342+icolwell-as@users.noreply.github.com>
Date:   Fri Oct 21 11:07:30 2022 -0400

    Update default WORKING_DIRECTORY for ament_add_gtest() (#3117)

commit 87bf20a
Author: chianfern <chianfern@gmail.com>
Date:   Tue Oct 18 21:36:57 2022 +0800

    Add ParameterDescriptor to 'Using parameters in a class (C++)' (#2865)

    * Rename node name in "Using parameters" C++ tutorial to be consistent with Python tutorial.

    Signed-off-by: Tan Chian Fern <chianfern@gmail.com>
    Signed-off-by: Chris Lalancette <clalancette@openrobotics.org>

commit 77646ce
Author: George Stavrinos <gstavrinos@protonmail.com>
Date:   Tue Oct 18 15:29:37 2022 +0300

    Fixed Intel's robot SDK repo with the new devkit name + reference to MoveIt2 instead of 1. (#3107)

commit 1d24955
Author: Chris Lalancette <clalancette@openrobotics.org>
Date:   Mon Oct 17 14:06:52 2022 -0400

    Monitor parameter changes: Add note to save callback handle (#3102)

    Signed-off-by: Chris Lalancette <clalancette@openrobotics.org>

commit 8910a80
Author: David V. Lu!! <davidvlu@gmail.com>
Date:   Fri Oct 14 09:56:14 2022 -0400

    Some testing basics (#3084)

    * Some testing basics

    Signed-off-by: David V. Lu <davidvlu@gmail.com>
    Signed-off-by: Chris Lalancette <clalancette@openrobotics.org>

commit 8771452
Author: Tomoya Fujita <Tomoya.Fujita@sony.com>
Date:   Fri Oct 14 05:34:20 2022 -0700

    Sony's task for Iron Release. (#3089)

    * Sony's task for Iron Release.

    Signed-off-by: Tomoya.Fujita <Tomoya.Fujita@sony.com>

    * Rearrange and add in links.

    Signed-off-by: Chris Lalancette <clalancette@openrobotics.org>

    Signed-off-by: Tomoya.Fujita <Tomoya.Fujita@sony.com>
    Signed-off-by: Chris Lalancette <clalancette@openrobotics.org>
    Co-authored-by: Chris Lalancette <clalancette@openrobotics.org>

commit 2ea9e7d
Author: Yannick Goumaz <61198661+ygoumaz@users.noreply.github.com>
Date:   Fri Oct 14 14:23:13 2022 +0200

    Update Setting-up a Robot Simulation (Webots) tutorial (#3090)

    * Update intro to WSL

    * Update world with declarations

    * Add supervisor node and environment var

    * Update tutorial with explanations

    Co-authored-by: ad-daniel <44834743+ad-daniel@users.noreply.github.com>

commit 0390a50
Author: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
Date:   Thu Oct 13 13:42:30 2022 -0400

    fix unresolved package requirement to install Humble on Ubuntu 20.04 (#3086) (#3088)

    * fix command to install humble on Ubuntu 20.04

    Co-authored-by: paolo.dimasi <paodimasi@outlook.com>
    Co-authored-by: Chris Lalancette <clalancette@openrobotics.org>
    (cherry picked from commit 5626af9)

    Co-authored-by: Paolo Dimasi <46300254+Pamasi@users.noreply.github.com>

* Update Webots.rst

* Update intro to wsl

* Remove windows tabs

* Add windows WSL tab for extern controller code

* Clean tutorial

* Add ros2supervisorlauncher node creation in launch files

* Update intro to WSL

* Update tutorial with explanations

* include correct file for supervisor part

* Add WEBOTS_CONTROLLER_URL wsl infos

* cleanup

* Remove confusing sentence

* Update source/Tutorials/Advanced/Simulators/Webots.rst

Co-authored-by: Olivier Michel <Olivier.Michel@cyberbotics.com>

* Update source/Tutorials/Advanced/Simulators/Webots.rst

Co-authored-by: Olivier Michel <Olivier.Michel@cyberbotics.com>

* Squashed commit of the following:

commit 72effa7
Author: Luke Schmitt <85308904+LSinterbotix@users.noreply.github.com>
Date:   Tue Nov 1 17:26:25 2022 -0500

    Fix list formatting on Contact page (#3153)

commit dcd066f
Author: Dan Zimmerman <dan@danzimmerman.com>
Date:   Tue Nov 1 16:29:34 2022 -0400

    Update throttle logging docs with units and data type hints (re: rclcpp/issues/1929) (#3143)

    * Note milliseconds on API Concepts page

    * Add units and types to About Logging page

    Co-authored-by: dan <dan@polarworks.no>
    Co-authored-by: Chris Lalancette <clalancette@openrobotics.org>

commit 375b6cf
Author: definitelyuncertain <saikirann94@gmail.com>
Date:   Fri Oct 28 14:30:22 2022 -0500

    Change to mention explicit requirement for folder names for .msg and .srv files (#3144)

    * Change to mention explicit requirement for folder names for msg and srv files

    From ros2/tutorials#29

    * fix typo

    Co-authored-by: Tomoya Fujita <Tomoya.Fujita@sony.com>

    * fix rst formatting

    Co-authored-by: Chris Lalancette <clalancette@gmail.com>

    Co-authored-by: Tomoya Fujita <Tomoya.Fujita@sony.com>
    Co-authored-by: Chris Lalancette <clalancette@gmail.com>

commit da871ef
Author: Sergei Sergienko <divelix1@gmail.com>
Date:   Thu Oct 27 17:20:06 2022 +0300

    fix link to Gazebo-ROS2 bridge + CLI examples (#3139)

    * fix link to Gazebo-ROS2 bridge + CLI examples

    Co-authored-by: Chris Lalancette <clalancette@gmail.com>

commit e19c9b5
Author: Chris Lalancette <clalancette@openrobotics.org>
Date:   Wed Oct 26 16:31:21 2022 -0400

    Update the language to match the source code. (#3135)

    Fallout from #2865

    Signed-off-by: Chris Lalancette <clalancette@openrobotics.org>

commit a5910a1
Author: Chris Lalancette <clalancette@openrobotics.org>
Date:   Wed Oct 26 08:38:36 2022 -0400

    Shorten the Windows build-from-source path. (#3130)

    * Shorten the Windows build-from-source path.

    This is to keep the total length down below the 260 character
    limit imposed by Windows by default.

    Signed-off-by: Chris Lalancette <clalancette@openrobotics.org>

commit 8225686
Author: Chris Lalancette <clalancette@openrobotics.org>
Date:   Mon Oct 24 08:30:37 2022 -0400

    Fix up the variable name in the traveling in time (C++) tutorial. (#3115)

    This is just to match what is in the code in the upstream
    repository.

    Signed-off-by: Chris Lalancette <clalancette@openrobotics.org>

commit 87ab121
Author: Ian Colwell <48106342+icolwell-as@users.noreply.github.com>
Date:   Fri Oct 21 11:07:30 2022 -0400

    Update default WORKING_DIRECTORY for ament_add_gtest() (#3117)

commit 87bf20a
Author: chianfern <chianfern@gmail.com>
Date:   Tue Oct 18 21:36:57 2022 +0800

    Add ParameterDescriptor to 'Using parameters in a class (C++)' (#2865)

    * Rename node name in "Using parameters" C++ tutorial to be consistent with Python tutorial.

    Signed-off-by: Tan Chian Fern <chianfern@gmail.com>
    Signed-off-by: Chris Lalancette <clalancette@openrobotics.org>

commit 77646ce
Author: George Stavrinos <gstavrinos@protonmail.com>
Date:   Tue Oct 18 15:29:37 2022 +0300

    Fixed Intel's robot SDK repo with the new devkit name + reference to MoveIt2 instead of 1. (#3107)

commit 1d24955
Author: Chris Lalancette <clalancette@openrobotics.org>
Date:   Mon Oct 17 14:06:52 2022 -0400

    Monitor parameter changes: Add note to save callback handle (#3102)

    Signed-off-by: Chris Lalancette <clalancette@openrobotics.org>

commit 8910a80
Author: David V. Lu!! <davidvlu@gmail.com>
Date:   Fri Oct 14 09:56:14 2022 -0400

    Some testing basics (#3084)

    * Some testing basics

    Signed-off-by: David V. Lu <davidvlu@gmail.com>
    Signed-off-by: Chris Lalancette <clalancette@openrobotics.org>

commit 8771452
Author: Tomoya Fujita <Tomoya.Fujita@sony.com>
Date:   Fri Oct 14 05:34:20 2022 -0700

    Sony's task for Iron Release. (#3089)

    * Sony's task for Iron Release.

    Signed-off-by: Tomoya.Fujita <Tomoya.Fujita@sony.com>

    * Rearrange and add in links.

    Signed-off-by: Chris Lalancette <clalancette@openrobotics.org>

    Signed-off-by: Tomoya.Fujita <Tomoya.Fujita@sony.com>
    Signed-off-by: Chris Lalancette <clalancette@openrobotics.org>
    Co-authored-by: Chris Lalancette <clalancette@openrobotics.org>

commit 2ea9e7d
Author: Yannick Goumaz <61198661+ygoumaz@users.noreply.github.com>
Date:   Fri Oct 14 14:23:13 2022 +0200

    Update Setting-up a Robot Simulation (Webots) tutorial (#3090)

    * Update intro to WSL

    * Update world with declarations

    * Add supervisor node and environment var

    * Update tutorial with explanations

    Co-authored-by: ad-daniel <44834743+ad-daniel@users.noreply.github.com>

commit 0390a50
Author: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
Date:   Thu Oct 13 13:42:30 2022 -0400

    fix unresolved package requirement to install Humble on Ubuntu 20.04 (#3086) (#3088)

    * fix command to install humble on Ubuntu 20.04

    Co-authored-by: paolo.dimasi <paodimasi@outlook.com>
    Co-authored-by: Chris Lalancette <clalancette@openrobotics.org>
    (cherry picked from commit 5626af9)

    Co-authored-by: Paolo Dimasi <46300254+Pamasi@users.noreply.github.com>

* Update Webots.rst

* Update Webots.rst

* Remove trailing white spaces

* Update to VM and no supervisor

* Remove wrong text

* Update source/Tutorials/Advanced/Simulators/Webots.rst

Co-authored-by: Olivier Michel <Olivier.Michel@cyberbotics.com>

---------

Co-authored-by: ad-daniel <44834743+ad-daniel@users.noreply.github.com>
Co-authored-by: Olivier Michel <Olivier.Michel@cyberbotics.com>
(cherry picked from commit 588b10a)
audrow pushed a commit that referenced this pull request Feb 13, 2023
…3317) (#3332)

* Update intro to WSL

* Revert "Update intro to WSL"

This reverts commit 52a52d0.

* Update intro to wsl

* Remove windows tabs

* Add windows WSL tab for extern controller code

* Clean tutorial

* Update world with declarations

* Add supervisor node and environment var

* Add ros2supervisorlauncher node creation in launch files

* add env variable for linux

* Update tutorial with explanations

* Update source/Tutorials/Advanced/Simulators/Webots.rst

Co-authored-by: ad-daniel <44834743+ad-daniel@users.noreply.github.com>

* include correct file for supervisor part

* Add WEBOTS_CONTROLLER_URL wsl infos

* cleanup

* Update source/Tutorials/Advanced/Simulators/Webots.rst

Co-authored-by: Olivier Michel <Olivier.Michel@cyberbotics.com>

* Remove confusing sentence

* Update source/Tutorials/Advanced/Simulators/Webots.rst

Co-authored-by: Olivier Michel <Olivier.Michel@cyberbotics.com>

* Squashed commit of the following:

commit 72effa7
Author: Luke Schmitt <85308904+LSinterbotix@users.noreply.github.com>
Date:   Tue Nov 1 17:26:25 2022 -0500

    Fix list formatting on Contact page (#3153)

commit dcd066f
Author: Dan Zimmerman <dan@danzimmerman.com>
Date:   Tue Nov 1 16:29:34 2022 -0400

    Update throttle logging docs with units and data type hints (re: rclcpp/issues/1929) (#3143)

    * Note milliseconds on API Concepts page

    * Add units and types to About Logging page

    Co-authored-by: dan <dan@polarworks.no>
    Co-authored-by: Chris Lalancette <clalancette@openrobotics.org>

commit 375b6cf
Author: definitelyuncertain <saikirann94@gmail.com>
Date:   Fri Oct 28 14:30:22 2022 -0500

    Change to mention explicit requirement for folder names for .msg and .srv files (#3144)

    * Change to mention explicit requirement for folder names for msg and srv files

    From ros2/tutorials#29

    * fix typo

    Co-authored-by: Tomoya Fujita <Tomoya.Fujita@sony.com>

    * fix rst formatting

    Co-authored-by: Chris Lalancette <clalancette@gmail.com>

    Co-authored-by: Tomoya Fujita <Tomoya.Fujita@sony.com>
    Co-authored-by: Chris Lalancette <clalancette@gmail.com>

commit da871ef
Author: Sergei Sergienko <divelix1@gmail.com>
Date:   Thu Oct 27 17:20:06 2022 +0300

    fix link to Gazebo-ROS2 bridge + CLI examples (#3139)

    * fix link to Gazebo-ROS2 bridge + CLI examples

    Co-authored-by: Chris Lalancette <clalancette@gmail.com>

commit e19c9b5
Author: Chris Lalancette <clalancette@openrobotics.org>
Date:   Wed Oct 26 16:31:21 2022 -0400

    Update the language to match the source code. (#3135)

    Fallout from #2865

    Signed-off-by: Chris Lalancette <clalancette@openrobotics.org>

commit a5910a1
Author: Chris Lalancette <clalancette@openrobotics.org>
Date:   Wed Oct 26 08:38:36 2022 -0400

    Shorten the Windows build-from-source path. (#3130)

    * Shorten the Windows build-from-source path.

    This is to keep the total length down below the 260 character
    limit imposed by Windows by default.

    Signed-off-by: Chris Lalancette <clalancette@openrobotics.org>

commit 8225686
Author: Chris Lalancette <clalancette@openrobotics.org>
Date:   Mon Oct 24 08:30:37 2022 -0400

    Fix up the variable name in the traveling in time (C++) tutorial. (#3115)

    This is just to match what is in the code in the upstream
    repository.

    Signed-off-by: Chris Lalancette <clalancette@openrobotics.org>

commit 87ab121
Author: Ian Colwell <48106342+icolwell-as@users.noreply.github.com>
Date:   Fri Oct 21 11:07:30 2022 -0400

    Update default WORKING_DIRECTORY for ament_add_gtest() (#3117)

commit 87bf20a
Author: chianfern <chianfern@gmail.com>
Date:   Tue Oct 18 21:36:57 2022 +0800

    Add ParameterDescriptor to 'Using parameters in a class (C++)' (#2865)

    * Rename node name in "Using parameters" C++ tutorial to be consistent with Python tutorial.

    Signed-off-by: Tan Chian Fern <chianfern@gmail.com>
    Signed-off-by: Chris Lalancette <clalancette@openrobotics.org>

commit 77646ce
Author: George Stavrinos <gstavrinos@protonmail.com>
Date:   Tue Oct 18 15:29:37 2022 +0300

    Fixed Intel's robot SDK repo with the new devkit name + reference to MoveIt2 instead of 1. (#3107)

commit 1d24955
Author: Chris Lalancette <clalancette@openrobotics.org>
Date:   Mon Oct 17 14:06:52 2022 -0400

    Monitor parameter changes: Add note to save callback handle (#3102)

    Signed-off-by: Chris Lalancette <clalancette@openrobotics.org>

commit 8910a80
Author: David V. Lu!! <davidvlu@gmail.com>
Date:   Fri Oct 14 09:56:14 2022 -0400

    Some testing basics (#3084)

    * Some testing basics

    Signed-off-by: David V. Lu <davidvlu@gmail.com>
    Signed-off-by: Chris Lalancette <clalancette@openrobotics.org>

commit 8771452
Author: Tomoya Fujita <Tomoya.Fujita@sony.com>
Date:   Fri Oct 14 05:34:20 2022 -0700

    Sony's task for Iron Release. (#3089)

    * Sony's task for Iron Release.

    Signed-off-by: Tomoya.Fujita <Tomoya.Fujita@sony.com>

    * Rearrange and add in links.

    Signed-off-by: Chris Lalancette <clalancette@openrobotics.org>

    Signed-off-by: Tomoya.Fujita <Tomoya.Fujita@sony.com>
    Signed-off-by: Chris Lalancette <clalancette@openrobotics.org>
    Co-authored-by: Chris Lalancette <clalancette@openrobotics.org>

commit 2ea9e7d
Author: Yannick Goumaz <61198661+ygoumaz@users.noreply.github.com>
Date:   Fri Oct 14 14:23:13 2022 +0200

    Update Setting-up a Robot Simulation (Webots) tutorial (#3090)

    * Update intro to WSL

    * Update world with declarations

    * Add supervisor node and environment var

    * Update tutorial with explanations

    Co-authored-by: ad-daniel <44834743+ad-daniel@users.noreply.github.com>

commit 0390a50
Author: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
Date:   Thu Oct 13 13:42:30 2022 -0400

    fix unresolved package requirement to install Humble on Ubuntu 20.04 (#3086) (#3088)

    * fix command to install humble on Ubuntu 20.04

    Co-authored-by: paolo.dimasi <paodimasi@outlook.com>
    Co-authored-by: Chris Lalancette <clalancette@openrobotics.org>
    (cherry picked from commit 5626af9)

    Co-authored-by: Paolo Dimasi <46300254+Pamasi@users.noreply.github.com>

* Update Webots.rst

* Update intro to wsl

* Remove windows tabs

* Add windows WSL tab for extern controller code

* Clean tutorial

* Add ros2supervisorlauncher node creation in launch files

* Update intro to WSL

* Update tutorial with explanations

* include correct file for supervisor part

* Add WEBOTS_CONTROLLER_URL wsl infos

* cleanup

* Remove confusing sentence

* Update source/Tutorials/Advanced/Simulators/Webots.rst

Co-authored-by: Olivier Michel <Olivier.Michel@cyberbotics.com>

* Update source/Tutorials/Advanced/Simulators/Webots.rst

Co-authored-by: Olivier Michel <Olivier.Michel@cyberbotics.com>

* Squashed commit of the following:

commit 72effa7
Author: Luke Schmitt <85308904+LSinterbotix@users.noreply.github.com>
Date:   Tue Nov 1 17:26:25 2022 -0500

    Fix list formatting on Contact page (#3153)

commit dcd066f
Author: Dan Zimmerman <dan@danzimmerman.com>
Date:   Tue Nov 1 16:29:34 2022 -0400

    Update throttle logging docs with units and data type hints (re: rclcpp/issues/1929) (#3143)

    * Note milliseconds on API Concepts page

    * Add units and types to About Logging page

    Co-authored-by: dan <dan@polarworks.no>
    Co-authored-by: Chris Lalancette <clalancette@openrobotics.org>

commit 375b6cf
Author: definitelyuncertain <saikirann94@gmail.com>
Date:   Fri Oct 28 14:30:22 2022 -0500

    Change to mention explicit requirement for folder names for .msg and .srv files (#3144)

    * Change to mention explicit requirement for folder names for msg and srv files

    From ros2/tutorials#29

    * fix typo

    Co-authored-by: Tomoya Fujita <Tomoya.Fujita@sony.com>

    * fix rst formatting

    Co-authored-by: Chris Lalancette <clalancette@gmail.com>

    Co-authored-by: Tomoya Fujita <Tomoya.Fujita@sony.com>
    Co-authored-by: Chris Lalancette <clalancette@gmail.com>

commit da871ef
Author: Sergei Sergienko <divelix1@gmail.com>
Date:   Thu Oct 27 17:20:06 2022 +0300

    fix link to Gazebo-ROS2 bridge + CLI examples (#3139)

    * fix link to Gazebo-ROS2 bridge + CLI examples

    Co-authored-by: Chris Lalancette <clalancette@gmail.com>

commit e19c9b5
Author: Chris Lalancette <clalancette@openrobotics.org>
Date:   Wed Oct 26 16:31:21 2022 -0400

    Update the language to match the source code. (#3135)

    Fallout from #2865

    Signed-off-by: Chris Lalancette <clalancette@openrobotics.org>

commit a5910a1
Author: Chris Lalancette <clalancette@openrobotics.org>
Date:   Wed Oct 26 08:38:36 2022 -0400

    Shorten the Windows build-from-source path. (#3130)

    * Shorten the Windows build-from-source path.

    This is to keep the total length down below the 260 character
    limit imposed by Windows by default.

    Signed-off-by: Chris Lalancette <clalancette@openrobotics.org>

commit 8225686
Author: Chris Lalancette <clalancette@openrobotics.org>
Date:   Mon Oct 24 08:30:37 2022 -0400

    Fix up the variable name in the traveling in time (C++) tutorial. (#3115)

    This is just to match what is in the code in the upstream
    repository.

    Signed-off-by: Chris Lalancette <clalancette@openrobotics.org>

commit 87ab121
Author: Ian Colwell <48106342+icolwell-as@users.noreply.github.com>
Date:   Fri Oct 21 11:07:30 2022 -0400

    Update default WORKING_DIRECTORY for ament_add_gtest() (#3117)

commit 87bf20a
Author: chianfern <chianfern@gmail.com>
Date:   Tue Oct 18 21:36:57 2022 +0800

    Add ParameterDescriptor to 'Using parameters in a class (C++)' (#2865)

    * Rename node name in "Using parameters" C++ tutorial to be consistent with Python tutorial.

    Signed-off-by: Tan Chian Fern <chianfern@gmail.com>
    Signed-off-by: Chris Lalancette <clalancette@openrobotics.org>

commit 77646ce
Author: George Stavrinos <gstavrinos@protonmail.com>
Date:   Tue Oct 18 15:29:37 2022 +0300

    Fixed Intel's robot SDK repo with the new devkit name + reference to MoveIt2 instead of 1. (#3107)

commit 1d24955
Author: Chris Lalancette <clalancette@openrobotics.org>
Date:   Mon Oct 17 14:06:52 2022 -0400

    Monitor parameter changes: Add note to save callback handle (#3102)

    Signed-off-by: Chris Lalancette <clalancette@openrobotics.org>

commit 8910a80
Author: David V. Lu!! <davidvlu@gmail.com>
Date:   Fri Oct 14 09:56:14 2022 -0400

    Some testing basics (#3084)

    * Some testing basics

    Signed-off-by: David V. Lu <davidvlu@gmail.com>
    Signed-off-by: Chris Lalancette <clalancette@openrobotics.org>

commit 8771452
Author: Tomoya Fujita <Tomoya.Fujita@sony.com>
Date:   Fri Oct 14 05:34:20 2022 -0700

    Sony's task for Iron Release. (#3089)

    * Sony's task for Iron Release.

    Signed-off-by: Tomoya.Fujita <Tomoya.Fujita@sony.com>

    * Rearrange and add in links.

    Signed-off-by: Chris Lalancette <clalancette@openrobotics.org>

    Signed-off-by: Tomoya.Fujita <Tomoya.Fujita@sony.com>
    Signed-off-by: Chris Lalancette <clalancette@openrobotics.org>
    Co-authored-by: Chris Lalancette <clalancette@openrobotics.org>

commit 2ea9e7d
Author: Yannick Goumaz <61198661+ygoumaz@users.noreply.github.com>
Date:   Fri Oct 14 14:23:13 2022 +0200

    Update Setting-up a Robot Simulation (Webots) tutorial (#3090)

    * Update intro to WSL

    * Update world with declarations

    * Add supervisor node and environment var

    * Update tutorial with explanations

    Co-authored-by: ad-daniel <44834743+ad-daniel@users.noreply.github.com>

commit 0390a50
Author: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
Date:   Thu Oct 13 13:42:30 2022 -0400

    fix unresolved package requirement to install Humble on Ubuntu 20.04 (#3086) (#3088)

    * fix command to install humble on Ubuntu 20.04

    Co-authored-by: paolo.dimasi <paodimasi@outlook.com>
    Co-authored-by: Chris Lalancette <clalancette@openrobotics.org>
    (cherry picked from commit 5626af9)

    Co-authored-by: Paolo Dimasi <46300254+Pamasi@users.noreply.github.com>

* Update Webots.rst

* Update Webots.rst

* Remove trailing white spaces

* Update to VM and no supervisor

* Remove wrong text

* Update source/Tutorials/Advanced/Simulators/Webots.rst

Co-authored-by: Olivier Michel <Olivier.Michel@cyberbotics.com>

---------

Co-authored-by: ad-daniel <44834743+ad-daniel@users.noreply.github.com>
Co-authored-by: Olivier Michel <Olivier.Michel@cyberbotics.com>
(cherry picked from commit 588b10a)

Co-authored-by: Yannick Goumaz <61198661+ygoumaz@users.noreply.github.com>
audrow pushed a commit that referenced this pull request Feb 13, 2023
…3317) (#3331)

* Update intro to WSL

* Revert "Update intro to WSL"

This reverts commit 52a52d0.

* Update intro to wsl

* Remove windows tabs

* Add windows WSL tab for extern controller code

* Clean tutorial

* Update world with declarations

* Add supervisor node and environment var

* Add ros2supervisorlauncher node creation in launch files

* add env variable for linux

* Update tutorial with explanations

* Update source/Tutorials/Advanced/Simulators/Webots.rst

Co-authored-by: ad-daniel <44834743+ad-daniel@users.noreply.github.com>

* include correct file for supervisor part

* Add WEBOTS_CONTROLLER_URL wsl infos

* cleanup

* Update source/Tutorials/Advanced/Simulators/Webots.rst

Co-authored-by: Olivier Michel <Olivier.Michel@cyberbotics.com>

* Remove confusing sentence

* Update source/Tutorials/Advanced/Simulators/Webots.rst

Co-authored-by: Olivier Michel <Olivier.Michel@cyberbotics.com>

* Squashed commit of the following:

commit 72effa7
Author: Luke Schmitt <85308904+LSinterbotix@users.noreply.github.com>
Date:   Tue Nov 1 17:26:25 2022 -0500

    Fix list formatting on Contact page (#3153)

commit dcd066f
Author: Dan Zimmerman <dan@danzimmerman.com>
Date:   Tue Nov 1 16:29:34 2022 -0400

    Update throttle logging docs with units and data type hints (re: rclcpp/issues/1929) (#3143)

    * Note milliseconds on API Concepts page

    * Add units and types to About Logging page

    Co-authored-by: dan <dan@polarworks.no>
    Co-authored-by: Chris Lalancette <clalancette@openrobotics.org>

commit 375b6cf
Author: definitelyuncertain <saikirann94@gmail.com>
Date:   Fri Oct 28 14:30:22 2022 -0500

    Change to mention explicit requirement for folder names for .msg and .srv files (#3144)

    * Change to mention explicit requirement for folder names for msg and srv files

    From ros2/tutorials#29

    * fix typo

    Co-authored-by: Tomoya Fujita <Tomoya.Fujita@sony.com>

    * fix rst formatting

    Co-authored-by: Chris Lalancette <clalancette@gmail.com>

    Co-authored-by: Tomoya Fujita <Tomoya.Fujita@sony.com>
    Co-authored-by: Chris Lalancette <clalancette@gmail.com>

commit da871ef
Author: Sergei Sergienko <divelix1@gmail.com>
Date:   Thu Oct 27 17:20:06 2022 +0300

    fix link to Gazebo-ROS2 bridge + CLI examples (#3139)

    * fix link to Gazebo-ROS2 bridge + CLI examples

    Co-authored-by: Chris Lalancette <clalancette@gmail.com>

commit e19c9b5
Author: Chris Lalancette <clalancette@openrobotics.org>
Date:   Wed Oct 26 16:31:21 2022 -0400

    Update the language to match the source code. (#3135)

    Fallout from #2865

    Signed-off-by: Chris Lalancette <clalancette@openrobotics.org>

commit a5910a1
Author: Chris Lalancette <clalancette@openrobotics.org>
Date:   Wed Oct 26 08:38:36 2022 -0400

    Shorten the Windows build-from-source path. (#3130)

    * Shorten the Windows build-from-source path.

    This is to keep the total length down below the 260 character
    limit imposed by Windows by default.

    Signed-off-by: Chris Lalancette <clalancette@openrobotics.org>

commit 8225686
Author: Chris Lalancette <clalancette@openrobotics.org>
Date:   Mon Oct 24 08:30:37 2022 -0400

    Fix up the variable name in the traveling in time (C++) tutorial. (#3115)

    This is just to match what is in the code in the upstream
    repository.

    Signed-off-by: Chris Lalancette <clalancette@openrobotics.org>

commit 87ab121
Author: Ian Colwell <48106342+icolwell-as@users.noreply.github.com>
Date:   Fri Oct 21 11:07:30 2022 -0400

    Update default WORKING_DIRECTORY for ament_add_gtest() (#3117)

commit 87bf20a
Author: chianfern <chianfern@gmail.com>
Date:   Tue Oct 18 21:36:57 2022 +0800

    Add ParameterDescriptor to 'Using parameters in a class (C++)' (#2865)

    * Rename node name in "Using parameters" C++ tutorial to be consistent with Python tutorial.

    Signed-off-by: Tan Chian Fern <chianfern@gmail.com>
    Signed-off-by: Chris Lalancette <clalancette@openrobotics.org>

commit 77646ce
Author: George Stavrinos <gstavrinos@protonmail.com>
Date:   Tue Oct 18 15:29:37 2022 +0300

    Fixed Intel's robot SDK repo with the new devkit name + reference to MoveIt2 instead of 1. (#3107)

commit 1d24955
Author: Chris Lalancette <clalancette@openrobotics.org>
Date:   Mon Oct 17 14:06:52 2022 -0400

    Monitor parameter changes: Add note to save callback handle (#3102)

    Signed-off-by: Chris Lalancette <clalancette@openrobotics.org>

commit 8910a80
Author: David V. Lu!! <davidvlu@gmail.com>
Date:   Fri Oct 14 09:56:14 2022 -0400

    Some testing basics (#3084)

    * Some testing basics

    Signed-off-by: David V. Lu <davidvlu@gmail.com>
    Signed-off-by: Chris Lalancette <clalancette@openrobotics.org>

commit 8771452
Author: Tomoya Fujita <Tomoya.Fujita@sony.com>
Date:   Fri Oct 14 05:34:20 2022 -0700

    Sony's task for Iron Release. (#3089)

    * Sony's task for Iron Release.

    Signed-off-by: Tomoya.Fujita <Tomoya.Fujita@sony.com>

    * Rearrange and add in links.

    Signed-off-by: Chris Lalancette <clalancette@openrobotics.org>

    Signed-off-by: Tomoya.Fujita <Tomoya.Fujita@sony.com>
    Signed-off-by: Chris Lalancette <clalancette@openrobotics.org>
    Co-authored-by: Chris Lalancette <clalancette@openrobotics.org>

commit 2ea9e7d
Author: Yannick Goumaz <61198661+ygoumaz@users.noreply.github.com>
Date:   Fri Oct 14 14:23:13 2022 +0200

    Update Setting-up a Robot Simulation (Webots) tutorial (#3090)

    * Update intro to WSL

    * Update world with declarations

    * Add supervisor node and environment var

    * Update tutorial with explanations

    Co-authored-by: ad-daniel <44834743+ad-daniel@users.noreply.github.com>

commit 0390a50
Author: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
Date:   Thu Oct 13 13:42:30 2022 -0400

    fix unresolved package requirement to install Humble on Ubuntu 20.04 (#3086) (#3088)

    * fix command to install humble on Ubuntu 20.04

    Co-authored-by: paolo.dimasi <paodimasi@outlook.com>
    Co-authored-by: Chris Lalancette <clalancette@openrobotics.org>
    (cherry picked from commit 5626af9)

    Co-authored-by: Paolo Dimasi <46300254+Pamasi@users.noreply.github.com>

* Update Webots.rst

* Update intro to wsl

* Remove windows tabs

* Add windows WSL tab for extern controller code

* Clean tutorial

* Add ros2supervisorlauncher node creation in launch files

* Update intro to WSL

* Update tutorial with explanations

* include correct file for supervisor part

* Add WEBOTS_CONTROLLER_URL wsl infos

* cleanup

* Remove confusing sentence

* Update source/Tutorials/Advanced/Simulators/Webots.rst

Co-authored-by: Olivier Michel <Olivier.Michel@cyberbotics.com>

* Update source/Tutorials/Advanced/Simulators/Webots.rst

Co-authored-by: Olivier Michel <Olivier.Michel@cyberbotics.com>

* Squashed commit of the following:

commit 72effa7
Author: Luke Schmitt <85308904+LSinterbotix@users.noreply.github.com>
Date:   Tue Nov 1 17:26:25 2022 -0500

    Fix list formatting on Contact page (#3153)

commit dcd066f
Author: Dan Zimmerman <dan@danzimmerman.com>
Date:   Tue Nov 1 16:29:34 2022 -0400

    Update throttle logging docs with units and data type hints (re: rclcpp/issues/1929) (#3143)

    * Note milliseconds on API Concepts page

    * Add units and types to About Logging page

    Co-authored-by: dan <dan@polarworks.no>
    Co-authored-by: Chris Lalancette <clalancette@openrobotics.org>

commit 375b6cf
Author: definitelyuncertain <saikirann94@gmail.com>
Date:   Fri Oct 28 14:30:22 2022 -0500

    Change to mention explicit requirement for folder names for .msg and .srv files (#3144)

    * Change to mention explicit requirement for folder names for msg and srv files

    From ros2/tutorials#29

    * fix typo

    Co-authored-by: Tomoya Fujita <Tomoya.Fujita@sony.com>

    * fix rst formatting

    Co-authored-by: Chris Lalancette <clalancette@gmail.com>

    Co-authored-by: Tomoya Fujita <Tomoya.Fujita@sony.com>
    Co-authored-by: Chris Lalancette <clalancette@gmail.com>

commit da871ef
Author: Sergei Sergienko <divelix1@gmail.com>
Date:   Thu Oct 27 17:20:06 2022 +0300

    fix link to Gazebo-ROS2 bridge + CLI examples (#3139)

    * fix link to Gazebo-ROS2 bridge + CLI examples

    Co-authored-by: Chris Lalancette <clalancette@gmail.com>

commit e19c9b5
Author: Chris Lalancette <clalancette@openrobotics.org>
Date:   Wed Oct 26 16:31:21 2022 -0400

    Update the language to match the source code. (#3135)

    Fallout from #2865

    Signed-off-by: Chris Lalancette <clalancette@openrobotics.org>

commit a5910a1
Author: Chris Lalancette <clalancette@openrobotics.org>
Date:   Wed Oct 26 08:38:36 2022 -0400

    Shorten the Windows build-from-source path. (#3130)

    * Shorten the Windows build-from-source path.

    This is to keep the total length down below the 260 character
    limit imposed by Windows by default.

    Signed-off-by: Chris Lalancette <clalancette@openrobotics.org>

commit 8225686
Author: Chris Lalancette <clalancette@openrobotics.org>
Date:   Mon Oct 24 08:30:37 2022 -0400

    Fix up the variable name in the traveling in time (C++) tutorial. (#3115)

    This is just to match what is in the code in the upstream
    repository.

    Signed-off-by: Chris Lalancette <clalancette@openrobotics.org>

commit 87ab121
Author: Ian Colwell <48106342+icolwell-as@users.noreply.github.com>
Date:   Fri Oct 21 11:07:30 2022 -0400

    Update default WORKING_DIRECTORY for ament_add_gtest() (#3117)

commit 87bf20a
Author: chianfern <chianfern@gmail.com>
Date:   Tue Oct 18 21:36:57 2022 +0800

    Add ParameterDescriptor to 'Using parameters in a class (C++)' (#2865)

    * Rename node name in "Using parameters" C++ tutorial to be consistent with Python tutorial.

    Signed-off-by: Tan Chian Fern <chianfern@gmail.com>
    Signed-off-by: Chris Lalancette <clalancette@openrobotics.org>

commit 77646ce
Author: George Stavrinos <gstavrinos@protonmail.com>
Date:   Tue Oct 18 15:29:37 2022 +0300

    Fixed Intel's robot SDK repo with the new devkit name + reference to MoveIt2 instead of 1. (#3107)

commit 1d24955
Author: Chris Lalancette <clalancette@openrobotics.org>
Date:   Mon Oct 17 14:06:52 2022 -0400

    Monitor parameter changes: Add note to save callback handle (#3102)

    Signed-off-by: Chris Lalancette <clalancette@openrobotics.org>

commit 8910a80
Author: David V. Lu!! <davidvlu@gmail.com>
Date:   Fri Oct 14 09:56:14 2022 -0400

    Some testing basics (#3084)

    * Some testing basics

    Signed-off-by: David V. Lu <davidvlu@gmail.com>
    Signed-off-by: Chris Lalancette <clalancette@openrobotics.org>

commit 8771452
Author: Tomoya Fujita <Tomoya.Fujita@sony.com>
Date:   Fri Oct 14 05:34:20 2022 -0700

    Sony's task for Iron Release. (#3089)

    * Sony's task for Iron Release.

    Signed-off-by: Tomoya.Fujita <Tomoya.Fujita@sony.com>

    * Rearrange and add in links.

    Signed-off-by: Chris Lalancette <clalancette@openrobotics.org>

    Signed-off-by: Tomoya.Fujita <Tomoya.Fujita@sony.com>
    Signed-off-by: Chris Lalancette <clalancette@openrobotics.org>
    Co-authored-by: Chris Lalancette <clalancette@openrobotics.org>

commit 2ea9e7d
Author: Yannick Goumaz <61198661+ygoumaz@users.noreply.github.com>
Date:   Fri Oct 14 14:23:13 2022 +0200

    Update Setting-up a Robot Simulation (Webots) tutorial (#3090)

    * Update intro to WSL

    * Update world with declarations

    * Add supervisor node and environment var

    * Update tutorial with explanations

    Co-authored-by: ad-daniel <44834743+ad-daniel@users.noreply.github.com>

commit 0390a50
Author: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
Date:   Thu Oct 13 13:42:30 2022 -0400

    fix unresolved package requirement to install Humble on Ubuntu 20.04 (#3086) (#3088)

    * fix command to install humble on Ubuntu 20.04

    Co-authored-by: paolo.dimasi <paodimasi@outlook.com>
    Co-authored-by: Chris Lalancette <clalancette@openrobotics.org>
    (cherry picked from commit 5626af9)

    Co-authored-by: Paolo Dimasi <46300254+Pamasi@users.noreply.github.com>

* Update Webots.rst

* Update Webots.rst

* Remove trailing white spaces

* Update to VM and no supervisor

* Remove wrong text

* Update source/Tutorials/Advanced/Simulators/Webots.rst

Co-authored-by: Olivier Michel <Olivier.Michel@cyberbotics.com>

---------

Co-authored-by: ad-daniel <44834743+ad-daniel@users.noreply.github.com>
Co-authored-by: Olivier Michel <Olivier.Michel@cyberbotics.com>
(cherry picked from commit 588b10a)

Co-authored-by: Yannick Goumaz <61198661+ygoumaz@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport-all backport at reviewers discretion; from rolling to all versions
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Intermediate: Monitoring for parameter changes (C++)
2 participants