Add support for specifying parent container #86
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Pretty cool. Okay, keeping |
rstacruz
added a commit
that referenced
this pull request
Jun 21, 2014
Add support for specifying parent container
rstacruz
added a commit
that referenced
this pull request
Jun 21, 2014
|
This has now been implemented. Documented here: https://github.com/rstacruz/nprogress/blob/master/Readme.md#parent |
This was referenced Jun 21, 2014
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR addresses @rstacruz' comments from #33 and updated it to work without the jQuery dependency.
Good idea on adding a conditional class to avoid having to adjust css values.
I opted to keep the
parentoption because I feel code ought to be self-documenting, and one of the first things I look for when reading a piece of code is look for the options hash. Having the default just be 'body' specified in string form implies you just need a CSS selector. I think atleast 😄, I don't mind removing it if you'd prefer though.