Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add sidebars #479

Merged
merged 79 commits into from
Mar 4, 2023
Merged

Add sidebars #479

merged 79 commits into from
Mar 4, 2023

Conversation

cpsievert
Copy link
Collaborator

@cpsievert cpsievert commented Jan 24, 2023 •
edited
Loading

See the NEWS.md for a summary of what this PR does.

Closes #480 (as a side-effect)

TODO

  • Automated tests
  • Add bindCache() to flights demo

TODO (in follow-up PRs)

  • Add fillable = fill argument to shiny::uiOutput(). Deprecate "container"/"item" value.
  • Add a card_body_fillable() alias for card_body_fill() (and make the latter @Keywords internal?)
  • Add a page_fillable() alias for page_fill()?
  • Get rid of fill argument in layout_column_wrap() and instead add that behavior as a heights_equal option?
  • Consider renaming fillable to fillable_panel once we've renamed nav() to nav_panel() (Add nav_panel() alias for nav() and navset_*() aliases for navs_*() #476)

@cpsievert cpsievert requested a review from jcheng5 January 24, 2023 17:50
@cpsievert cpsievert marked this pull request as draft January 25, 2023 21:28
cpsievert
cpsievert commented Feb 6, 2023
View reviewed changes
inst/components/fill.scss Outdated Show resolved Hide resolved
@cpsievert cpsievert changed the title Add sidebar(), layout_sidebar(), card_sidebar(), and container() Add sidebar(), layout_sidebar(), card_sidebar(), and contain_width() Feb 7, 2023
@jcheng5 jcheng5 self-requested a review February 23, 2023 23:12
cpsievert and others added 14 commits February 24, 2023 16:10
@cpsievert
Accessibility fixes; note about potential to animate grid-template-rows
27b0988
@cpsievert
Resave distributed files (GitHub Action)
1ded55f
@cpsievert
Resave data (GitHub Action)
9931bc0
@cpsievert
Merge branch 'main' into sidebars
1c7cf79
@cpsievert
Add comment about using span for accordion headers
d2795aa
@cpsievert
Clean-up Rd docs; provide a contrasting color when bg color is speci…
f8b73a9 
…fied
@cpsievert
devtools::document() (GitHub Actions)
47cc164
@cpsievert
Resave distributed files (GitHub Action)
2ae8678
@cpsievert
Overhaul sidebar article; avoid toggle overlap in nested layouts; oth…
e21b9c7 
…er CSS fixes
@cpsievert
Resave distributed files (GitHub Action)
2ba552c
@cpsievert
Resave data (GitHub Action)
37f3cfd
@cpsievert
More fixes/writing
ba42154
@cpsievert
Don't wrap header/footer up in a fluidRow() with a modern theme; groo…
691b3e1 
…m NEWS
@cpsievert
devtools::document() (GitHub Actions)
b4bd499
@cpsievert cpsievert mentioned this pull request Mar 3, 2023
Merged
@cpsievert cpsievert mentioned this pull request Mar 3, 2023
Merged
@cpsievert cpsievert merged commit 2964213 into main Mar 4, 2023
@cpsievert cpsievert deleted the sidebars branch March 4, 2023 00:18
This was referenced Mar 6, 2023
Merged
Merged
Merged
@cpsievert cpsievert mentioned this pull request Mar 27, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jcheng5 jcheng5 jcheng5 approved these changes

Assignees

@cpsievert cpsievert

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Nested nav containers
2 participants
@cpsievert @jcheng5