Beginning of a French translation #28
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks Samuel, that's fantastic work - I'll take a proper look at it tonight. |
|
Just checked it out, looks great - if you're ok with the contribution terms at https://github.com/rtyley/agit/wiki/Contributing I'll be happy to merge this request - will also look at updating Time.java |
|
Those changes are trivial enough, I therefore place them into the public domain. |
|
Brilliant - thank you! |
rtyley
added a commit
that referenced
this pull request
Jul 28, 2011
Beginning of a French translation
rtyley
added a commit
that referenced
this pull request
Jul 29, 2011
I am now officially in love with this method for formatting relative times: http://developer.android.com/reference/android/text/format/DateUtils.html#getRelativeTimeSpanString(long) - allows me to delete a big ugly method. Hurrah!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Here is the beginning of a French translation.
More efforts will be needed to localize the com.magdag.agit.util.Time class, as you will have to do pattern substitutions ("%d days ago" -> "il y a %d jours") which have to be done with a Context around.