Update Rubicon Adapter support for 1.0 mediaTypes - release/0.34.5 (HB-2228)#14

Closed

idettman wants to merge 54 commits intomasterfrom rubicon-adapter-media-type-updata

+1,123-179

Commits on Feb 7, 2018

in progress
Isaac Dettman
committed
Added single request does not group video requests
Isaac Dettman
committed
Does not group requests if singleRequest is not true
Isaac Dettman
committed
Update to required params comment
Isaac Dettman
committed
Update to unit test describe message
Isaac Dettman
committed
Commented out unnecessary test after modifications to interpret response method changes for single response
Isaac Dettman
committed
Removed commented out test
Isaac Dettman
committed
Add interpret response test for single request mode enabled
Isaac Dettman
committed
Added bidderRequest to createVideoBid function signature
Isaac Dettman
committed

Commits on Feb 8, 2018

Added combineSlotUrlParams method and unit tests
Isaac Dettman
committed
Separated video request from build request
Isaac Dettman
committed

Commits on Feb 12, 2018

Added createSlotParams function and implemented in buildRequests
Isaac Dettman
committed
Removed commented code and changed method signature for handling single request mode
Isaac Dettman
committed
Fixed argument access for interpret response
Isaac Dettman
committed
Fixed obj property accessor
Isaac Dettman
committed

Commits on Feb 13, 2018

Extracted function to group lists by siteId
Isaac Dettman
committed
Removed unused function arguments
Isaac Dettman
committed
Added jsdoc for siteId grouping function
Isaac Dettman
committed
Refactored interpret response and modified param properties
Isaac Dettman
committed
Refactored groupBidRequests to be in-lined since it was only called once
Isaac Dettman
committed
Modified comment summary for associateBidRequest
Isaac Dettman
committed
Modified code for easier code merge
Isaac Dettman
committed
Reverted digitrust function in-lining
Isaac Dettman
committed
Added missing function jsdoc
Isaac Dettman
committed

Commits on Feb 14, 2018

Added cpm sort to fix broken unit tests
Isaac Dettman
committed
Fixed linting errors
Isaac Dettman
committed
Bug fix to map converted bids before combining, added empty/undefined test to query string param concatenation
Isaac Dettman
committed

Commits on Feb 15, 2018

Added referrer and page_url changes and spec sinon sandbox.stub update for sinon 2.0 compatibility
Isaac Dettman
committed
Added referrer and page_url changes
Isaac Dettman
committed
Fixed broken unit tests
Isaac Dettman
committed

Commits on Feb 16, 2018

Added request parameter tg_fl.eid for non-video requests
idettman
committed
Removed spaces to correct linting error
Isaac Dettman
committed
Replaced calls to JSON.stringify and parse with the 'clone' helper function
Isaac Dettman
committed
Updated unit tests for new sra get param 'tg_fl.eid'
Isaac Dettman
committed
Updated with requested changes from pull request
Isaac Dettman
committed
Extracted code for page_url to a function for reuse
Isaac Dettman
committed
Added unit test for sra request limited to 10 slots
Isaac Dettman
committed
Updated comment
Isaac Dettman
committed
Added warning for bids dropped from SRA get request
Isaac Dettman
committed
Changed log execution line ordering in max bids limit block
Isaac Dettman
committed
Updated until test description
Isaac Dettman
committed
Added unit test for expectedQuery function
Isaac Dettman
committed
Fixed unit test for createSlotParams
Isaac Dettman
committed

Commits on Feb 17, 2018

Replaced media type string values with constants from mediaTypes.js
Isaac Dettman
committed
Updated mediaType logic using prebid/Prebid.js@master...rubicon-project:fix_media_type_name as reference
Isaac Dettman
committed

Commits on Feb 20, 2018

Added support for 'mediaTypes' and 'mediaType' required change for Prebid 1.0 http://prebid.org/dev-docs/prebid-1.0-API.html#ad-unit-changes
Isaac Dettman
committed

Commits on Feb 22, 2018

Merge branch 'rubicon-adapter-single-request' into rubicon-adapter-media-type-updata
Isaac Dettman
committed
Updated unit test with requested changes
Isaac Dettman
committed
Updated has video with requested change
Isaac Dettman
committed
Updated with changes from SRA branch
Isaac Dettman
committed

Commits on Feb 23, 2018

Update with suggestion from moonshells PR comment re: breaking backwards compatibility
Isaac Dettman
committed
Added more unit tests for the video validation compatibility fix.
Isaac Dettman
committed
Added additional unit tests for interpret response
Isaac Dettman
committed
Fix for validate bids
Isaac Dettman
committed