Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update Rubicon Adapter support for 1.0 mediaTypes - release/0.34.5 (HB-2228) #14

Closed
wants to merge 54 commits into from
Closed

Update Rubicon Adapter support for 1.0 mediaTypes - release/0.34.5 (HB-2228) #14

wants to merge 54 commits into from

Commits on Feb 7, 2018

  1. in progress

    Isaac Dettman committed Feb 7, 2018
    Configuration menu
    Copy the full SHA
    b55c09c View commit details
    Browse the repository at this point in the history

  2. Added single request does not group video requests

    Isaac Dettman committed Feb 7, 2018
    Configuration menu
    Copy the full SHA
    1b6e138 View commit details
    Browse the repository at this point in the history

  3. Does not group requests if singleRequest is not true

    Isaac Dettman committed Feb 7, 2018
    Configuration menu
    Copy the full SHA
    005f56c View commit details
    Browse the repository at this point in the history

  4. Update to required params comment

    Isaac Dettman committed Feb 7, 2018
    Configuration menu
    Copy the full SHA
    ffec6ba View commit details
    Browse the repository at this point in the history

  5. Update to unit test describe message

    Isaac Dettman committed Feb 7, 2018
    Configuration menu
    Copy the full SHA
    513fb0e View commit details
    Browse the repository at this point in the history

  6. Commented out unnecessary test after modifications to interpret respo… 

    …nse method changes for single response
    Isaac Dettman committed Feb 7, 2018
    Configuration menu
    Copy the full SHA
    c0e190d View commit details
    Browse the repository at this point in the history

  7. Removed commented out test

    Isaac Dettman committed Feb 7, 2018
    Configuration menu
    Copy the full SHA
    f16054b View commit details
    Browse the repository at this point in the history

  8. Add interpret response test for single request mode enabled

    Isaac Dettman committed Feb 7, 2018
    Configuration menu
    Copy the full SHA
    1e12c24 View commit details
    Browse the repository at this point in the history

  9. Added bidderRequest to createVideoBid function signature

    Isaac Dettman committed Feb 7, 2018
    Configuration menu
    Copy the full SHA
    8b726fb View commit details
    Browse the repository at this point in the history

Commits on Feb 8, 2018

  1. Added combineSlotUrlParams method and unit tests

    Isaac Dettman committed Feb 8, 2018
    Configuration menu
    Copy the full SHA
    b7e51dc View commit details
    Browse the repository at this point in the history

  2. Separated video request from build request

    Isaac Dettman committed Feb 8, 2018
    Configuration menu
    Copy the full SHA
    7ffdac3 View commit details
    Browse the repository at this point in the history

Commits on Feb 12, 2018

  1. Added createSlotParams function and implemented in buildRequests

    Isaac Dettman committed Feb 12, 2018
    Configuration menu
    Copy the full SHA
    cb5dd24 View commit details
    Browse the repository at this point in the history

  2. Removed commented code and changed method signature for handling sing… 

    …le request mode
    Isaac Dettman committed Feb 12, 2018
    Configuration menu
    Copy the full SHA
    35514f7 View commit details
    Browse the repository at this point in the history

  3. Fixed argument access for interpret response

    Isaac Dettman committed Feb 12, 2018
    Configuration menu
    Copy the full SHA
    d72a1a5 View commit details
    Browse the repository at this point in the history

  4. Fixed obj property accessor

    Isaac Dettman committed Feb 12, 2018
    Configuration menu
    Copy the full SHA
    d271daa View commit details
    Browse the repository at this point in the history

Commits on Feb 13, 2018

  1. Extracted function to group lists by siteId

    Isaac Dettman committed Feb 13, 2018
    Configuration menu
    Copy the full SHA
    ed46380 View commit details
    Browse the repository at this point in the history

  2. Removed unused function arguments

    Isaac Dettman committed Feb 13, 2018
    Configuration menu
    Copy the full SHA
    c771411 View commit details
    Browse the repository at this point in the history

  3. Added jsdoc for siteId grouping function

    Isaac Dettman committed Feb 13, 2018
    Configuration menu
    Copy the full SHA
    f661350 View commit details
    Browse the repository at this point in the history

  4. Refactored interpret response and modified param properties

    Isaac Dettman committed Feb 13, 2018
    Configuration menu
    Copy the full SHA
    7d46693 View commit details
    Browse the repository at this point in the history

  5. Refactored groupBidRequests to be in-lined since it was only called once

    Isaac Dettman committed Feb 13, 2018
    Configuration menu
    Copy the full SHA
    766a88a View commit details
    Browse the repository at this point in the history

  6. Modified comment summary for associateBidRequest

    Isaac Dettman committed Feb 13, 2018
    Configuration menu
    Copy the full SHA
    1187a1c View commit details
    Browse the repository at this point in the history

  7. Modified code for easier code merge

    Isaac Dettman committed Feb 13, 2018
    Configuration menu
    Copy the full SHA
    2d26659 View commit details
    Browse the repository at this point in the history

  8. Reverted digitrust function in-lining

    Isaac Dettman committed Feb 13, 2018
    Configuration menu
    Copy the full SHA
    826261a View commit details
    Browse the repository at this point in the history

  9. Added missing function jsdoc

    Isaac Dettman committed Feb 13, 2018
    Configuration menu
    Copy the full SHA
    0dc32d7 View commit details
    Browse the repository at this point in the history

Commits on Feb 14, 2018

  1. Added cpm sort to fix broken unit tests

    Isaac Dettman committed Feb 14, 2018
    Configuration menu
    Copy the full SHA
    d9c70e6 View commit details
    Browse the repository at this point in the history

  2. Fixed linting errors

    Isaac Dettman committed Feb 14, 2018
    Configuration menu
    Copy the full SHA
    3797107 View commit details
    Browse the repository at this point in the history

  3. Bug fix to map converted bids before combining, added empty/undefined… 

    … test to query string param concatenation
    Isaac Dettman committed Feb 14, 2018
    Configuration menu
    Copy the full SHA
    4ffa40d View commit details
    Browse the repository at this point in the history

Commits on Feb 15, 2018

  1. Added referrer and page_url changes and spec sinon sandbox.stub updat… 

    …e for sinon 2.0 compatibility
    Isaac Dettman committed Feb 15, 2018
    Configuration menu
    Copy the full SHA
    85ffec7 View commit details
    Browse the repository at this point in the history

  2. Added referrer and page_url changes

    Isaac Dettman committed Feb 15, 2018
    Configuration menu
    Copy the full SHA
    df3d331 View commit details
    Browse the repository at this point in the history

  3. Fixed broken unit tests

    Isaac Dettman committed Feb 15, 2018
    Configuration menu
    Copy the full SHA
    da85489 View commit details
    Browse the repository at this point in the history

Commits on Feb 16, 2018

  1. Added request parameter tg_fl.eid for non-video requests

    @idettman
    idettman committed Feb 16, 2018
    Configuration menu
    Copy the full SHA
    2752d7b View commit details
    Browse the repository at this point in the history

  2. Removed spaces to correct linting error

    Isaac Dettman committed Feb 16, 2018
    Configuration menu
    Copy the full SHA
    0cc3a43 View commit details
    Browse the repository at this point in the history

  3. Replaced calls to JSON.stringify and parse with the 'clone' helper fu… 

    …nction
    Isaac Dettman committed Feb 16, 2018
    Configuration menu
    Copy the full SHA
    088c7ea View commit details
    Browse the repository at this point in the history

  4. Updated unit tests for new sra get param 'tg_fl.eid'

    Isaac Dettman committed Feb 16, 2018
    Configuration menu
    Copy the full SHA
    06ce341 View commit details
    Browse the repository at this point in the history

  5. Updated with requested changes from pull request

    Isaac Dettman committed Feb 16, 2018
    Configuration menu
    Copy the full SHA
    36aad9f View commit details
    Browse the repository at this point in the history

  6. Extracted code for page_url to a function for reuse

    Isaac Dettman committed Feb 16, 2018
    Configuration menu
    Copy the full SHA
    151f268 View commit details
    Browse the repository at this point in the history

  7. Added unit test for sra request limited to 10 slots

    Isaac Dettman committed Feb 16, 2018
    Configuration menu
    Copy the full SHA
    653b19e View commit details
    Browse the repository at this point in the history

  8. Updated comment

    Isaac Dettman committed Feb 16, 2018
    Configuration menu
    Copy the full SHA
    a2cf89c View commit details
    Browse the repository at this point in the history

  9. Added warning for bids dropped from SRA get request

    Isaac Dettman committed Feb 16, 2018
    Configuration menu
    Copy the full SHA
    8fb38e0 View commit details
    Browse the repository at this point in the history

  10. Changed log execution line ordering in max bids limit block

    Isaac Dettman committed Feb 16, 2018
    Configuration menu
    Copy the full SHA
    b9e747b View commit details
    Browse the repository at this point in the history

  11. Updated until test description

    Isaac Dettman committed Feb 16, 2018
    Configuration menu
    Copy the full SHA
    25dd212 View commit details
    Browse the repository at this point in the history

  12. Added unit test for expectedQuery function

    Isaac Dettman committed Feb 16, 2018
    Configuration menu
    Copy the full SHA
    d914977 View commit details
    Browse the repository at this point in the history

  13. Fixed unit test for createSlotParams

    Isaac Dettman committed Feb 16, 2018
    Configuration menu
    Copy the full SHA
    595fa90 View commit details
    Browse the repository at this point in the history

Commits on Feb 17, 2018

  1. Replaced media type string values with constants from mediaTypes.js

    Isaac Dettman committed Feb 17, 2018
    Configuration menu
    Copy the full SHA
    4e50100 View commit details
    Browse the repository at this point in the history

  2. Updated mediaType logic using prebid/Prebid.js@master...rubicon-proje… 

    …ct:fix_media_type_name as reference
    Isaac Dettman committed Feb 17, 2018
    Configuration menu
    Copy the full SHA
    4a72c74 View commit details
    Browse the repository at this point in the history

Commits on Feb 20, 2018

  1. Added support for 'mediaTypes' and 'mediaType' required change for Pr… 

    …ebid 1.0 http://prebid.org/dev-docs/prebid-1.0-API.html#ad-unit-changes
    Isaac Dettman committed Feb 20, 2018
    Configuration menu
    Copy the full SHA
    88d0189 View commit details
    Browse the repository at this point in the history

Commits on Feb 22, 2018

  1. Merge branch 'rubicon-adapter-single-request' into rubicon-adapter-me… 

    …dia-type-updata

# Conflicts:
#	modules/rubiconBidAdapter.js
#	test/spec/modules/rubiconBidAdapter_spec.js
    Isaac Dettman committed Feb 22, 2018
    Configuration menu
    Copy the full SHA
    92e48e7 View commit details
    Browse the repository at this point in the history

  2. Updated unit test with requested changes

    Isaac Dettman committed Feb 22, 2018
    Configuration menu
    Copy the full SHA
    c590a27 View commit details
    Browse the repository at this point in the history

  3. Updated has video with requested change

    Isaac Dettman committed Feb 22, 2018
    Configuration menu
    Copy the full SHA
    63dbdd8 View commit details
    Browse the repository at this point in the history

  4. Updated with changes from SRA branch

    Isaac Dettman committed Feb 22, 2018
    Configuration menu
    Copy the full SHA
    fe69622 View commit details
    Browse the repository at this point in the history

Commits on Feb 23, 2018

  1. Update with suggestion from moonshells PR comment re: breaking backwa… 

    …rds compatibility
    Isaac Dettman committed Feb 23, 2018
    Configuration menu
    Copy the full SHA
    bca2c82 View commit details
    Browse the repository at this point in the history

  2. Added more unit tests for the video validation compatibility fix. 

    Updated 'parseSizes' to fix an error found by the added tests.
    Isaac Dettman committed Feb 23, 2018
    Configuration menu
    Copy the full SHA
    cbce153 View commit details
    Browse the repository at this point in the history

  3. Added additional unit tests for interpret response

    Isaac Dettman committed Feb 23, 2018
    Configuration menu
    Copy the full SHA
    57b11e0 View commit details
    Browse the repository at this point in the history

  4. Fix for validate bids

    Isaac Dettman committed Feb 23, 2018
    Configuration menu
    Copy the full SHA
    facc769 View commit details
    Browse the repository at this point in the history