Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Rubicon Adapter support for 1.0 mediaTypes - release/0.34.5 (HB-2228) #14

Closed
wants to merge 54 commits into from
Closed
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
54 commits
Select commit Hold shift + click to select a range
b55c09c
in progress
Feb 7, 2018
1b6e138
Added single request does not group video requests
Feb 7, 2018
005f56c
Does not group requests if singleRequest is not true
Feb 7, 2018
ffec6ba
Update to required params comment
Feb 7, 2018
513fb0e
Update to unit test describe message
Feb 7, 2018
c0e190d
Commented out unnecessary test after modifications to interpret respo…
Feb 7, 2018
f16054b
Removed commented out test
Feb 7, 2018
1e12c24
Add interpret response test for single request mode enabled
Feb 7, 2018
8b726fb
Added bidderRequest to createVideoBid function signature
Feb 7, 2018
b7e51dc
Added combineSlotUrlParams method and unit tests
Feb 8, 2018
7ffdac3
Separated video request from build request
Feb 8, 2018
cb5dd24
Added createSlotParams function and implemented in buildRequests
Feb 12, 2018
35514f7
Removed commented code and changed method signature for handling sing…
Feb 12, 2018
d72a1a5
Fixed argument access for interpret response
Feb 12, 2018
d271daa
Fixed obj property accessor
Feb 12, 2018
ed46380
Extracted function to group lists by siteId
Feb 13, 2018
c771411
Removed unused function arguments
Feb 13, 2018
f661350
Added jsdoc for siteId grouping function
Feb 13, 2018
7d46693
Refactored interpret response and modified param properties
Feb 13, 2018
766a88a
Refactored groupBidRequests to be in-lined since it was only called once
Feb 13, 2018
1187a1c
Modified comment summary for associateBidRequest
Feb 13, 2018
2d26659
Modified code for easier code merge
Feb 13, 2018
826261a
Reverted digitrust function in-lining
Feb 13, 2018
0dc32d7
Added missing function jsdoc
Feb 13, 2018
d9c70e6
Added cpm sort to fix broken unit tests
Feb 14, 2018
3797107
Fixed linting errors
Feb 14, 2018
4ffa40d
Bug fix to map converted bids before combining, added empty/undefined…
Feb 14, 2018
85ffec7
Added referrer and page_url changes and spec sinon sandbox.stub updat…
Feb 15, 2018
df3d331
Added referrer and page_url changes
Feb 15, 2018
da85489
Fixed broken unit tests
Feb 15, 2018
2752d7b
Added request parameter tg_fl.eid for non-video requests
idettman Feb 16, 2018
0cc3a43
Removed spaces to correct linting error
Feb 16, 2018
088c7ea
Replaced calls to JSON.stringify and parse with the 'clone' helper fu…
Feb 16, 2018
06ce341
Updated unit tests for new sra get param 'tg_fl.eid'
Feb 16, 2018
36aad9f
Updated with requested changes from pull request
Feb 16, 2018
151f268
Extracted code for page_url to a function for reuse
Feb 16, 2018
653b19e
Added unit test for sra request limited to 10 slots
Feb 16, 2018
a2cf89c
Updated comment
Feb 16, 2018
8fb38e0
Added warning for bids dropped from SRA get request
Feb 16, 2018
b9e747b
Changed log execution line ordering in max bids limit block
Feb 16, 2018
25dd212
Updated until test description
Feb 16, 2018
d914977
Added unit test for expectedQuery function
Feb 16, 2018
595fa90
Fixed unit test for createSlotParams
Feb 16, 2018
4e50100
Replaced media type string values with constants from mediaTypes.js
Feb 17, 2018
4a72c74
Updated mediaType logic using https://github.com/prebid/Prebid.js/com…
Feb 17, 2018
88d0189
Added support for 'mediaTypes' and 'mediaType' required change for Pr…
Feb 20, 2018
92e48e7
Merge branch 'rubicon-adapter-single-request' into rubicon-adapter-me…
Feb 22, 2018
c590a27
Updated unit test with requested changes
Feb 22, 2018
63dbdd8
Updated has video with requested change
Feb 22, 2018
fe69622
Updated with changes from SRA branch
Feb 22, 2018
bca2c82
Update with suggestion from moonshells PR comment re: breaking backwa…
Feb 23, 2018
cbce153
Added more unit tests for the video validation compatibility fix.
Feb 23, 2018
57b11e0
Added additional unit tests for interpret response
Feb 23, 2018
facc769
Fix for validate bids
Feb 23, 2018
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Loading