Update Rubicon Adapter support for 1.0 mediaTypes - release/0.34.5 (HB-2228) #14

idettman · 2018-02-20T15:01:55Z

IMPORTANT! Do not merge this PR, for code review only

Type of change

Other

Description of change

Adds support of 1.0 "mediaTypes" param to the Rubicon Adapter

test parameters for validating bids

{
  bidder: 'rubicon',
  bid.mediaTypes = {
    video: {
      context: "instream"
    },
  };
  params: {
    // ...
  }
}

Other information

HB-2228

…nse method changes for single response

…le request mode

… test to query string param concatenation

…e for sinon 2.0 compatibility

…ct:fix_media_type_name as reference

…ebid 1.0 http://prebid.org/dev-docs/prebid-1.0-API.html#ad-unit-changes

harpere

just a couple of pretty minor comments.

harpere · 2018-02-20T23:28:40Z

modules/rubiconBidAdapter.js

+    if (spec.hasVideoMediaType(bid)) {
+      // support instream only
+      if (utils.deepAccess(bid, `mediaTypes.${VIDEO}`) && utils.deepAccess(bid, `mediaTypes.${VIDEO}.context`) !== 'instream' ||
+        typeof params.video !== 'object' || !params.video.size_id) {


can't this be simplified to if (utils.deepAccess(bid, `mediaTypes.${VIDEO}.context`) !== 'instream' || !utils.deepAccess(params, 'video.size_id')) { ... ?

I think this may break the backwards compatibility, when we use bidRequest.mediaType === VIDEO, utils.deepAccess(bid, 'mediaTypes.${VIDEO}') && utils.deepAccess(bid, 'mediaTypes.${VIDEO}.context') !== 'instream' || typeof params.video !== 'object' || !params.video.size_id can return false but utils.deepAccess(bid, 'mediaTypes.${VIDEO}.context') !== 'instream' || !utils.deepAccess(params, 'video.size_id') will always return true

@idettman Sorry my comments is not clear, the original code utils.deepAccess(bid, 'mediaTypes.${VIDEO}') && utils.deepAccess(bid, 'mediaTypes.${VIDEO}.context') !== 'instream' || typeof params.video !== 'object' || !params.video.size_id should be the correct one.

Thanks for clarifying, I should have read more carefully. Fix committed

harpere · 2018-02-21T00:56:46Z

test/spec/modules/rubiconBidAdapter_spec.js

+
+            let serverRequests = spec.buildRequests(bidderRequest.bids, bidderRequest);
+            const foundSlotsCount = serverRequests[0].data.indexOf('&slots=10&');
+            expect(foundSlotsCount !== -1).to.equal(true);


should we also verify that the bidRequest param has only 10 requests?

…dia-type-updata # Conflicts: # modules/rubiconBidAdapter.js # test/spec/modules/rubiconBidAdapter_spec.js

…rds compatibility

Updated 'parseSizes' to fix an error found by the added tests.

harpere

LGTM

* First implementation of the AdRoll adapter (#1) * Fix request and bid id (#5) * Send Zone ID (#6) * Add age check before fastbid eval (#7) * Add age check before fastbid eval * Fix linting * Add date check (#8) * Add date exists check * Remove logging statement * Fix bidRequest validation (#9) * Fix deprecated function usage (#10) * [SENG-2757] remove custom function from adapter (#11) * remove loadExternalScript function * add adroll to the adloader whitelist * Handle nextroll id (#12) * Handle nextroll id * Remove double nesting in user obj * Revert change to publisherTagAvailable * Rename adroll -> nextroll (#14) * Rename fastbid -> pubtag functions and variables (#15) * Improve coverage of tests * Add docs * Add docs * Improve sizes and add sellerid * Add maintainer email * Fix CI problem * Fix IE tests * Replace second instance of find * Fix types used in the doc Match prebid/prebid.github.io#1796 * Remove unused fields in spec * Add ccpa support * Remove external script usage * Remove IP field * Remove pubtag key * Rename imports; Remove getUserSync function; Remove unused code; Use url.parse function Co-authored-by: Juan Bono <juanbono94@gmail.com> Co-authored-by: Ricardo Azpeitia Pimentel <ricardo.azpeitia@nextroll.com>

…ebid#9125) * Improve Digital adapter: publisher endpoint, addtl consent, syncs (#14) - add bidders to sync url when extend mode enabled - set ConsentedProvidersSettings when extend mode enabled - dynamically generated AD_SERVER_URL when publisherId available * Code refactored * Minor changes Co-authored-by: Faisal Islam <93644923+faisalvs@users.noreply.github.com> Co-authored-by: Faisal Islam <faisal.islam@vivacomsolutions.com>

* Improve Digital adapter: publisher endpoint, addtl consent, syncs (#14) - add bidders to sync url when extend mode enabled - set ConsentedProvidersSettings when extend mode enabled - dynamically generated AD_SERVER_URL when publisherId available * Code refactored * Minor changes * Fix an issue where uppercase </SCRIPT> tags broke the JS on page, as they were not properly escaped * fixed tests --------- Co-authored-by: Faisal Islam <93644923+faisalvs@users.noreply.github.com> Co-authored-by: Faisal Islam <faisal.islam@vivacomsolutions.com> Co-authored-by: Jozef Bartek <j.bartek@improvedigital.com> Co-authored-by: Jozef Bartek <31618107+jbartek25@users.noreply.github.com>

) * collect EIDs for bid request * add ad slot positioning to payload * RPO-2012: Update local storage name-spacing for c_uid (#8) * Updates c_uid namespacing to be more specific for concert * fixes unit tests * remove console.log * RPO-2012: Add check for shared id (#9) * Adds check for sharedId * Updates cookie name * remove trailing comma * [RPO-3152] Enable Support for GPP Consent (#12) * Adds gpp consent integration to concert bid adapter * Update tests to check for gpp consent string param * removes user sync endpoint and tests * updates comment * cleans up consentAllowsPpid function * comment fix * rename variables for clarity * fixes conditional logic for consent allows function (#13) * [RPO-3262] Update getUid function to check for pubcid and sharedid (#14) * Update getUid function to check for pubcid and sharedid * updates adapter version --------- Co-authored-by: antoin <antoin.campbell@voxmedia.com> Co-authored-by: Antoin <antoinfive@gmail.com>

* pageURL pull from topmostLocation * Kargo: Support for client hints (#9) * Starting SUA support * Kargo: Adding support for client hints * Adding tests for sua * Kargo: Update referer logic * Refactor of Kargo Prebid adapter. * PR comments addressed. * Feedback addressed. * Pr comments addressed. * Continuing refactor of Kargo Bid adapter. * Logic adjustment to exclude values when not present. Relying on server defaults. * Updating unit tests. * PR feedback addressed. * Refactoring bid adapter functions. * PR feedback addressed. * Additional refactoring. * Refactoring for each to use Object entries. * Minor fixes. * Minor fixes. * Minor fixes. * TDID and linting updates * Conflicts resolved with master. * Re-adding raw CRB storage (#14) * Updating shared IDs object name * Fixing missing ad markup * Removing package json changes. Fixing unit tests broken by recent changes. * Linting * send requestCount even when it is 0 for BTO (#18) * Reverting package.json change * Reverting package-lock.json changes * Cleanup * Test cleanup * Test fix Test fix All tests fixed * Adding test for TDID * Resolving merge issue --------- Co-authored-by: Neil Flynn <nflynn@kargo.com> Co-authored-by: Julian Gan <juliangan07@gmail.com>

…ebid#10356) * collect EIDs for bid request * add ad slot positioning to payload * RPO-2012: Update local storage name-spacing for c_uid (#8) * Updates c_uid namespacing to be more specific for concert * fixes unit tests * remove console.log * RPO-2012: Add check for shared id (#9) * Adds check for sharedId * Updates cookie name * remove trailing comma * [RPO-3152] Enable Support for GPP Consent (#12) * Adds gpp consent integration to concert bid adapter * Update tests to check for gpp consent string param * removes user sync endpoint and tests * updates comment * cleans up consentAllowsPpid function * comment fix * rename variables for clarity * fixes conditional logic for consent allows function (#13) * [RPO-3262] Update getUid function to check for pubcid and sharedid (#14) * Update getUid function to check for pubcid and sharedid * updates adapter version * [RPO-3405] Add browserLanguage to request meta object --------- Co-authored-by: antoin <antoin.campbell@voxmedia.com> Co-authored-by: Antoin <antoinfive@gmail.com> Co-authored-by: Brett Bloxom <38990705+BrettBlox@users.noreply.github.com>

Isaac Dettman added 30 commits February 7, 2018 10:36

in progress

b55c09c

Added single request does not group video requests

1b6e138

Does not group requests if singleRequest is not true

005f56c

Update to required params comment

ffec6ba

Update to unit test describe message

513fb0e

Commented out unnecessary test after modifications to interpret respo…

c0e190d

…nse method changes for single response

Removed commented out test

f16054b

Add interpret response test for single request mode enabled

1e12c24

Added bidderRequest to createVideoBid function signature

8b726fb

Added combineSlotUrlParams method and unit tests

b7e51dc

Separated video request from build request

7ffdac3

Added createSlotParams function and implemented in buildRequests

cb5dd24

Removed commented code and changed method signature for handling sing…

35514f7

…le request mode

Fixed argument access for interpret response

d72a1a5

Fixed obj property accessor

d271daa

Extracted function to group lists by siteId

ed46380

Removed unused function arguments

c771411

Added jsdoc for siteId grouping function

f661350

Refactored interpret response and modified param properties

7d46693

Refactored groupBidRequests to be in-lined since it was only called once

766a88a

Modified comment summary for associateBidRequest

1187a1c

Modified code for easier code merge

2d26659

Reverted digitrust function in-lining

826261a

Added missing function jsdoc

0dc32d7

Added cpm sort to fix broken unit tests

d9c70e6

Fixed linting errors

3797107

Bug fix to map converted bids before combining, added empty/undefined…

4ffa40d

… test to query string param concatenation

Added referrer and page_url changes and spec sinon sandbox.stub updat…

85ffec7

…e for sinon 2.0 compatibility

Added referrer and page_url changes

df3d331

Fixed broken unit tests

da85489

Isaac Dettman added 6 commits February 16, 2018 13:32

Updated until test description

25dd212

Added unit test for expectedQuery function

d914977

Fixed unit test for createSlotParams

595fa90

Replaced media type string values with constants from mediaTypes.js

4e50100

Updated mediaType logic using prebid/Prebid.js@master...rubicon-proje…

4a72c74

…ct:fix_media_type_name as reference

Added support for 'mediaTypes' and 'mediaType' required change for Pr…

88d0189

…ebid 1.0 http://prebid.org/dev-docs/prebid-1.0-API.html#ad-unit-changes

idettman requested a review from harpere February 20, 2018 15:01

idettman changed the title ~~Rubicon adapter media type updata~~ Update Rubicon Adapter media type (HB-2228) Feb 20, 2018

idettman changed the title ~~Update Rubicon Adapter media type (HB-2228)~~ Update Rubicon Adapter support for 1.0 "mediaTypes" (HB-2228) Feb 20, 2018

idettman changed the title ~~Update Rubicon Adapter support for 1.0 "mediaTypes" (HB-2228)~~ Update Rubicon Adapter support for 1.0 mediaTypes - release/0.34.5 (HB-2228) Feb 20, 2018

harpere requested changes Feb 21, 2018

View reviewed changes

Isaac Dettman added 8 commits February 22, 2018 08:47

Merge branch 'rubicon-adapter-single-request' into rubicon-adapter-me…

92e48e7

…dia-type-updata # Conflicts: # modules/rubiconBidAdapter.js # test/spec/modules/rubiconBidAdapter_spec.js

Updated unit test with requested changes

c590a27

Updated has video with requested change

63dbdd8

Updated with changes from SRA branch

fe69622

Update with suggestion from moonshells PR comment re: breaking backwa…

bca2c82

…rds compatibility

Added more unit tests for the video validation compatibility fix.

cbce153

Updated 'parseSizes' to fix an error found by the added tests.

Added additional unit tests for interpret response

57b11e0

Fix for validate bids

facc769

harpere approved these changes Feb 27, 2018

View reviewed changes

idettman closed this Mar 5, 2018

idettman reopened this Mar 7, 2018

snapwich closed this Jun 8, 2018

idettman deleted the rubicon-adapter-media-type-updata branch March 18, 2019 18:34

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Update Rubicon Adapter support for 1.0 mediaTypes - release/0.34.5 (HB-2228) #14

Update Rubicon Adapter support for 1.0 mediaTypes - release/0.34.5 (HB-2228) #14

idettman commented Feb 20, 2018 •

edited

Loading

harpere left a comment

harpere Feb 20, 2018

moonshells Feb 22, 2018 •

edited

Loading

moonshells Feb 23, 2018

idettman Feb 23, 2018

harpere Feb 21, 2018

harpere left a comment

Update Rubicon Adapter support for 1.0 mediaTypes - release/0.34.5 (HB-2228) #14

Update Rubicon Adapter support for 1.0 mediaTypes - release/0.34.5 (HB-2228) #14

Conversation

idettman commented Feb 20, 2018 • edited Loading

IMPORTANT! Do not merge this PR, for code review only

Type of change

Description of change

Other information

harpere left a comment

Choose a reason for hiding this comment

harpere Feb 20, 2018

Choose a reason for hiding this comment

moonshells Feb 22, 2018 • edited Loading

Choose a reason for hiding this comment

moonshells Feb 23, 2018

Choose a reason for hiding this comment

idettman Feb 23, 2018

Choose a reason for hiding this comment

harpere Feb 21, 2018

Choose a reason for hiding this comment

harpere left a comment

Choose a reason for hiding this comment

idettman commented Feb 20, 2018 •

edited

Loading

moonshells Feb 22, 2018 •

edited

Loading