fix bugs and simplify apiRubicon adapter #5
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
These updates look great. I have tested them and everything still works well. Thanks Rich! |
|
I think we should rename the file to the default 'Rubicon.js' and also update references within the file from 'apiRubicon' to 'RubiconRapid' and then we're good to go IMO. |
|
I just tried to make the suggested changes to this branch which has spawned the conflict. |
|
Apparently we need to fix keyword to be 'keywords' and support an array as input rather than a string. rather than: |
snapwich
pushed a commit
that referenced
this pull request
Mar 22, 2017
idettman
pushed a commit
that referenced
this pull request
Dec 20, 2018
* Rivr thin adapter (#5) * RVR-2049 - change impression event * RVR-2049 - fix user id value returned on creation of the cookie * RVR-2049 - remove blockedCategories and browser properties from Auction object * RVR-2060 - rewrite rendering detection for impression and click events * RVR-2060 - rewrite tests for rendering detection for impression and click events * RVR-2049 - send ad unit code in click event * RVR-2049 - adapt tests for click event * RVR-2072 - split impression detection depending on the ad server - DFP/none * RVR-2056 - set creativeId in Auction -> received bids * RVR-2056 - set bid.clearPrice to cmp * RVR-2087 - extract trackAuctionInit implementation to rivraddon * RVR-2087 - extract implementation to rivraddon WIP * RVR-2087 - extract implementation to rivraddon * RVR-2087 - extract implementation to rivraddon * RVR-2087 - Update package-lock * RVR-2087 - Add addons check * Rivr Thin Adapter - part 2 (#6) * RVR-2087 - Remove sendAuction call from ExpiringQueue * RVR-2147 - Fix test failing on IE 11.0.0 * RVR-2087 - Remove ExpiringQueue
robertrmartinez
pushed a commit
that referenced
this pull request
Feb 28, 2020
* First implementation of the AdRoll adapter (#1) * Fix request and bid id (#5) * Send Zone ID (#6) * Add age check before fastbid eval (#7) * Add age check before fastbid eval * Fix linting * Add date check (#8) * Add date exists check * Remove logging statement * Fix bidRequest validation (#9) * Fix deprecated function usage (#10) * [SENG-2757] remove custom function from adapter (#11) * remove loadExternalScript function * add adroll to the adloader whitelist * Handle nextroll id (#12) * Handle nextroll id * Remove double nesting in user obj * Revert change to publisherTagAvailable * Rename adroll -> nextroll (#14) * Rename fastbid -> pubtag functions and variables (#15) * Improve coverage of tests * Add docs * Add docs * Improve sizes and add sellerid * Add maintainer email * Fix CI problem * Fix IE tests * Replace second instance of find * Fix types used in the doc Match prebid/prebid.github.io#1796 * Remove unused fields in spec * Add ccpa support * Remove external script usage * Remove IP field * Remove pubtag key * Rename imports; Remove getUserSync function; Remove unused code; Use url.parse function Co-authored-by: Juan Bono <juanbono94@gmail.com> Co-authored-by: Ricardo Azpeitia Pimentel <ricardo.azpeitia@nextroll.com>
idettman
pushed a commit
that referenced
this pull request
Oct 22, 2020
* Add IdentityLink support and fix UnifiedId. It appears we've been looking for UnifiedId userIds on the bidderRequest object, when they are found on bidRequests. This commit fixes that error, and adds support for IdentityLink. * change maintainer email to group * TripleLift: Sending schain (#1) * Sending schain * null -> undefined * Hardcode sync endpoint protocol * Switch to EB2 sync endpoint * Add support for image based user syncing * Rename endpoint variable * Add assertion * Add CCPA query param * Simplify check for usPrivacy argument * put advertiser name in the bid.meta field if it exists * update unit tests with meta.advertiserName field * Triplelift: FPD key value pair support (#5) * Triplelift: Add support for global fpd * don't filter fpd * adds coppa support back in Co-authored-by: Will Chapin <wrchapin@gmail.com> Co-authored-by: David Andersen <davidwoodsandersen@gmail.com> Co-authored-by: Brandon Ling <bling@triplelift.com> Co-authored-by: Kevin Zhou <kzhou@triplelift.com> Co-authored-by: kzhouTL <43545828+kzhouTL@users.noreply.github.com>
robertrmartinez
pushed a commit
that referenced
this pull request
Jan 21, 2021
* Add IdentityLink support and fix UnifiedId. It appears we've been looking for UnifiedId userIds on the bidderRequest object, when they are found on bidRequests. This commit fixes that error, and adds support for IdentityLink. * change maintainer email to group * TripleLift: Sending schain (#1) * Sending schain * null -> undefined * Hardcode sync endpoint protocol * Switch to EB2 sync endpoint * Add support for image based user syncing * Rename endpoint variable * Add assertion * Add CCPA query param * Simplify check for usPrivacy argument * put advertiser name in the bid.meta field if it exists * update unit tests with meta.advertiserName field * Triplelift: FPD key value pair support (#5) * Triplelift: Add support for global fpd * don't filter fpd * adds coppa support back in * add gvlid, update validation method, add unit tests * remove advertiserDomains logic * typo * update _buildResponseObject to use new instream validation Co-authored-by: Will Chapin <wrchapin@gmail.com> Co-authored-by: colbertk <50499465+colbertk@users.noreply.github.com> Co-authored-by: David Andersen <davidwoodsandersen@gmail.com> Co-authored-by: Brandon Ling <bling@triplelift.com> Co-authored-by: colbertk <kcolbert@triplelift.com> Co-authored-by: Kevin Zhou <kzhou@triplelift.com> Co-authored-by: kzhouTL <43545828+kzhouTL@users.noreply.github.com> Co-authored-by: Sy Dao <iam.sydao@gmail.com>
robertrmartinez
pushed a commit
that referenced
this pull request
Jan 21, 2021
* Add IdentityLink support and fix UnifiedId. It appears we've been looking for UnifiedId userIds on the bidderRequest object, when they are found on bidRequests. This commit fixes that error, and adds support for IdentityLink. * change maintainer email to group * TripleLift: Sending schain (#1) * Sending schain * null -> undefined * Hardcode sync endpoint protocol * Switch to EB2 sync endpoint * Add support for image based user syncing * Rename endpoint variable * Add assertion * Add CCPA query param * Simplify check for usPrivacy argument * put advertiser name in the bid.meta field if it exists * update unit tests with meta.advertiserName field * Triplelift: FPD key value pair support (#5) * Triplelift: Add support for global fpd * don't filter fpd * adds coppa support back in * add gvlid, update validation method, add unit tests * remove advertiserDomains logic * typo * update _buildResponseObject to use new instream validation * add advertiserDomains support Co-authored-by: Will Chapin <wrchapin@gmail.com> Co-authored-by: colbertk <50499465+colbertk@users.noreply.github.com> Co-authored-by: David Andersen <davidwoodsandersen@gmail.com> Co-authored-by: colbertk <kcolbert@triplelift.com> Co-authored-by: Kevin Zhou <kzhou@triplelift.com> Co-authored-by: kzhouTL <43545828+kzhouTL@users.noreply.github.com> Co-authored-by: Sy Dao <iam.sydao@gmail.com> Co-authored-by: sdao-tl <49252703+sdao-tl@users.noreply.github.com>
robertrmartinez
pushed a commit
that referenced
this pull request
Mar 1, 2022
robertrmartinez
pushed a commit
that referenced
this pull request
Jan 9, 2023
* RTBHouse Bid Adapter: add global vendor list id * structured user agent - browsers.brands * fix lint errors * Added sda into rtbhouse adapter * spreading ortb2: user & site props * examples reverted * init version * using mergedeep * removed wrong imp array augm.; slot imp augm. with addtl check * [SUA] merging ortb2.device into request * fledge auctionConfig adapted to our bid response structure * new bidder response structure for fledge * make sure bidderRequest has proper flag turned on * fledge endpoint hardcoded; code cleanups * remove obsolete function * obsolete function removed * [RTB House] Process FLEDGE request/response (#4) * [SDA & SUA] refactor using mergedeep * [FLEDGE] fledge auctionConfig adapted to our bid response structure * [FLEDGE] new bidder response structure for fledge * [FLEDGE] make sure bidderRequest has proper flag turned on * [FLEDGE] fledge endpoint hardcoded; code cleanups * [FLEDGE] remove obsolete functions * fixed lint errors * fledge test suites; adapter: delete imp.ext.ae when no fledge (#5) Co-authored-by: Leandro Otani <leandro.otani@rtbhouse.com> Co-authored-by: rtbh-lotani <83652735+rtbh-lotani@users.noreply.github.com> Co-authored-by: Tomasz Swirski <tomasz.swirski@rtbhouse.com>
robertrmartinez
pushed a commit
that referenced
this pull request
May 22, 2023
…populate imp-level `ext.tid` (prebid#9726) * RTBHouse Bid Adapter: add global vendor list id * structured user agent - browsers.brands * fix lint errors * Added sda into rtbhouse adapter * spreading ortb2: user & site props * examples reverted * init version * using mergedeep * removed wrong imp array augm.; slot imp augm. with addtl check * [SUA] merging ortb2.device into request * fledge auctionConfig adapted to our bid response structure * new bidder response structure for fledge * make sure bidderRequest has proper flag turned on * fledge endpoint hardcoded; code cleanups * remove obsolete function * obsolete function removed * [RTB House] Process FLEDGE request/response (#4) * [SDA & SUA] refactor using mergedeep * [FLEDGE] fledge auctionConfig adapted to our bid response structure * [FLEDGE] new bidder response structure for fledge * [FLEDGE] make sure bidderRequest has proper flag turned on * [FLEDGE] fledge endpoint hardcoded; code cleanups * [FLEDGE] remove obsolete functions * fixed lint errors * fledge test suites; adapter: delete imp.ext.ae when no fledge (#5) * RTBHouse Bid Adapter: use auctionId for source.tid * RTBHouse bid adapter: fixed source.tid tests * Imp level transaction id + mapSource fix * lint: removed obsolete whitespaces * RTBHouse Bid Adapter: change `source.tid` to contain `auctionId` and populate imp-level `ext.tid` (#8) * RTBHouse Bid Adapter: use auctionId for source.tid * Imp level transaction id + mapSource fix * lint: removed obsolete whitespaces --------- Co-authored-by: Leandro Otani <leandro.otani@rtbhouse.com> Co-authored-by: rtbh-lotani <83652735+rtbh-lotani@users.noreply.github.com> Co-authored-by: Tomasz Swirski <tomasz.swirski@rtbhouse.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.