fl-1241 - integrated video bid support into rubicon adapter. Updated … #7

snapwich · 2017-01-19T15:45:20Z

Do not merge

…adapter.json with new media support.

snapwich · 2017-01-19T20:24:28Z

src/adapters/rubicon.js

+
+ let oParams = bid.params;
+
+ if(!oParams || typeof oParams.inventory !== "object") {


Currently http://prebid.org/dev-docs/bidders.html#rubicon states inventory as being an optional parameter. Is it true that it will be required for video?

Also are there any other parameters we'll need to guard as being required here?

Good catch - should have been oParams.video - need to make sure their is a video object for a video bid

snapwich · 2017-01-19T20:25:16Z

src/adapters/rubicon.js

+ let oParams = bid.params;
+
+ if(!oParams || typeof oParams.inventory !== "object") {
+ console.log("Invalid Video Bid - params not correctly defined");


We need to remove all these console.log commands.

snapwich · 2017-01-19T20:28:00Z

src/adapters/rubicon.js

+ }
+
+ let postData = {
+ page_url: utils.getTopWindowUrl(),


do we want something similar to how we handled rf below with utils.getTopWindowUrl() : pageUrl? note: pageUrl actually comes from bid.params.referrer but is renamed.

Sure - let's us pass in a test url then - makes sense

snapwich · 2017-01-19T20:37:49Z

src/adapters/rubicon.js

+ resolution: window.screen.width +'x'+ window.screen.height,
+ account_id: oParams.accountId,
+ integration: 'pbjs.lite',
+ timeout: 1000,


If it's useful, we actually determine an exact timeout in the rubiconEnterprise adapter using something like this bidderRequest.timeout - (Date.now() - bidderRequest.auctionStart - TIMEOUT_BUFFER). The buffer is just an arbitrary value of like 200 but the timeout is how long Prebid.js has designated the auction to run for and auctionStart is the time our adapter is called.

OK - sounds good.

snapwich · 2017-01-19T20:41:10Z

src/adapters/rubicon.js

+ zone_id: oParams.zoneId,
+ position: oParams.position || 'btf',
+ floor: 0.01,
+ element_id: oParams.elemId,


Can this be the bid.placementCode instead? placementCode is equivalent to the adUnit.code the bid was attached to and it looks like that's what you're using on the test page you sent me. If we use elemId we'd have to add a new requirement to http://prebid.org/dev-docs/bidders.html#rubicon

Sure - appears to be same thing.

snapwich · 2017-01-19T20:45:06Z

src/adapters/rubicon.js

+ slotData.language = oParams.video.language;
+ slotData.height = oParams.video.playerHeight;
+ slotData.width = oParams.video.playerWidth;
+ postData.ae_pass_through_parameters = oParams.video.aeParams;


This all looks fine, but we'll just have to remember to update our documentation for video about which parameters are required or optional for video in a new row here: http://prebid.org/dev-docs/bidders.html#rubicon

snapwich · 2017-01-19T20:48:03Z

src/adapters/rubicon.js

+
+ // check and add inventory, keywords, visitor and size_id data
+ if(Array.isArray(oParams.sizes) && oParams.sizes.length > 0) {
+ slotData.size_id = oParams.sizes[0];


Is it possible to use the mappings here for adUnit.sizes if bid.params.sizes does not exist? Similar for what we do below with:

// use rubicon sizes if provided, otherwise adUnit.sizes var parsedSizes = RubiconAdapter.masSizeOrdering(Array.isArray(bid.params.sizes) ? bid.params.sizes.map(size => (sizeMap[size] || '').split('x')) : bid.sizes );

although I don't know if we'd need the masSizeOrdering

video size id does not have a mapping - it is a misnomer - it actually refers to the type of video ad, i.e. pre-roll, mid-roll etc. so the value is required to execute a bid.

snapwich · 2017-01-19T20:59:48Z

src/adapters/rubicon.js

+ // video ads array is wrapped in an object
+ if (bidRequest.mediaType === 'video') {
+ if(typeof ads === 'object') {
+ ads = ads[Object.keys(ads)[0]];


Is this always going to be an Object with only one property? This code looks a little dangerous to me at first glance, but maybe it's okay.

Correct me if I'm wrong - prebid.js makes a separate request for each ad unit - in that case frank will return an object with the single ads response in it. Made a change here to grab the placement code since that is the name of the array in the ad object - I think this is more reliable :)

snapwich · 2017-01-19T21:00:35Z

src/adapters/rubicon.js

- responseObj.status !== 'ok' ||
- !Array.isArray(responseObj.ads) ||
- responseObj.ads.length < 1
- ) {


I might split out the validation of the response by type that way we can still do these checks for non-video and then video can have a different set of response validations.

I believe these checks are identical for both display and video. Only difference was grabbing the video ads response correctly from frankenstein which comes back as an objet and not an array directly because it implements SRA. If further individual validation becomes necessary in the future, we can break it out based on mediaType.

snapwich · 2017-01-19T22:05:30Z

src/adapters/rubicon.js

+ bid.height = bidRequest.params.video.playerHeight;
+ bid.vastUrl = ad.creative_depot_url;
+ bid.impression_id = ad.impression_id;
+ bid.dealId = ad.deal;


this looks like it could be outside the if/else

dealId can come outside - other ones are video specific and height and width mean different things in video.

… associated unit test

* Backport Sortable adapter to legacy (#7) * copy over sortable adapter as well as its spce test and md * fix missing utils.isPlainObject * use prebid ajax instead of fetch as fetch is not supported in IE10 (#8)

* RVR-1124 Setup initial skeleton analytics adapter that can send something. Approved-by: Alessandro Di Giovanni <alessandro.digiovanni@gamegenetics.de> * Formatted auction/events data to fit needed schema. * RVR-1135 fetched device data. * Applied feedback. * Applied feedback. * Fetched core. * Added click handler for reporting banners click events. * Applied analyzer for reporting displayed impressions. * Applied feedback. * Merged in RVR-1214-invoke-handlers-on-rendering (pull request #7) RVR-1214 Invoke handlers on rendering * RVR-1214 Invoked handlers right after ad is displayed. * Applied feedback. Approved-by: Alessandro Di Giovanni <alessandro.digiovanni@gamegenetics.de> * Merged in RVR-1192-configuration-global-parameters (pull request #8) RVR-1192 Configuration/Global parameters Approved-by: Alessandro Di Giovanni <alessandro.digiovanni@gamegenetics.de> * Merged in RVR-1181-Prebid-js-unit-tests-setup (pull request #6) RVR-1181 Prebid.js Unit tests setup Approved-by: Alessandro Di Giovanni <alessandro.digiovanni@gamegenetics.de> * Merged in RVR-1247-additional-data-to-impression-records (pull request #9) RVR-1247 Additional data to impression records Approved-by: Alessandro Di Giovanni <alessandro.digiovanni@gamegenetics.de> * Merged in RVR-1249-add-requestedbids-to-auction (pull request #10) RVR-1249 Add requested bids to auction object request. Approved-by: Alessandro Di Giovanni <alessandro.digiovanni@gamegenetics.de> * Merged in RVR-1261-fix-tests (pull request #11) RVR-1261 fix tests * RVR-1261 Secured adapter from no containers configuration. And changed fetching URL. * RVR-1261 Added event check for request and changed some names. * Applied feedback. Approved-by: Alessandro Di Giovanni <alessandro.digiovanni@gamegenetics.de> * RVR-1352 analytics adapter bugs Approved-by: Alessandro Di Giovanni <alessandro.digiovanni@gamegenetics.de> * Fixed bug with geolocation notification. * fixed missing bracket. * one more fix. * RVR-1357 Different optimisation responses & tracking into auction event * RVR-1852 - Add content type and hardcoded auth headers (cherry picked from commit 4def881) * RVR-1852 - Change tracker host * RVR-1852 - Override content type instead of adding header * RVR-1914 Consistent data types in events Also removes undefined and null properties in audience events * Merged in RVR-1883-Add-Basic-Access-Authentication (pull request #17) RVR-1883 Add Basic Access Authentication * RVR-1914 - Rename functions * RVR-1914 - Set default total_duration to null in bid response * RVR-1883 - Use RIVR_CLIENT_AUTH_TOKEN global variable for Auth token * RVR-1883 - Restore stub after every test not just at the end * RVR-1883 - Remove commented code * Increase code coverage * Fix for IE 11.0.0 and Safari 8.0.8 - includes() Use core-js includes function for array * Restore pbjs_api_spec.js * Fix API calls for rivr analytics impressions and clicks * Rvr 2005 rvr analytics adapter (#4) * Submitting EMX Digital Adapter (prebid#3173) * Submitting EMX Digital Prebid Adapter Submitting EMX Digital Prebid Adapter code * fixing lint errors. updating our md * updating to const/let variables. adding test spec. * fixed linting on test spec js * TheMediaGrid Bid Adapter (prebid#3204) * Added Grid Bid Adapter * remove priceType from TheMediaGrid Bid Adapter * Adding user sync method for IFRAME and Pixel (prebid#3232) * Submitting EMX Digital Prebid Adapter Submitting EMX Digital Prebid Adapter code * fixing lint errors. updating our md * updating to const/let variables. adding test spec. * fixed linting on test spec js * adding emx usersync methods * updates (prebid#3162) * Only set native targeting if value exists. (prebid#3225) * add nolint command line option, similar to notest (prebid#3234) * add inskin iab vendor id: enables consent via string (prebid#3235) * Added user sync support for undertone bid adapter (prebid#3172) * Added user sync support for undertone bid adapter (new pull request) * Added user sync support for undertone bid adapter * fix indentation * Changed utils.getWindowTop() with the newer prebid utilities * Updating Auction Init Pick for timestamp + Test update (prebid#3223) * Updating Auction Init Pick for timestamp + Test update * Updating Auction Init to include once again + Rubicon Analytics update accordingly * Removing from auction init events in favor of old * Add code, test, and doc for Adikteev adapter (prebid#3229) * Add code, test, and doc for Adikteev adapter * Reflect comments on other PR http://prebid.org/dev-docs/bidder-adaptor.html#referrers prebid#3230 (comment) * 'currency' isn't a bidder-specific param Update PR following this remark on another one: prebid#3228 (comment) * Add integration example, fix bid requestId * Quantcast adapter onTimeout (prebid#3239) * onTimeout WIP * test for onTimeout * some renaming * cleanup * cleanup * trying to fix the test * using ajax instead of fetch * Test cleanup (prebid#3238) * stub pixel call in justpremium tests * properly stub geolocation services to prevent prompts * stub img creation as well to prevent call in justpremium * Appnexus adapter: Added dealPriority and dealCode to bidResponse (prebid#3201) * Added dealPriority and dealCode to appnexus adapter * update failed test * added namespace and did deep merge * keep all properties together * use unit id being sent instead of hard coded auid (prebid#3236) * use unit id being sent instead of hard coded auid * make multiple requests * removes commented out code. adds aus param back * Prebid 1.30.0 Release * increment pre version * fix deal targeting for cpm 0 (prebid#3233) * YIELDONE adapter - support Video (prebid#3227) * added UserSync * added UserSync Unit Test * support for multi sizes * register the adapter as supporting video * supporting video * change requestId acquisition method * fix the parameter name of dealID * update test parameters * support instream video * add test for bidRequest * add test for interpretResponse * add test params * add note to documentaion * clarifying the multi-format support message * rtbhouseBidAdapter changes (prebid#3241) * Add transactionId support * Change site getting method * Add bidfloor param * correct user agent value population (prebid#3248) * RVR-1124 Setup initial skeleton analytics adapter that can send something. Approved-by: Alessandro Di Giovanni <alessandro.digiovanni@gamegenetics.de> * Formatted auction/events data to fit needed schema. * RVR-1135 fetched device data. * Applied feedback. * Applied feedback. * Fetched core. * Added click handler for reporting banners click events. * Applied analyzer for reporting displayed impressions. * Applied feedback. * Merged in RVR-1214-invoke-handlers-on-rendering (pull request #7) RVR-1214 Invoke handlers on rendering * RVR-1214 Invoked handlers right after ad is displayed. * Applied feedback. Approved-by: Alessandro Di Giovanni <alessandro.digiovanni@gamegenetics.de> * Merged in RVR-1192-configuration-global-parameters (pull request #8) RVR-1192 Configuration/Global parameters Approved-by: Alessandro Di Giovanni <alessandro.digiovanni@gamegenetics.de> * Merged in RVR-1181-Prebid-js-unit-tests-setup (pull request #6) RVR-1181 Prebid.js Unit tests setup Approved-by: Alessandro Di Giovanni <alessandro.digiovanni@gamegenetics.de> * Merged in RVR-1247-additional-data-to-impression-records (pull request #9) RVR-1247 Additional data to impression records Approved-by: Alessandro Di Giovanni <alessandro.digiovanni@gamegenetics.de> * Merged in RVR-1249-add-requestedbids-to-auction (pull request #10) RVR-1249 Add requested bids to auction object request. Approved-by: Alessandro Di Giovanni <alessandro.digiovanni@gamegenetics.de> * Merged in RVR-1261-fix-tests (pull request #11) RVR-1261 fix tests * RVR-1261 Secured adapter from no containers configuration. And changed fetching URL. * RVR-1261 Added event check for request and changed some names. * Applied feedback. Approved-by: Alessandro Di Giovanni <alessandro.digiovanni@gamegenetics.de> * RVR-1352 analytics adapter bugs Approved-by: Alessandro Di Giovanni <alessandro.digiovanni@gamegenetics.de> * Fixed bug with geolocation notification. * fixed missing bracket. * one more fix. * RVR-1357 Different optimisation responses & tracking into auction event * RVR-1852 - Add content type and hardcoded auth headers (cherry picked from commit 4def881) * RVR-1852 - Change tracker host * RVR-1852 - Override content type instead of adding header * RVR-1914 Consistent data types in events Also removes undefined and null properties in audience events * Merged in RVR-1883-Add-Basic-Access-Authentication (pull request #17) RVR-1883 Add Basic Access Authentication * RVR-1914 - Rename functions * RVR-1914 - Set default total_duration to null in bid response * RVR-1883 - Use RIVR_CLIENT_AUTH_TOKEN global variable for Auth token * RVR-1883 - Restore stub after every test not just at the end * RVR-1883 - Remove commented code * Increase code coverage * Fix for IE 11.0.0 and Safari 8.0.8 - includes() Use core-js includes function for array * Restore pbjs_api_spec.js * Fix API calls for rivr analytics impressions and clicks * RVR-2005 - Change auction object model * RVR-2005 - Set rvr_usr_id cookie * RVR-2005 - Remove BID_REQUESTED and BID_RESPONSE handlers We have the same infos all collected in AUCTION_END * RVR-2005 - build Bidders Array From Auction End * RVR-2005 - build impressions Array From Auction End * RVR-2005 - set status of winning bid * RVR-2005 - cleanup * RVR-2005 - adapt enableAnalytics() test * RVR-2005 - adapt all tests * RVR-2005 - Add Rivr Analytics adapter md file * RVR-2005 - rewrite connectAllUnits * RVR-2005 - correct typo * RVR-2005 - use IE compatible find()

* First implementation of the AdRoll adapter (#1) * Fix request and bid id (#5) * Send Zone ID (#6) * Add age check before fastbid eval (#7) * Add age check before fastbid eval * Fix linting * Add date check (#8) * Add date exists check * Remove logging statement * Fix bidRequest validation (#9) * Fix deprecated function usage (#10) * [SENG-2757] remove custom function from adapter (#11) * remove loadExternalScript function * add adroll to the adloader whitelist * Handle nextroll id (#12) * Handle nextroll id * Remove double nesting in user obj * Revert change to publisherTagAvailable * Rename adroll -> nextroll (#14) * Rename fastbid -> pubtag functions and variables (#15) * Improve coverage of tests * Add docs * Add docs * Improve sizes and add sellerid * Add maintainer email * Fix CI problem * Fix IE tests * Replace second instance of find * Fix types used in the doc Match prebid/prebid.github.io#1796 * Remove unused fields in spec * Add ccpa support * Remove external script usage * Remove IP field * Remove pubtag key * Rename imports; Remove getUserSync function; Remove unused code; Use url.parse function Co-authored-by: Juan Bono <juanbono94@gmail.com> Co-authored-by: Ricardo Azpeitia Pimentel <ricardo.azpeitia@nextroll.com>

* updates for first cut at bidder * fix up height and width * adds test spec * remove hello_world from commit' * updates to support native and fix issues found in initial review * fix handling of new node in response for native vs banner * updates to handle OpenRTB base * updates to support RTB style calls * updates to get back to parity * updates to testing * updates to test media type handling * updates to handling testing * updates to testing * remove report file * updates to fix up unit/spec tests * updates to fix up unit/spec tests * updates to fix up unit/spec tests * updates to handling of gdpr * Delete hello_world.html * remove hellow-world-sample * Pubwise 481 (#7) * updates to support PubWise bid adapter, test cases and documentation * updates to fix param tes * Pubwise 481 (#8) * fixes for unit testing * remove unused variables and params * Updates to Remove Unused Vars (#9) * remove unused vars * updates to fix up used and unsused params * updates to fix up used and unsused params (#10) * updates to fix up used and unsused params * updates to remove usersync and add gvlid * Pubwise 481 (#11) * updates to remove usersync, add https, and add gvlid * Update pubwiseBidAdapter.js * updates to remove json, to remove options hit

* feature: add Hubvisor richmedia adapter * feature(hubvisor-bid-adapter): fix lint error * feature: Replay support for Hubvisor richmedia adapter * feature: do not need size 1800x1000 for skin * feature: rename hbvRichmediaAdapter to bigRichmediaAdapter (#7) * feature: add tests and documentation (#8) * Richmedia adapter : rename files (#9) Co-authored-by: Julie <julie@hubvisor.io> Co-authored-by: JulieLorin <juli.lorin+github@gmail.com>

* [DSP-3689] feature: add pubProvidedId to user (#6) [DSP-3689] feature: add pubProvidedId to user * [DSP-3690] feature: Handle schain object (#7)

fl-1241 - integrated video bid support into rubicon adapter. Updated …

23045c1

…adapter.json with new media support.

snapwich commented Jan 19, 2017

View reviewed changes

David Bridges and others added 6 commits January 19, 2017 16:32

fl-1241 - Updates based on pull request comments

2169d04

added a few stylistic and consolidation changes to rubicon adapter

199b690

allow rubicon adapter to get video size from adunit and fix timeout

378e4a6

add unit tests for rubicon video

ac0af12

fl-1241 - Fixed bug in how size_id was added to slot object - updated…

ca856c9

… associated unit test

fl-1241 -Rolled back size_id fix and test update

3760312

snapwich closed this Jan 24, 2017

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

fl-1241 - integrated video bid support into rubicon adapter. Updated … #7

fl-1241 - integrated video bid support into rubicon adapter. Updated … #7

snapwich commented Jan 19, 2017

snapwich Jan 19, 2017 •

edited

Loading

dbridges12 Jan 19, 2017

snapwich Jan 19, 2017

dbridges12 Jan 19, 2017

snapwich Jan 19, 2017

dbridges12 Jan 19, 2017

snapwich Jan 19, 2017

dbridges12 Jan 20, 2017

snapwich Jan 19, 2017

dbridges12 Jan 19, 2017

snapwich Jan 19, 2017

snapwich Jan 19, 2017 •

edited

Loading

dbridges12 Jan 19, 2017

snapwich Jan 19, 2017

dbridges12 Jan 20, 2017

snapwich Jan 19, 2017

dbridges12 Jan 19, 2017

snapwich Jan 19, 2017

dbridges12 Jan 20, 2017


		let oParams = bid.params;

		if(!oParams \|\| typeof oParams.inventory !== "object") {

fl-1241 - integrated video bid support into rubicon adapter. Updated … #7

fl-1241 - integrated video bid support into rubicon adapter. Updated … #7

Conversation

snapwich commented Jan 19, 2017

snapwich Jan 19, 2017 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

snapwich Jan 19, 2017 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

snapwich Jan 19, 2017 •

edited

Loading

snapwich Jan 19, 2017 •

edited

Loading