fix(mixpanel): batch event ordering #2608

Gauravudia · 2023-09-13T14:36:31Z

Description of the change

Resolves INT-390
Fix mixpanel batch even ordering and move utility functions to utils.js

Type of change

Bug fix (non-breaking change that fixes an issue)
New feature (non-breaking change that adds functionality)
Breaking change (fix or feature that would cause existing functionality to not work as expected)

Related issues

Fix #1

Checklists

Development

Lint rules pass locally
The code changed/added as part of this pull request has been covered with tests
All tests related to the changed code pass in development

Code review

This pull request has a descriptive title and information useful to a reviewer. There may be a screenshot or screencast attached
"Ready for review" label attached to the PR and reviewers mentioned in a comment
Changes have been reviewed by at least one other engineer
Issue from task tracker has a link to this pull request

src/v0/destinations/mp/util.js

src/v0/destinations/mp/transform.js

src/v0/destinations/mp/util.js

codecov · 2023-09-18T15:42:09Z

Codecov Report

Patch coverage: 98.63% and no project coverage change.

Comparison is base (fd81211) 86.89% compared to head (1035264) 86.89%.
Report is 1 commits behind head on develop.

Additional details and impacted files

@@           Coverage Diff            @@
##           develop    #2608   +/-   ##
========================================
  Coverage    86.89%   86.89%           
========================================
  Files          603      603           
  Lines        28140    28129   -11     
  Branches      6697     6693    -4     
========================================
- Hits         24451    24442    -9     
+ Misses        3356     3354    -2     
  Partials       333      333

Files Changed	Coverage Δ
src/v0/destinations/iterable/transform.js	`95.41% <ø> (ø)`
src/v0/destinations/iterable/util.js	`94.02% <ø> (-0.45%)`	⬇️
src/v0/destinations/mp/transform.js	`98.23% <96.00%> (+0.86%)`	⬆️
src/v0/destinations/mp/util.js	`99.18% <100.00%> (-0.82%)`	⬇️
src/v0/util/index.js	`87.19% <100.00%> (+0.31%)`	⬆️

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

sonarqubecloud · 2023-09-18T15:45:22Z

Kudos, SonarCloud Quality Gate passed!

0 Bugs
0 Vulnerabilities
0 Security Hotspots
1 Code Smell

95.1% Coverage
0.0% Duplication

* fix(mixpanel): batch event ordering (#2608) * fix: bqstream event ordering fix (#2624) * fix: bqstream event ordering fix * fix: review comments addressed * fix: importing the common util function * fix: putting both error and successful events logic back * fix: test cases addition and code clean up * fix: code clean up * fix: resolving sonar error * fix: removing network handler for bqstream * fix: refactor process router dest * fix: use promise for prompts in personalize create tracking script (#2635) * fix(snyk): snyk updated versions merged to oen pr * chore: add ttl values for cache (#2593) * fix(hubspot): add validation for hubspotEvents (#2643) * fix: add optional chaining for error message in network handler of Intercom (#2648) fix bugsnag issue * fix(snyk): removed the new added dependencies * fix(snyk): removed aws-sdk dependency * feat: add circular reference check in flattern json (#2650) * chore: update fb_error message for invalid type of property value (#2656) fix: fb_error message for invalid type of property value * feat(iterable): user deletion support (#2621) * feat(iterable): user deletion support * feat(iterable): user deletion improvements * chore: added comments * feat(gaec): partial failures handling (#2631) * chore: partial failure handling * chore: code review changes * chore: move unit tests to correct place for mssql and postgres (#2657) * chore: move unit tests to correct place for mssql and postgres * chore: replace var to const * chore: replace var to const * feat: add axios mocking to component test-suite (#2638) * feat: tslint rules enable (#2604) * feat: remove eslint issues * fix: fixed es-lint tests * fix: merge conflicts * fix: add auth status inactive category handling to GA in userDeletion flow (#2669) * fix: refactor adjust using optional chaining (#2671) fix: refactor adj using opitonal chaining * chore(release): pull main into develop post release v1.43.1 (#2662) * fix(dm): updated the stats definition for the tracking plan service * fix(iterable): event id mapping (#2659) * chore(release): 1.43.1 * chore: update release owners (#2661) chore: update release stakeholder --------- Co-authored-by: Abhimanyu Babbar <abhimanyu.babbar89@gmail.com> Co-authored-by: Mihir Bhalala <77438541+mihir-4116@users.noreply.github.com> Co-authored-by: GitHub Actions <noreply@github.com> Co-authored-by: Anant Jain <62471433+anantjain45823@users.noreply.github.com> Co-authored-by: Sudip Paul <67197965+ItsSudip@users.noreply.github.com> * chore(release): 1.44.0 * feat(ga4): added support of filter user traits (#2679) * fix: add optional chaining for traits (#2677) * fix: add optional chaing for traits * update changelog * feat: geolocation support for python transformations (#2678) * feat: geolocation support for python transformations * chore: updating changelog --------- Co-authored-by: Anant Jain <62471433+anantjain45823@users.noreply.github.com> * update changelog * Update CHANGELOG.md --------- Co-authored-by: Gauravudia <60897972+Gauravudia@users.noreply.github.com> Co-authored-by: shrouti1507 <60211312+shrouti1507@users.noreply.github.com> Co-authored-by: Dilip Kola <33080863+koladilip@users.noreply.github.com> Co-authored-by: Sudip Paul <67197965+ItsSudip@users.noreply.github.com> Co-authored-by: Sanjay <71065320+Sanjay-Veernala@users.noreply.github.com> Co-authored-by: Siva Shanmukh Vetcha <siva.shanmukh@gmail.com> Co-authored-by: Ujjwal Abhishek <63387036+ujjwal-ab@users.noreply.github.com> Co-authored-by: Mihir Bhalala <77438541+mihir-4116@users.noreply.github.com> Co-authored-by: Sankeerth <sankeerth@rudderstack.com> Co-authored-by: AASHISH MALIK <imashishmalik.45@gmail.com> Co-authored-by: Anant Jain <62471433+anantjain45823@users.noreply.github.com> Co-authored-by: Abhimanyu Babbar <abhimanyu.babbar89@gmail.com> Co-authored-by: GitHub Actions <noreply@github.com> Co-authored-by: Jayachand <mjayachand@gmail.com> Co-authored-by: Anant Jain <anantjain45823@gmail.com>

* fix(dm): updated the stats definition for the tracking plan service * fix(iterable): event id mapping (#2659) * chore(release): 1.43.1 * chore: update release owners (#2661) chore: update release stakeholder * chore(release): pull release/v1.44.0 into main (#2672) * fix(mixpanel): batch event ordering (#2608) * fix: bqstream event ordering fix (#2624) * fix: bqstream event ordering fix * fix: review comments addressed * fix: importing the common util function * fix: putting both error and successful events logic back * fix: test cases addition and code clean up * fix: code clean up * fix: resolving sonar error * fix: removing network handler for bqstream * fix: refactor process router dest * fix: use promise for prompts in personalize create tracking script (#2635) * fix(snyk): snyk updated versions merged to oen pr * chore: add ttl values for cache (#2593) * fix(hubspot): add validation for hubspotEvents (#2643) * fix: add optional chaining for error message in network handler of Intercom (#2648) fix bugsnag issue * fix(snyk): removed the new added dependencies * fix(snyk): removed aws-sdk dependency * feat: add circular reference check in flattern json (#2650) * chore: update fb_error message for invalid type of property value (#2656) fix: fb_error message for invalid type of property value * feat(iterable): user deletion support (#2621) * feat(iterable): user deletion support * feat(iterable): user deletion improvements * chore: added comments * feat(gaec): partial failures handling (#2631) * chore: partial failure handling * chore: code review changes * chore: move unit tests to correct place for mssql and postgres (#2657) * chore: move unit tests to correct place for mssql and postgres * chore: replace var to const * chore: replace var to const * feat: add axios mocking to component test-suite (#2638) * feat: tslint rules enable (#2604) * feat: remove eslint issues * fix: fixed es-lint tests * fix: merge conflicts * fix: add auth status inactive category handling to GA in userDeletion flow (#2669) * fix: refactor adjust using optional chaining (#2671) fix: refactor adj using opitonal chaining * chore(release): pull main into develop post release v1.43.1 (#2662) * fix(dm): updated the stats definition for the tracking plan service * fix(iterable): event id mapping (#2659) * chore(release): 1.43.1 * chore: update release owners (#2661) chore: update release stakeholder --------- Co-authored-by: Abhimanyu Babbar <abhimanyu.babbar89@gmail.com> Co-authored-by: Mihir Bhalala <77438541+mihir-4116@users.noreply.github.com> Co-authored-by: GitHub Actions <noreply@github.com> Co-authored-by: Anant Jain <62471433+anantjain45823@users.noreply.github.com> Co-authored-by: Sudip Paul <67197965+ItsSudip@users.noreply.github.com> * chore(release): 1.44.0 * feat(ga4): added support of filter user traits (#2679) * fix: add optional chaining for traits (#2677) * fix: add optional chaing for traits * update changelog * feat: geolocation support for python transformations (#2678) * feat: geolocation support for python transformations * chore: updating changelog --------- Co-authored-by: Anant Jain <62471433+anantjain45823@users.noreply.github.com> * update changelog * Update CHANGELOG.md --------- Co-authored-by: Gauravudia <60897972+Gauravudia@users.noreply.github.com> Co-authored-by: shrouti1507 <60211312+shrouti1507@users.noreply.github.com> Co-authored-by: Dilip Kola <33080863+koladilip@users.noreply.github.com> Co-authored-by: Sudip Paul <67197965+ItsSudip@users.noreply.github.com> Co-authored-by: Sanjay <71065320+Sanjay-Veernala@users.noreply.github.com> Co-authored-by: Siva Shanmukh Vetcha <siva.shanmukh@gmail.com> Co-authored-by: Ujjwal Abhishek <63387036+ujjwal-ab@users.noreply.github.com> Co-authored-by: Mihir Bhalala <77438541+mihir-4116@users.noreply.github.com> Co-authored-by: Sankeerth <sankeerth@rudderstack.com> Co-authored-by: AASHISH MALIK <imashishmalik.45@gmail.com> Co-authored-by: Anant Jain <62471433+anantjain45823@users.noreply.github.com> Co-authored-by: Abhimanyu Babbar <abhimanyu.babbar89@gmail.com> Co-authored-by: GitHub Actions <noreply@github.com> Co-authored-by: Jayachand <mjayachand@gmail.com> Co-authored-by: Anant Jain <anantjain45823@gmail.com> --------- Co-authored-by: Abhimanyu Babbar <abhimanyu.babbar89@gmail.com> Co-authored-by: Mihir Bhalala <77438541+mihir-4116@users.noreply.github.com> Co-authored-by: GitHub Actions <noreply@github.com> Co-authored-by: Sudip Paul <67197965+ItsSudip@users.noreply.github.com> Co-authored-by: devops-github-rudderstack <88187154+devops-github-rudderstack@users.noreply.github.com> Co-authored-by: Gauravudia <60897972+Gauravudia@users.noreply.github.com> Co-authored-by: shrouti1507 <60211312+shrouti1507@users.noreply.github.com> Co-authored-by: Dilip Kola <33080863+koladilip@users.noreply.github.com> Co-authored-by: Sanjay <71065320+Sanjay-Veernala@users.noreply.github.com> Co-authored-by: Siva Shanmukh Vetcha <siva.shanmukh@gmail.com> Co-authored-by: Ujjwal Abhishek <63387036+ujjwal-ab@users.noreply.github.com> Co-authored-by: Sankeerth <sankeerth@rudderstack.com> Co-authored-by: AASHISH MALIK <imashishmalik.45@gmail.com> Co-authored-by: Jayachand <mjayachand@gmail.com>

Gauravudia added 2 commits September 13, 2023 17:36

fix: mixpanel event ordering

5556373

chore: update testcase

d184cd7

Gauravudia requested review from chandumlg and mihir-4116 September 13, 2023 14:36

Gauravudia self-assigned this Sep 13, 2023

Gauravudia requested review from a team as code owners September 13, 2023 14:36

Gauravudia requested a review from shrouti1507 September 13, 2023 14:36

Gauravudia added the enhancement New feature or request label Sep 13, 2023

Merge branch 'develop' into fix/mixpanel-ordering

6b7b2a0

Gauravudia removed the request for review from shrouti1507 September 13, 2023 14:37

chandumlg reviewed Sep 18, 2023

View reviewed changes

src/v0/destinations/mp/util.js Outdated Show resolved Hide resolved

chandumlg reviewed Sep 18, 2023

View reviewed changes

src/v0/destinations/mp/transform.js Show resolved Hide resolved

chandumlg reviewed Sep 18, 2023

View reviewed changes

src/v0/destinations/mp/util.js Show resolved Hide resolved

Gauravudia and others added 6 commits September 18, 2023 13:09

refactor: replace switch case with find

b2ec653

refactor: moved groupEventsByType to common utils

470973e

Merge branch 'develop' into fix/mixpanel-ordering

d8a4ace

chore: resolve merge conflicts

1c61936

test: add testcases

2e923ff

test: add testcases

1035264

chandumlg approved these changes Sep 18, 2023

View reviewed changes

shrouti1507 approved these changes Sep 18, 2023

View reviewed changes

chandumlg merged commit 36c7f06 into develop Sep 18, 2023

chandumlg deleted the fix/mixpanel-ordering branch September 18, 2023 15:53

Sanjay-Veernala pushed a commit that referenced this pull request Sep 20, 2023

fix(mixpanel): batch event ordering (#2608)

3a79023

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

fix(mixpanel): batch event ordering #2608

fix(mixpanel): batch event ordering #2608

Gauravudia commented Sep 13, 2023 •

edited

Loading

codecov bot commented Sep 18, 2023 •

edited

Loading

sonarqubecloud bot commented Sep 18, 2023

fix(mixpanel): batch event ordering #2608

fix(mixpanel): batch event ordering #2608

Conversation

Gauravudia commented Sep 13, 2023 • edited Loading

Description of the change

Type of change

Related issues

Checklists

Development

Code review

codecov bot commented Sep 18, 2023 • edited Loading

Codecov Report

sonarqubecloud bot commented Sep 18, 2023

Gauravudia commented Sep 13, 2023 •

edited

Loading

codecov bot commented Sep 18, 2023 •

edited

Loading