fix: use promise for prompts in personalize create tracking script #2635
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportPatch and project coverage have no change.
Additional details and impacted files@@ Coverage Diff @@
## develop #2635 +/- ##
========================================
Coverage 86.92% 86.92%
========================================
Files 604 604
Lines 28170 28170
Branches 6700 6700
========================================
Hits 24487 24487
Misses 3350 3350
Partials 333 333 ☔ View full report in Codecov by Sentry. |
|
Kudos, SonarCloud Quality Gate passed! |
krishna2020
approved these changes
Sep 20, 2023
Sanjay-Veernala
approved these changes
Sep 20, 2023
anantjain45823
added a commit
that referenced
this pull request
Oct 3, 2023
* fix(mixpanel): batch event ordering (#2608) * fix: bqstream event ordering fix (#2624) * fix: bqstream event ordering fix * fix: review comments addressed * fix: importing the common util function * fix: putting both error and successful events logic back * fix: test cases addition and code clean up * fix: code clean up * fix: resolving sonar error * fix: removing network handler for bqstream * fix: refactor process router dest * fix: use promise for prompts in personalize create tracking script (#2635) * fix(snyk): snyk updated versions merged to oen pr * chore: add ttl values for cache (#2593) * fix(hubspot): add validation for hubspotEvents (#2643) * fix: add optional chaining for error message in network handler of Intercom (#2648) fix bugsnag issue * fix(snyk): removed the new added dependencies * fix(snyk): removed aws-sdk dependency * feat: add circular reference check in flattern json (#2650) * chore: update fb_error message for invalid type of property value (#2656) fix: fb_error message for invalid type of property value * feat(iterable): user deletion support (#2621) * feat(iterable): user deletion support * feat(iterable): user deletion improvements * chore: added comments * feat(gaec): partial failures handling (#2631) * chore: partial failure handling * chore: code review changes * chore: move unit tests to correct place for mssql and postgres (#2657) * chore: move unit tests to correct place for mssql and postgres * chore: replace var to const * chore: replace var to const * feat: add axios mocking to component test-suite (#2638) * feat: tslint rules enable (#2604) * feat: remove eslint issues * fix: fixed es-lint tests * fix: merge conflicts * fix: add auth status inactive category handling to GA in userDeletion flow (#2669) * fix: refactor adjust using optional chaining (#2671) fix: refactor adj using opitonal chaining * chore(release): pull main into develop post release v1.43.1 (#2662) * fix(dm): updated the stats definition for the tracking plan service * fix(iterable): event id mapping (#2659) * chore(release): 1.43.1 * chore: update release owners (#2661) chore: update release stakeholder --------- Co-authored-by: Abhimanyu Babbar <abhimanyu.babbar89@gmail.com> Co-authored-by: Mihir Bhalala <77438541+mihir-4116@users.noreply.github.com> Co-authored-by: GitHub Actions <noreply@github.com> Co-authored-by: Anant Jain <62471433+anantjain45823@users.noreply.github.com> Co-authored-by: Sudip Paul <67197965+ItsSudip@users.noreply.github.com> * chore(release): 1.44.0 * feat(ga4): added support of filter user traits (#2679) * fix: add optional chaining for traits (#2677) * fix: add optional chaing for traits * update changelog * feat: geolocation support for python transformations (#2678) * feat: geolocation support for python transformations * chore: updating changelog --------- Co-authored-by: Anant Jain <62471433+anantjain45823@users.noreply.github.com> * update changelog * Update CHANGELOG.md --------- Co-authored-by: Gauravudia <60897972+Gauravudia@users.noreply.github.com> Co-authored-by: shrouti1507 <60211312+shrouti1507@users.noreply.github.com> Co-authored-by: Dilip Kola <33080863+koladilip@users.noreply.github.com> Co-authored-by: Sudip Paul <67197965+ItsSudip@users.noreply.github.com> Co-authored-by: Sanjay <71065320+Sanjay-Veernala@users.noreply.github.com> Co-authored-by: Siva Shanmukh Vetcha <siva.shanmukh@gmail.com> Co-authored-by: Ujjwal Abhishek <63387036+ujjwal-ab@users.noreply.github.com> Co-authored-by: Mihir Bhalala <77438541+mihir-4116@users.noreply.github.com> Co-authored-by: Sankeerth <sankeerth@rudderstack.com> Co-authored-by: AASHISH MALIK <imashishmalik.45@gmail.com> Co-authored-by: Anant Jain <62471433+anantjain45823@users.noreply.github.com> Co-authored-by: Abhimanyu Babbar <abhimanyu.babbar89@gmail.com> Co-authored-by: GitHub Actions <noreply@github.com> Co-authored-by: Jayachand <mjayachand@gmail.com> Co-authored-by: Anant Jain <anantjain45823@gmail.com>
anantjain45823
added a commit
that referenced
this pull request
Oct 5, 2023
* fix(dm): updated the stats definition for the tracking plan service * fix(iterable): event id mapping (#2659) * chore(release): 1.43.1 * chore: update release owners (#2661) chore: update release stakeholder * chore(release): pull release/v1.44.0 into main (#2672) * fix(mixpanel): batch event ordering (#2608) * fix: bqstream event ordering fix (#2624) * fix: bqstream event ordering fix * fix: review comments addressed * fix: importing the common util function * fix: putting both error and successful events logic back * fix: test cases addition and code clean up * fix: code clean up * fix: resolving sonar error * fix: removing network handler for bqstream * fix: refactor process router dest * fix: use promise for prompts in personalize create tracking script (#2635) * fix(snyk): snyk updated versions merged to oen pr * chore: add ttl values for cache (#2593) * fix(hubspot): add validation for hubspotEvents (#2643) * fix: add optional chaining for error message in network handler of Intercom (#2648) fix bugsnag issue * fix(snyk): removed the new added dependencies * fix(snyk): removed aws-sdk dependency * feat: add circular reference check in flattern json (#2650) * chore: update fb_error message for invalid type of property value (#2656) fix: fb_error message for invalid type of property value * feat(iterable): user deletion support (#2621) * feat(iterable): user deletion support * feat(iterable): user deletion improvements * chore: added comments * feat(gaec): partial failures handling (#2631) * chore: partial failure handling * chore: code review changes * chore: move unit tests to correct place for mssql and postgres (#2657) * chore: move unit tests to correct place for mssql and postgres * chore: replace var to const * chore: replace var to const * feat: add axios mocking to component test-suite (#2638) * feat: tslint rules enable (#2604) * feat: remove eslint issues * fix: fixed es-lint tests * fix: merge conflicts * fix: add auth status inactive category handling to GA in userDeletion flow (#2669) * fix: refactor adjust using optional chaining (#2671) fix: refactor adj using opitonal chaining * chore(release): pull main into develop post release v1.43.1 (#2662) * fix(dm): updated the stats definition for the tracking plan service * fix(iterable): event id mapping (#2659) * chore(release): 1.43.1 * chore: update release owners (#2661) chore: update release stakeholder --------- Co-authored-by: Abhimanyu Babbar <abhimanyu.babbar89@gmail.com> Co-authored-by: Mihir Bhalala <77438541+mihir-4116@users.noreply.github.com> Co-authored-by: GitHub Actions <noreply@github.com> Co-authored-by: Anant Jain <62471433+anantjain45823@users.noreply.github.com> Co-authored-by: Sudip Paul <67197965+ItsSudip@users.noreply.github.com> * chore(release): 1.44.0 * feat(ga4): added support of filter user traits (#2679) * fix: add optional chaining for traits (#2677) * fix: add optional chaing for traits * update changelog * feat: geolocation support for python transformations (#2678) * feat: geolocation support for python transformations * chore: updating changelog --------- Co-authored-by: Anant Jain <62471433+anantjain45823@users.noreply.github.com> * update changelog * Update CHANGELOG.md --------- Co-authored-by: Gauravudia <60897972+Gauravudia@users.noreply.github.com> Co-authored-by: shrouti1507 <60211312+shrouti1507@users.noreply.github.com> Co-authored-by: Dilip Kola <33080863+koladilip@users.noreply.github.com> Co-authored-by: Sudip Paul <67197965+ItsSudip@users.noreply.github.com> Co-authored-by: Sanjay <71065320+Sanjay-Veernala@users.noreply.github.com> Co-authored-by: Siva Shanmukh Vetcha <siva.shanmukh@gmail.com> Co-authored-by: Ujjwal Abhishek <63387036+ujjwal-ab@users.noreply.github.com> Co-authored-by: Mihir Bhalala <77438541+mihir-4116@users.noreply.github.com> Co-authored-by: Sankeerth <sankeerth@rudderstack.com> Co-authored-by: AASHISH MALIK <imashishmalik.45@gmail.com> Co-authored-by: Anant Jain <62471433+anantjain45823@users.noreply.github.com> Co-authored-by: Abhimanyu Babbar <abhimanyu.babbar89@gmail.com> Co-authored-by: GitHub Actions <noreply@github.com> Co-authored-by: Jayachand <mjayachand@gmail.com> Co-authored-by: Anant Jain <anantjain45823@gmail.com> --------- Co-authored-by: Abhimanyu Babbar <abhimanyu.babbar89@gmail.com> Co-authored-by: Mihir Bhalala <77438541+mihir-4116@users.noreply.github.com> Co-authored-by: GitHub Actions <noreply@github.com> Co-authored-by: Sudip Paul <67197965+ItsSudip@users.noreply.github.com> Co-authored-by: devops-github-rudderstack <88187154+devops-github-rudderstack@users.noreply.github.com> Co-authored-by: Gauravudia <60897972+Gauravudia@users.noreply.github.com> Co-authored-by: shrouti1507 <60211312+shrouti1507@users.noreply.github.com> Co-authored-by: Dilip Kola <33080863+koladilip@users.noreply.github.com> Co-authored-by: Sanjay <71065320+Sanjay-Veernala@users.noreply.github.com> Co-authored-by: Siva Shanmukh Vetcha <siva.shanmukh@gmail.com> Co-authored-by: Ujjwal Abhishek <63387036+ujjwal-ab@users.noreply.github.com> Co-authored-by: Sankeerth <sankeerth@rudderstack.com> Co-authored-by: AASHISH MALIK <imashishmalik.45@gmail.com> Co-authored-by: Jayachand <mjayachand@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the change
Organised code to use promises and async await for better clarity.
Type of change
Related issues
Checklists
Development
Code review