feat(gaec): partial failures handling #2631

mihir-4116 · 2023-09-19T07:47:52Z

Description of the change

Type of change

Bug fix (non-breaking change that fixes an issue)
New feature (non-breaking change that adds functionality)
Breaking change (fix or feature that would cause existing functionality to not work as expected)

Related issues

Fix #1

Checklists

Development

Lint rules pass locally
The code changed/added as part of this pull request has been covered with tests
All tests related to the changed code pass in development

Code review

This pull request has a descriptive title and information useful to a reviewer. There may be a screenshot or screencast attached
"Ready for review" label attached to the PR and reviewers mentioned in a comment
Changes have been reviewed by at least one other engineer
Issue from task tracker has a link to this pull request

codecov · 2023-09-19T12:08:48Z

Codecov Report

Attention: 1 lines in your changes are missing coverage. Please review.

Comparison is base (c0ab19a) 86.93% compared to head (54d379b) 86.93%.

❗ Current head 54d379b differs from pull request most recent head 71802d4. Consider uploading reports for the commit 71802d4 to get more accurate results

Additional details and impacted files

@@             Coverage Diff             @@
##           develop    #2631      +/-   ##
===========================================
- Coverage    86.93%   86.93%   -0.01%     
===========================================
  Files          605      605              
  Lines        28164    28166       +2     
  Branches      6702     6704       +2     
===========================================
+ Hits         24484    24485       +1     
- Misses        3347     3348       +1     
  Partials       333      333

Files	Coverage Δ
...gle_adwords_enhanced_conversions/networkHandler.js	`90.00% <66.66%> (-1.49%)`	⬇️

... and 1 file with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

src/v0/destinations/google_adwords_enhanced_conversions/networkHandler.js

sonarqubecloud · 2023-09-26T09:16:16Z

Kudos, SonarCloud Quality Gate passed!

0 Bugs
0 Vulnerabilities
0 Security Hotspots
0 Code Smells

57.1% Coverage
0.0% Duplication

* chore: partial failure handling * chore: code review changes

* fix(mixpanel): batch event ordering (#2608) * fix: bqstream event ordering fix (#2624) * fix: bqstream event ordering fix * fix: review comments addressed * fix: importing the common util function * fix: putting both error and successful events logic back * fix: test cases addition and code clean up * fix: code clean up * fix: resolving sonar error * fix: removing network handler for bqstream * fix: refactor process router dest * fix: use promise for prompts in personalize create tracking script (#2635) * fix(snyk): snyk updated versions merged to oen pr * chore: add ttl values for cache (#2593) * fix(hubspot): add validation for hubspotEvents (#2643) * fix: add optional chaining for error message in network handler of Intercom (#2648) fix bugsnag issue * fix(snyk): removed the new added dependencies * fix(snyk): removed aws-sdk dependency * feat: add circular reference check in flattern json (#2650) * chore: update fb_error message for invalid type of property value (#2656) fix: fb_error message for invalid type of property value * feat(iterable): user deletion support (#2621) * feat(iterable): user deletion support * feat(iterable): user deletion improvements * chore: added comments * feat(gaec): partial failures handling (#2631) * chore: partial failure handling * chore: code review changes * chore: move unit tests to correct place for mssql and postgres (#2657) * chore: move unit tests to correct place for mssql and postgres * chore: replace var to const * chore: replace var to const * feat: add axios mocking to component test-suite (#2638) * feat: tslint rules enable (#2604) * feat: remove eslint issues * fix: fixed es-lint tests * fix: merge conflicts * fix: add auth status inactive category handling to GA in userDeletion flow (#2669) * fix: refactor adjust using optional chaining (#2671) fix: refactor adj using opitonal chaining * chore(release): pull main into develop post release v1.43.1 (#2662) * fix(dm): updated the stats definition for the tracking plan service * fix(iterable): event id mapping (#2659) * chore(release): 1.43.1 * chore: update release owners (#2661) chore: update release stakeholder --------- Co-authored-by: Abhimanyu Babbar <abhimanyu.babbar89@gmail.com> Co-authored-by: Mihir Bhalala <77438541+mihir-4116@users.noreply.github.com> Co-authored-by: GitHub Actions <noreply@github.com> Co-authored-by: Anant Jain <62471433+anantjain45823@users.noreply.github.com> Co-authored-by: Sudip Paul <67197965+ItsSudip@users.noreply.github.com> * chore(release): 1.44.0 * feat(ga4): added support of filter user traits (#2679) * fix: add optional chaining for traits (#2677) * fix: add optional chaing for traits * update changelog * feat: geolocation support for python transformations (#2678) * feat: geolocation support for python transformations * chore: updating changelog --------- Co-authored-by: Anant Jain <62471433+anantjain45823@users.noreply.github.com> * update changelog * Update CHANGELOG.md --------- Co-authored-by: Gauravudia <60897972+Gauravudia@users.noreply.github.com> Co-authored-by: shrouti1507 <60211312+shrouti1507@users.noreply.github.com> Co-authored-by: Dilip Kola <33080863+koladilip@users.noreply.github.com> Co-authored-by: Sudip Paul <67197965+ItsSudip@users.noreply.github.com> Co-authored-by: Sanjay <71065320+Sanjay-Veernala@users.noreply.github.com> Co-authored-by: Siva Shanmukh Vetcha <siva.shanmukh@gmail.com> Co-authored-by: Ujjwal Abhishek <63387036+ujjwal-ab@users.noreply.github.com> Co-authored-by: Mihir Bhalala <77438541+mihir-4116@users.noreply.github.com> Co-authored-by: Sankeerth <sankeerth@rudderstack.com> Co-authored-by: AASHISH MALIK <imashishmalik.45@gmail.com> Co-authored-by: Anant Jain <62471433+anantjain45823@users.noreply.github.com> Co-authored-by: Abhimanyu Babbar <abhimanyu.babbar89@gmail.com> Co-authored-by: GitHub Actions <noreply@github.com> Co-authored-by: Jayachand <mjayachand@gmail.com> Co-authored-by: Anant Jain <anantjain45823@gmail.com>

* fix(dm): updated the stats definition for the tracking plan service * fix(iterable): event id mapping (#2659) * chore(release): 1.43.1 * chore: update release owners (#2661) chore: update release stakeholder * chore(release): pull release/v1.44.0 into main (#2672) * fix(mixpanel): batch event ordering (#2608) * fix: bqstream event ordering fix (#2624) * fix: bqstream event ordering fix * fix: review comments addressed * fix: importing the common util function * fix: putting both error and successful events logic back * fix: test cases addition and code clean up * fix: code clean up * fix: resolving sonar error * fix: removing network handler for bqstream * fix: refactor process router dest * fix: use promise for prompts in personalize create tracking script (#2635) * fix(snyk): snyk updated versions merged to oen pr * chore: add ttl values for cache (#2593) * fix(hubspot): add validation for hubspotEvents (#2643) * fix: add optional chaining for error message in network handler of Intercom (#2648) fix bugsnag issue * fix(snyk): removed the new added dependencies * fix(snyk): removed aws-sdk dependency * feat: add circular reference check in flattern json (#2650) * chore: update fb_error message for invalid type of property value (#2656) fix: fb_error message for invalid type of property value * feat(iterable): user deletion support (#2621) * feat(iterable): user deletion support * feat(iterable): user deletion improvements * chore: added comments * feat(gaec): partial failures handling (#2631) * chore: partial failure handling * chore: code review changes * chore: move unit tests to correct place for mssql and postgres (#2657) * chore: move unit tests to correct place for mssql and postgres * chore: replace var to const * chore: replace var to const * feat: add axios mocking to component test-suite (#2638) * feat: tslint rules enable (#2604) * feat: remove eslint issues * fix: fixed es-lint tests * fix: merge conflicts * fix: add auth status inactive category handling to GA in userDeletion flow (#2669) * fix: refactor adjust using optional chaining (#2671) fix: refactor adj using opitonal chaining * chore(release): pull main into develop post release v1.43.1 (#2662) * fix(dm): updated the stats definition for the tracking plan service * fix(iterable): event id mapping (#2659) * chore(release): 1.43.1 * chore: update release owners (#2661) chore: update release stakeholder --------- Co-authored-by: Abhimanyu Babbar <abhimanyu.babbar89@gmail.com> Co-authored-by: Mihir Bhalala <77438541+mihir-4116@users.noreply.github.com> Co-authored-by: GitHub Actions <noreply@github.com> Co-authored-by: Anant Jain <62471433+anantjain45823@users.noreply.github.com> Co-authored-by: Sudip Paul <67197965+ItsSudip@users.noreply.github.com> * chore(release): 1.44.0 * feat(ga4): added support of filter user traits (#2679) * fix: add optional chaining for traits (#2677) * fix: add optional chaing for traits * update changelog * feat: geolocation support for python transformations (#2678) * feat: geolocation support for python transformations * chore: updating changelog --------- Co-authored-by: Anant Jain <62471433+anantjain45823@users.noreply.github.com> * update changelog * Update CHANGELOG.md --------- Co-authored-by: Gauravudia <60897972+Gauravudia@users.noreply.github.com> Co-authored-by: shrouti1507 <60211312+shrouti1507@users.noreply.github.com> Co-authored-by: Dilip Kola <33080863+koladilip@users.noreply.github.com> Co-authored-by: Sudip Paul <67197965+ItsSudip@users.noreply.github.com> Co-authored-by: Sanjay <71065320+Sanjay-Veernala@users.noreply.github.com> Co-authored-by: Siva Shanmukh Vetcha <siva.shanmukh@gmail.com> Co-authored-by: Ujjwal Abhishek <63387036+ujjwal-ab@users.noreply.github.com> Co-authored-by: Mihir Bhalala <77438541+mihir-4116@users.noreply.github.com> Co-authored-by: Sankeerth <sankeerth@rudderstack.com> Co-authored-by: AASHISH MALIK <imashishmalik.45@gmail.com> Co-authored-by: Anant Jain <62471433+anantjain45823@users.noreply.github.com> Co-authored-by: Abhimanyu Babbar <abhimanyu.babbar89@gmail.com> Co-authored-by: GitHub Actions <noreply@github.com> Co-authored-by: Jayachand <mjayachand@gmail.com> Co-authored-by: Anant Jain <anantjain45823@gmail.com> --------- Co-authored-by: Abhimanyu Babbar <abhimanyu.babbar89@gmail.com> Co-authored-by: Mihir Bhalala <77438541+mihir-4116@users.noreply.github.com> Co-authored-by: GitHub Actions <noreply@github.com> Co-authored-by: Sudip Paul <67197965+ItsSudip@users.noreply.github.com> Co-authored-by: devops-github-rudderstack <88187154+devops-github-rudderstack@users.noreply.github.com> Co-authored-by: Gauravudia <60897972+Gauravudia@users.noreply.github.com> Co-authored-by: shrouti1507 <60211312+shrouti1507@users.noreply.github.com> Co-authored-by: Dilip Kola <33080863+koladilip@users.noreply.github.com> Co-authored-by: Sanjay <71065320+Sanjay-Veernala@users.noreply.github.com> Co-authored-by: Siva Shanmukh Vetcha <siva.shanmukh@gmail.com> Co-authored-by: Ujjwal Abhishek <63387036+ujjwal-ab@users.noreply.github.com> Co-authored-by: Sankeerth <sankeerth@rudderstack.com> Co-authored-by: AASHISH MALIK <imashishmalik.45@gmail.com> Co-authored-by: Jayachand <mjayachand@gmail.com>

mihir-4116 requested a review from ItsSudip September 19, 2023 07:47

mihir-4116 self-assigned this Sep 19, 2023

mihir-4116 requested review from a team as code owners September 19, 2023 07:47

mihir-4116 requested a review from krishna2020 September 19, 2023 07:47

mihir-4116 changed the title ~~feat(INT-657): partial failures handling~~ feat(gaec): partial failures handling Sep 19, 2023

chore: partial failure handling

81c8d75

mihir-4116 force-pushed the feat.gaec_pf branch from 57392be to 81c8d75 Compare September 19, 2023 12:01

mihir-4116 added the Ready for Review label Sep 22, 2023

Merge branch 'develop' into feat.gaec_pf

ddebe7b

ItsSudip reviewed Sep 25, 2023

View reviewed changes

src/v0/destinations/google_adwords_enhanced_conversions/networkHandler.js Outdated Show resolved Hide resolved

chore: code review changes

54d379b

mihir-4116 requested a review from ItsSudip September 26, 2023 04:40

ItsSudip approved these changes Sep 26, 2023

View reviewed changes

Merge branch 'develop' into feat.gaec_pf

71802d4

Gauravudia approved these changes Sep 26, 2023

View reviewed changes

mihir-4116 merged commit 0008277 into develop Sep 26, 2023

mihir-4116 deleted the feat.gaec_pf branch September 26, 2023 09:39

Sanjay-Veernala pushed a commit that referenced this pull request Sep 26, 2023

feat(gaec): partial failures handling (#2631)

fd0d86a

* chore: partial failure handling * chore: code review changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat(gaec): partial failures handling #2631

feat(gaec): partial failures handling #2631

mihir-4116 commented Sep 19, 2023

codecov bot commented Sep 19, 2023 •

edited

Loading

sonarqubecloud bot commented Sep 26, 2023

feat(gaec): partial failures handling #2631

feat(gaec): partial failures handling #2631

Conversation

mihir-4116 commented Sep 19, 2023

Description of the change

Type of change

Related issues

Checklists

Development

Code review

codecov bot commented Sep 19, 2023 • edited Loading

Codecov Report

sonarqubecloud bot commented Sep 26, 2023

codecov bot commented Sep 19, 2023 •

edited

Loading