-
Notifications
You must be signed in to change notification settings - Fork 37
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add folder http endpoint #1108
add folder http endpoint #1108
Conversation
🔍 Existing Issues For ReviewYour pull request is modifying functions with the following pre-existing issues: 📄 File: runhouse/servers/http/http_utils.py
Did you find this useful? React with a 👍 or 👎 |
This stack of pull requests is managed by Graphite. Learn more about stacking. |
733b735
to
bc875fc
Compare
) | ||
|
||
for filename, file_obj in contents.items(): | ||
binary_mode = "b" in mode |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@dongreenberg marking this now to discuss later, the server serialization / deserialization business for file contents getting and putting feels a little hairy
bc875fc
to
c3a00ad
Compare
c3a00ad
to
e829646
Compare
22cb540
to
4cf2141
Compare
314dcb3
to
9794d5a
Compare
4ad4f88
to
ca83d03
Compare
@@ -612,6 +624,92 @@ async def rename_object(request: Request, params: RenameObjectParams): | |||
e, traceback.format_exc(), from_http_server=True | |||
) | |||
|
|||
@staticmethod | |||
@app.post("/folder/method/ls") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
maybe just /folder/ls
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this conflicts with the @app.post("/{key}/{method_name}")
method, but welcome to other ideas for the naming convention we use for these endpoints
) | ||
|
||
|
||
def folder_rm(path: Path, contents: List[str], recursive: bool): |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
a bit confused on contents and path both being options?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this supports being able to specify specific folder contents to remove instead of just the entire folder itself, you think that's overkill?
bbd72e7
to
e5e16e7
Compare
e5e16e7
to
d5690e4
Compare
No description provided.