enforce write only access to folder http endpoint #1109
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This stack of pull requests is managed by Graphite. Learn more about stacking. |
jlewitt1
force-pushed
the
folder-http-endpoint
branch
from
bc875fc
to
c3a00ad
Compare
jlewitt1
force-pushed
the
folder-http-endpoint
branch
from
c3a00ad
to
e829646
Compare
jlewitt1
force-pushed
the
folder-endpoint-access
branch
from
fb2180a
to
4da0c4d
Compare
jlewitt1
force-pushed
the
folder-http-endpoint
branch
3 times, most recently
from
22cb540
to
4cf2141
Compare
jlewitt1
force-pushed
the
folder-endpoint-access
branch
from
4da0c4d
to
1722452
Compare
jlewitt1
force-pushed
the
folder-http-endpoint
branch
from
4cf2141
to
314dcb3
Compare
jlewitt1
force-pushed
the
folder-endpoint-access
branch
from
1722452
to
03640e4
Compare
jlewitt1
force-pushed
the
folder-http-endpoint
branch
from
314dcb3
to
9794d5a
Compare
# Conflicts: # runhouse/servers/http/http_utils.py
jlewitt1
force-pushed
the
folder-endpoint-access
branch
from
be625cd
to
dd1312d
Compare
jlewitt1
force-pushed
the
folder-http-endpoint
branch
from
9794d5a
to
4ad4f88
Compare
jlewitt1
force-pushed
the
folder-http-endpoint
branch
from
4ad4f88
to
ca83d03
Compare
# Conflicts: # runhouse/servers/http/http_server.py # runhouse/servers/http/http_utils.py
rohinb2
reviewed
Aug 9, 2024
runhouse/servers/http/auth.py
Outdated
| @@ -75,6 +75,7 @@ def clear_cache(self, token: str = None): | |||
| async def averify_cluster_access( | |||
| cluster_uri: str, | |||
| token: str, | |||
| write_only_access: bool = False, | |||
There was a problem hiding this comment.
instead of a bool here, can just do access_level_required and pass ResourceAccess.WRITE
then below, can do return if access_level_required
cluster_access_level == access_level_required
jlewitt1
force-pushed
the
folder-http-endpoint
branch
from
ca83d03
to
bbd72e7
Compare
# Conflicts: # runhouse/servers/http/http_server.py # runhouse/servers/http/http_utils.py
jlewitt1
force-pushed
the
folder-http-endpoint
branch
from
bbd72e7
to
e5e16e7
Compare
# Conflicts: # runhouse/servers/http/http_server.py # runhouse/servers/http/http_utils.py
jlewitt1
force-pushed
the
folder-endpoint-access
branch
from
bfe2bc9
to
fbe82a6
Compare
jlewitt1
changed the base branch from
folder-http-endpoint
to
graphite-base/1109
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.