add folder methods to rh.cluster #1110
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Warning This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
This stack of pull requests is managed by Graphite. Learn more about stacking. |
jlewitt1
force-pushed
the
cluster-folder-methods
branch
from
334f301
to
4a812dd
Compare
# Conflicts: # runhouse/servers/http/http_server.py # runhouse/servers/http/http_utils.py
jlewitt1
force-pushed
the
cluster-folder-methods
branch
from
4a812dd
to
3f0fece
Compare
jlewitt1
force-pushed
the
cluster-folder-methods
branch
from
3f0fece
to
0f3715c
Compare
jlewitt1
force-pushed
the
cluster-folder-methods
branch
from
0f3715c
to
6e33577
Compare
jlewitt1
force-pushed
the
folder-endpoint-access
branch
from
4da0c4d
to
1722452
Compare
jlewitt1
force-pushed
the
cluster-folder-methods
branch
from
6e33577
to
39dfcd3
Compare
# Conflicts: # runhouse/resources/hardware/cluster.py # runhouse/servers/http/http_client.py # runhouse/servers/http/http_utils.py
jlewitt1
force-pushed
the
folder-endpoint-access
branch
from
1722452
to
03640e4
Compare
jlewitt1
force-pushed
the
cluster-folder-methods
branch
from
39dfcd3
to
d88da6c
Compare
# Conflicts: # runhouse/servers/http/http_utils.py
# Conflicts: # runhouse/servers/http/http_utils.py
# Conflicts: # runhouse/servers/http/http_server.py # runhouse/servers/http/http_utils.py
jlewitt1
force-pushed
the
cluster-folder-methods
branch
from
9c6aacb
to
a69c37c
Compare
rohinb2
reviewed
Aug 9, 2024
| ############################################## | ||
| # Folder Operations | ||
| ############################################## | ||
| def _ls(self, path: Path, full_paths: bool = True, sort: bool = False): |
There was a problem hiding this comment.
i'd prefix these with folder like we've been doing, so like _folder_ls
# Conflicts: # runhouse/servers/http/http_server.py # runhouse/servers/http/http_utils.py
# Conflicts: # runhouse/servers/http/http_server.py # runhouse/servers/http/http_utils.py
jlewitt1
force-pushed
the
cluster-folder-methods
branch
from
305204a
to
e1f5a09
Compare
jlewitt1
force-pushed
the
cluster-folder-methods
branch
from
e1f5a09
to
667f5a5
Compare
# Conflicts: # runhouse/servers/http/http_server.py # runhouse/servers/http/http_utils.py
jlewitt1
force-pushed
the
folder-endpoint-access
branch
from
bfe2bc9
to
fbe82a6
Compare
jlewitt1
force-pushed
the
cluster-folder-methods
branch
from
cf3eae0
to
88e36d7
Compare
jlewitt1
force-pushed
the
cluster-folder-methods
branch
from
88e36d7
to
95046a0
Compare
jlewitt1
changed the base branch from
folder-endpoint-access
to
graphite-base/1110
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.