Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update existing sky runner class #1172

Merged
merged 3 commits into from
Aug 29, 2024
Merged

Update existing sky runner class #1172

merged 3 commits into from
Aug 29, 2024

Conversation

carolineechen
Copy link
Collaborator

No description provided.

This was referenced Aug 20, 2024
Merged
Merged
@carolineechen Graphite App
Copy link
Collaborator Author

carolineechen commented Aug 20, 2024 •
edited
Loading

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @carolineechen and the rest of your teammates on Graphite Graphite

This was referenced Aug 20, 2024
Merged
Merged
@carolineechen carolineechen mentioned this pull request Aug 20, 2024
Merged
@carolineechen carolineechen force-pushed the cc/ssh-tunnel-class branch 3 times, most recently from a55e3f9 to 7aeb3d5 Compare August 21, 2024 18:26
@carolineechen carolineechen marked this pull request as ready for review August 21, 2024 20:36
@carolineechen carolineechen mentioned this pull request Aug 22, 2024
Merged
@carolineechen carolineechen force-pushed the cc/ssh-tunnel-class branch 2 times, most recently from e81665b to 29c0ff0 Compare August 22, 2024 14:14
dongreenberg
dongreenberg reviewed Aug 23, 2024
View reviewed changes
runhouse/resources/hardware/sky/command_runner.py
error_msg,
stderr=stderr,
stream_logs=stream_logs)
rsh_option = f'ssh {ssh_options}'
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

rsh?

@carolineechen carolineechen mentioned this pull request Aug 23, 2024
Merged
@carolineechen carolineechen force-pushed the cc/update-sky-runner branch 2 times, most recently from d08c82a to 7f76f7e Compare August 23, 2024 16:17
@carolineechen carolineechen force-pushed the cc/ssh-tunnel-class branch 2 times, most recently from 291206d to 2583bdf Compare August 29, 2024 16:12
Base automatically changed from cc/ssh-tunnel-class to main August 29, 2024 17:20
@carolineechen carolineechen merged commit 144cacb into main Aug 29, 2024
12 checks passed
@carolineechen carolineechen deleted the cc/update-sky-runner branch August 29, 2024 17:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dongreenberg dongreenberg dongreenberg approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@carolineechen @dongreenberg