-
Notifications
You must be signed in to change notification settings - Fork 37
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add sky k8s command runner #1173
Conversation
This stack of pull requests is managed by Graphite. Learn more about stacking. Join @carolineechen and the rest of your teammates on Graphite |
🔍 Existing Issues For ReviewYour pull request is modifying functions with the following pre-existing issues: 📄 File: runhouse/resources/hardware/sky_ssh_runner.py
Did you find this useful? React with a 👍 or 👎 |
a1af88c
to
f17b2ff
Compare
c9fcbc0
to
110c3ca
Compare
f17b2ff
to
a6dc89e
Compare
110c3ca
to
cbb0b57
Compare
a6dc89e
to
2906d02
Compare
cbb0b57
to
7d3fbed
Compare
2906d02
to
51b3201
Compare
7d3fbed
to
d1956b6
Compare
51b3201
to
9894a97
Compare
d1956b6
to
13f3e7e
Compare
9894a97
to
6afccec
Compare
13f3e7e
to
81213ec
Compare
Args: | ||
node: The namespace and pod_name of the remote machine. | ||
""" | ||
del kwargs |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't get this... but ok
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this file is just source code from skypilot, that we subclass and edit for the runhouse versions. I guess the only core components for the k8s command runner are the namespace and pod name
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sick work looks great!!!
6afccec
to
f86ca8f
Compare
81213ec
to
dec7d69
Compare
f86ca8f
to
d08c82a
Compare
dec7d69
to
1e5d42d
Compare
d08c82a
to
7f76f7e
Compare
7f76f7e
to
f05b39a
Compare
1e5d42d
to
9864fc9
Compare
f05b39a
to
0f9c71a
Compare
c9233ce
to
246f0a1
Compare
0f9c71a
to
5da6a86
Compare
246f0a1
to
cd2640f
Compare
5da6a86
to
4b98200
Compare
cd2640f
to
3fdffd5
Compare
4b98200
to
f37c82b
Compare
3fdffd5
to
a49a04d
Compare
a49a04d
to
8fda09b
Compare
No description provided.