Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add sky k8s command runner #1173

Merged
merged 1 commit into from
Aug 29, 2024
Merged

Add sky k8s command runner #1173

merged 1 commit into from
Aug 29, 2024

Conversation

carolineechen
Copy link
Collaborator

No description provided.

Copy link

sentry-io bot commented Aug 20, 2024

🔍 Existing Issues For Review

Your pull request is modifying functions with the following pre-existing issues:

📄 File: runhouse/resources/hardware/sky_ssh_runner.py

Function Unhandled Issue
rsync CommandError: Command rsync -Pavz --filter='dir-merge,- .gitignore' -e "ssh -o Port=22 -o StrictHostKeyChecking... ...
Event Count: 1

Did you find this useful? React with a 👍 or 👎

@carolineechen carolineechen marked this pull request as ready for review August 21, 2024 20:36
Args:
node: The namespace and pod_name of the remote machine.
"""
del kwargs
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't get this... but ok

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this file is just source code from skypilot, that we subclass and edit for the runhouse versions. I guess the only core components for the k8s command runner are the namespace and pod name

Copy link
Contributor

@dongreenberg dongreenberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sick work looks great!!!

@carolineechen carolineechen merged commit 2daf76f into main Aug 29, 2024
12 checks passed
@carolineechen carolineechen deleted the cc/add-sky-k8s-runner branch August 29, 2024 17:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants