-
Notifications
You must be signed in to change notification settings - Fork 344
N17: Veloren #422
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
N17: Veloren #422
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Content looks good, but there's a few formatting issues tripping up the CI build:
content/posts/newsletter-017/index.md:112:81 MD013/line-length Line length [Expected: 80; Actual: 99]
content/posts/newsletter-017/index.md:113:81 MD013/line-length Line length [Expected: 80; Actual: 92]
content/posts/newsletter-017/index.md:115:81 MD013/line-length Line length [Expected: 80; Actual: 92]
content/posts/newsletter-017/index.md:122:81 MD013/line-length Line length [Expected: 80; Actual: 85]
content/posts/newsletter-017/index.md:123:81 MD013/line-length Line length [Expected: 80; Actual: 87]
content/posts/newsletter-017/index.md:125:81 MD013/line-length Line length [Expected: 80; Actual: 104]
content/posts/newsletter-017/index.md:127:81 MD013/line-length Line length [Expected: 80; Actual: 82]
content/posts/newsletter-017/index.md:128:81 MD013/line-length Line length [Expected: 80; Actual: 88]
content/posts/newsletter-017/index.md:129:81 MD013/line-length Line length [Expected: 80; Actual: 106]
content/posts/newsletter-017/index.md:130:81 MD013/line-length Line length [Expected: 80; Actual: 85]
content/posts/newsletter-017/index.md:132:81 MD013/line-length Line length [Expected: 80; Actual: 97]
content/posts/newsletter-017/index.md:133:81 MD013/line-length Line length [Expected: 80; Actual: 109]
It also looks like you may have accidentally committed some changes to the front matter/intro of the post. For future reference, if you need to preview the post locally, you can run Zola with the --drafts
flag to avoid having to edit the flag in the post :)
3a23474
to
e7dfec7
Compare
I totally forgot about the drafts 😅 and good to know the command 👌 I also always forget to turn off my default markdown formatted 😛 but it should all be good now! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
@AngelOnFira your editor doesn't recognize |
VS Code / Prettier. I'll take a look at if it's having any trouble reading the markdown lint file. |
Yeah, looks like Prettier doesn't look at |
Attempted to rework the section:
@AngelOnFira are you ok with these changes? |
@ozkriff Looks good to me! I wasn't sure how to compact it, so I'm glad you found a way. Sorry for all the extra work 😅 |
Thanks for the PR!! |
Part of #408 🎉