Skip to content

N17: Veloren #422

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Jan 12, 2021
Merged

Conversation

AngelOnFira
Copy link
Member

Part of #408 🎉

Copy link
Collaborator

@17cupsofcoffee 17cupsofcoffee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Content looks good, but there's a few formatting issues tripping up the CI build:

content/posts/newsletter-017/index.md:112:81 MD013/line-length Line length [Expected: 80; Actual: 99]
content/posts/newsletter-017/index.md:113:81 MD013/line-length Line length [Expected: 80; Actual: 92]
content/posts/newsletter-017/index.md:115:81 MD013/line-length Line length [Expected: 80; Actual: 92]
content/posts/newsletter-017/index.md:122:81 MD013/line-length Line length [Expected: 80; Actual: 85]
content/posts/newsletter-017/index.md:123:81 MD013/line-length Line length [Expected: 80; Actual: 87]
content/posts/newsletter-017/index.md:125:81 MD013/line-length Line length [Expected: 80; Actual: 104]
content/posts/newsletter-017/index.md:127:81 MD013/line-length Line length [Expected: 80; Actual: 82]
content/posts/newsletter-017/index.md:128:81 MD013/line-length Line length [Expected: 80; Actual: 88]
content/posts/newsletter-017/index.md:129:81 MD013/line-length Line length [Expected: 80; Actual: 106]
content/posts/newsletter-017/index.md:130:81 MD013/line-length Line length [Expected: 80; Actual: 85]
content/posts/newsletter-017/index.md:132:81 MD013/line-length Line length [Expected: 80; Actual: 97]
content/posts/newsletter-017/index.md:133:81 MD013/line-length Line length [Expected: 80; Actual: 109]

It also looks like you may have accidentally committed some changes to the front matter/intro of the post. For future reference, if you need to preview the post locally, you can run Zola with the --drafts flag to avoid having to edit the flag in the post :)

@AngelOnFira AngelOnFira force-pushed the veloren-december-content branch from 3a23474 to e7dfec7 Compare January 6, 2021 15:26
@AngelOnFira
Copy link
Member Author

I totally forgot about the drafts 😅 and good to know the command 👌 I also always forget to turn off my default markdown formatted 😛 but it should all be good now!

Copy link
Collaborator

@17cupsofcoffee 17cupsofcoffee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@ozkriff ozkriff mentioned this pull request Jan 8, 2021
@ozkriff
Copy link
Member

ozkriff commented Jan 11, 2021

I also always forget to turn off my default markdown formatted

@AngelOnFira your editor doesn't recognize .markdownlint.json? What editor/plugin are you using? 🤔

@AngelOnFira
Copy link
Member Author

VS Code / Prettier. I'll take a look at if it's having any trouble reading the markdown lint file.

@ozkriff
Copy link
Member

ozkriff commented Jan 11, 2021

Yeah, looks like Prettier doesn't look at .markdownlint.json. Well, we might create and commit .prettierrc.json that fits newsletter's style too. Or maybe .editorconfig may work.

@ozkriff
Copy link
Member

ozkriff commented Jan 12, 2021

Attempted to rework the section:

  • the original dense list of links to all sections from 100th devlog isn't consistent with how we usually do this (and looks weird on mobile browser), so I've converted it to a list of highlights.
  • fixed links
  • removed the third image to make the section a little more compact.

@AngelOnFira are you ok with these changes?

@AngelOnFira
Copy link
Member Author

@ozkriff Looks good to me! I wasn't sure how to compact it, so I'm glad you found a way. Sorry for all the extra work 😅

@ozkriff ozkriff merged commit a696325 into rust-gamedev:source Jan 12, 2021
@ozkriff
Copy link
Member

ozkriff commented Jan 12, 2021

Thanks for the PR!!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants