Skip to content

N23: "thRustEngine" demo #702

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 14 commits into from
Jul 6, 2021
Merged

N23: "thRustEngine" demo #702

merged 14 commits into from
Jul 6, 2021

Conversation

experiment9123
Copy link
Contributor

Newsletter 23 #677

adding thRustEngine to engine updates
added screenshot of thrustengine
added screenshot
thrustengine- removed repitition, explanation of public crate
Copy link
Collaborator

@17cupsofcoffee 17cupsofcoffee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please can you reformat this to meet the style guidelines? Primarily:

  • There should be one blank line above and below each heading and image (no more or less).
  • Lines should be 80 characters long at most.

Also, it looks like you've uploaded a screenshot to the root of the repo - can you delete this?

removed accidental screenshot (shouldn't be here in root)
reformatted for style guidelines.
trying to match style guidelines
cleanup reformating,punctuation
@experiment9123
Copy link
Contributor Author

yikes ok I deleted the extraneous screenshot. Is it lines or sentances of 80chars? I've shortened and split them etc- is this closer?

Copy link
Collaborator

@17cupsofcoffee 17cupsofcoffee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's 80 per line rather than per sentence (just makes the diffs a bit easier to read). I was able to fix the last few bits myself, thanks for sorting the screenshot issues :)

@experiment9123
Copy link
Contributor Author

awesome, thanks, i'll know for next time

@ozkriff ozkriff changed the title rust shooter game - "thRustEngine" demo - pull request for rust gamedev newsletter N23: "thRustEngine" demo Jul 6, 2021
@ozkriff ozkriff merged commit f1b3574 into rust-gamedev:source Jul 6, 2021
@ozkriff
Copy link
Member

ozkriff commented Jul 6, 2021

Merged, thanks for the PR!

@ozkriff ozkriff mentioned this pull request Jul 6, 2021
53 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants