-
Notifications
You must be signed in to change notification settings - Fork 626
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove Debug
constraint for oneshot
types
#2666
Merged
taiki-e
merged 1 commit into
rust-lang:master
from
daxpedda:remove-oneshot-debug-constraint
Nov 27, 2022
Merged
Remove Debug
constraint for oneshot
types
#2666
taiki-e
merged 1 commit into
rust-lang:master
from
daxpedda:remove-oneshot-debug-constraint
Nov 27, 2022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
taiki-e
approved these changes
Nov 26, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks! These bounds were originally left for future compatibility (#2414), but given that the Debug impls for std mpsc and crossbeam-channel also do not have these bounds, it seems unlikely that we will need them in the future.
taiki-e
added
A-channel
Area: futures::channel
0.3-backport: pending
The maintainer accepted to backport this to the 0.3 branch, but backport has not been done yet.
labels
Nov 27, 2022
daxpedda
added a commit
to daxpedda/futures-rs
that referenced
this pull request
Nov 27, 2022
taiki-e
added
0.3-backport: completed
and removed
0.3-backport: pending
The maintainer accepted to backport this to the 0.3 branch, but backport has not been done yet.
labels
Jan 30, 2023
taiki-e
pushed a commit
that referenced
this pull request
Jan 30, 2023
Merged
taiki-e
pushed a commit
that referenced
this pull request
Jan 30, 2023
crapStone
pushed a commit
to Calciumdibromid/CaBr2
that referenced
this pull request
Feb 2, 2023
This PR contains the following updates: | Package | Type | Update | Change | |---|---|---|---| | [futures](https://rust-lang.github.io/futures-rs) ([source](https://github.com/rust-lang/futures-rs)) | dependencies | patch | `0.3.25` -> `0.3.26` | --- ### Release Notes <details> <summary>rust-lang/futures-rs</summary> ### [`v0.3.26`](https://github.com/rust-lang/futures-rs/blob/HEAD/CHANGELOG.md#​0326---2023-01-30) [Compare Source](rust-lang/futures-rs@0.3.25...0.3.26) - Add `Either::as_pin_mut` and `Either::as_pin_ref` ([#​2691](rust-lang/futures-rs#2691)) - Add `Shared::ptr_eq` and `Shared::ptr_hash` ([#​2691](rust-lang/futures-rs#2691)) - Implement `FusedStream` for `Buffered` ([#​2676](rust-lang/futures-rs#2676)) - Implement `FusedStream` for all streams in `ReadyChunks` ([#​2693](rust-lang/futures-rs#2693)) - Fix bug in `FuturesOrdered::push_front` ([#​2664](rust-lang/futures-rs#2664)) - Remove `Fut::Output: Clone` bounds from some `Shared` methods ([#​2662](rust-lang/futures-rs#2662)) - Remove `T: Debug` bounds from `Debug` implementations of `mpsc` and `oneshot` types ([#​2666](rust-lang/futures-rs#2666), [#​2667](rust-lang/futures-rs#2667)) </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR has been generated by [Renovate Bot](https://github.com/renovatebot/renovate). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNC4xMTYuMSIsInVwZGF0ZWRJblZlciI6IjM0LjExOS4yIn0=--> Co-authored-by: cabr2-bot <cabr2.help@gmail.com> Reviewed-on: https://codeberg.org/Calciumdibromid/CaBr2/pulls/1762 Reviewed-by: crapStone <crapstone@noreply.codeberg.org> Co-authored-by: Calciumdibromid Bot <cabr2_bot@noreply.codeberg.org> Co-committed-by: Calciumdibromid Bot <cabr2_bot@noreply.codeberg.org>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This removes the unnecessary
Debug
constraint onDebug
implementation ononeshot::Receiver
andoneshot::Sender
.I believe this is not a breaking change?