-
Notifications
You must be signed in to change notification settings - Fork 12.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
regression: no emojis in lifetime names (despite no emojis being present?) #109746
Labels
P-medium
Medium priority
regression-from-stable-to-beta
Performance or correctness regression from stable to beta.
T-compiler
Relevant to the compiler team, which will review and decide on the PR/issue.
Milestone
Comments
Mark-Simulacrum
added
T-compiler
Relevant to the compiler team, which will review and decide on the PR/issue.
regression-from-stable-to-beta
Performance or correctness regression from stable to beta.
E-needs-bisection
Call for participation: This issue needs bisection: https://github.com/rust-lang/cargo-bisect-rustc
labels
Mar 30, 2023
rustbot
added
the
I-prioritize
Issue: Indicates that prioritization has been requested for this issue.
label
Mar 30, 2023
ehuss
removed
the
E-needs-bisection
Call for participation: This issue needs bisection: https://github.com/rust-lang/cargo-bisect-rustc
label
Mar 30, 2023
BTW, here's a minimal repro: macro_rules! foo {
($tt1:tt) => {};
}
fn x() {
foo!('me#foo);
} |
Thanks for the ping! Fixing it in #109754. ( |
estebank
added a commit
to estebank/rust
that referenced
this issue
Mar 30, 2023
WG-prioritization assigning priority (Zulip discussion). @rustbot label -I-prioritize +P-medium |
rustbot
added
P-medium
Medium priority
and removed
I-prioritize
Issue: Indicates that prioritization has been requested for this issue.
labels
Mar 30, 2023
Update: t-compiler decided to revert the PR that introduced the regression |
compiler-errors
added a commit
to compiler-errors/rust
that referenced
this issue
Apr 10, 2023
… literals" Reverts PR rust-lang#108031 Fixes (doesnt close until beta backported) rust-lang#109746 This reverts commit e3f9db5. This reverts commit 98b82ae. This reverts commit 380fa26.
Dylan-DPC
added a commit
to Dylan-DPC/rust
that referenced
this issue
Apr 10, 2023
…avidtwco Revert "Don't recover lifetimes/labels containing emojis as character literals" Reverts PR rust-lang#108031 per rust-lang#109754 (comment) Fixes (doesnt close until beta backported) rust-lang#109746 This reverts commit e3f9db5. This reverts commit 98b82ae. This reverts commit 380fa26.
JohnTitor
added a commit
to JohnTitor/rust
that referenced
this issue
Apr 11, 2023
…avidtwco Revert "Don't recover lifetimes/labels containing emojis as character literals" Reverts PR rust-lang#108031 per rust-lang#109754 (comment) Fixes (doesnt close until beta backported) rust-lang#109746 This reverts commit e3f9db5. This reverts commit 98b82ae. This reverts commit 380fa26.
Dylan-DPC
added a commit
to Dylan-DPC/rust
that referenced
this issue
Apr 11, 2023
…avidtwco Revert "Don't recover lifetimes/labels containing emojis as character literals" Reverts PR rust-lang#108031 per rust-lang#109754 (comment) Fixes (doesnt close until beta backported) rust-lang#109746 This reverts commit e3f9db5. This reverts commit 98b82ae. This reverts commit 380fa26.
compiler-errors
added a commit
to compiler-errors/rust
that referenced
this issue
Apr 11, 2023
…avidtwco Revert "Don't recover lifetimes/labels containing emojis as character literals" Reverts PR rust-lang#108031 per rust-lang#109754 (comment) Fixes (doesnt close until beta backported) rust-lang#109746 This reverts commit e3f9db5. This reverts commit 98b82ae. This reverts commit 380fa26.
matthiaskrgr
added a commit
to matthiaskrgr/rust
that referenced
this issue
Apr 12, 2023
…avidtwco Revert "Don't recover lifetimes/labels containing emojis as character literals" Reverts PR rust-lang#108031 per rust-lang#109754 (comment) Fixes (doesnt close until beta backported) rust-lang#109746 This reverts commit e3f9db5. This reverts commit 98b82ae. This reverts commit 380fa26.
bors
pushed a commit
to rust-lang-ci/rust
that referenced
this issue
Apr 16, 2023
… literals" Reverts PR rust-lang#108031 Fixes (doesnt close until beta backported) rust-lang#109746 This reverts commit e3f9db5. This reverts commit 98b82ae. This reverts commit 380fa26.
This was reverted in 1.69 |
MabezDev
pushed a commit
to esp-rs/rust
that referenced
this issue
May 16, 2023
… literals" Reverts PR rust-lang#108031 Fixes (doesnt close until beta backported) rust-lang#109746 This reverts commit e3f9db5. This reverts commit 98b82ae. This reverts commit 380fa26.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
P-medium
Medium priority
regression-from-stable-to-beta
Performance or correctness regression from stable to beta.
T-compiler
Relevant to the compiler team, which will review and decide on the PR/issue.
Not clear what the cause here is, but worth figuring out.
The text was updated successfully, but these errors were encountered: