Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

triagebot: add translation-related mention groups #100379

Merged
merged 3 commits into from
Aug 17, 2022
Merged

triagebot: add translation-related mention groups #100379

merged 3 commits into from
Aug 17, 2022

Conversation

davidtwco
Copy link
Member

@davidtwco davidtwco commented Aug 10, 2022 •
edited
Loading

  • Move some code around so that triagebot can ping relevant parties when translation logic is modified.
  • Add mention groups to triagebot for translation-related files/folders.
  • Auto-label pull requests with changes to translation-related files/folders with A-translation.

r? @Mark-Simulacrum

@rustbot rustbot added T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue. labels Aug 10, 2022
@rustbot
Copy link
Collaborator

rustbot commented Aug 10, 2022

Some changes occurred in src/tools/rustfmt

cc @rust-lang/rustfmt

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Aug 10, 2022
davidtwco
davidtwco commented Aug 10, 2022
View reviewed changes
triagebot.toml Outdated

[mentions."compiler/rustc_macros/src/diagnostics"]
message = "`rustc_macros::diagnostics` was changed"
cc = ["@davidtwco"]
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@rust-lang/wg-diagnostics anyone else want in these groups?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

me 🙌

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you also add me? Thanks!

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added both!

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

feel free to add me

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added!

@Mark-Simulacrum
Copy link
Member

r=me, but will let you approve after folks chime in

@rust-log-analyzer

This comment has been minimized.

Sign in to view
@Mark-Simulacrum Mark-Simulacrum added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Aug 11, 2022
@compiler-errors
Copy link
Member

Can we get triagebot to auto-label PRs with: A-translation Area: Translation infrastructure, and migrating existing diagnostics to SessionDiagnostic ?

@davidtwco
Copy link
Member Author

Can we get triagebot to auto-label PRs with: A-translation Area: Translation infrastructure, and migrating existing diagnostics to SessionDiagnostic ?

Added!

@bors

This comment was marked as resolved.

Sign in to view
@davidtwco
errors: move translation logic into module
510ba03 
Just moving code around so that triagebot can ping relevant parties when
translation logic is modified.

Signed-off-by: David Wood <david.wood@huawei.com>
@davidtwco
triagebot: add mention groups for diag translation
a9e6167 
Add mention groups to `triagebot.toml` for diagnostic derive macros and
diagnostic translation sources/resources.

Signed-off-by: David Wood <david.wood@huawei.com>
@davidtwco
triagebot: autolabel A-translation
ae02014 
Instruct triagebot to autolabel pull requests that modify the
translation sources with the `A-translation` label.

Signed-off-by: David Wood <david.wood@huawei.com>
@davidtwco
Copy link
Member Author

@bors r=Mark-Simulacrum rollup

@bors
Copy link
Contributor

bors commented Aug 17, 2022

📌 Commit ae02014 has been approved by Mark-Simulacrum

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Aug 17, 2022
@matthiaskrgr matthiaskrgr mentioned this pull request Aug 17, 2022
Merged
bors added a commit to rust-lang-ci/rust that referenced this pull request Aug 17, 2022
@bors
Auto merge of rust-lang#100677 - matthiaskrgr:rollup-au41ho1, r=matth…
9c20b2a 
…iaskrgr

Rollup of 15 pull requests

Successful merges:

 - rust-lang#99474 (Rustdoc json tests: New `@hasexact` test command)
 - rust-lang#99972 (interpret: only consider 1-ZST when searching for receiver)
 - rust-lang#100018 (Clean up `LitKind`)
 - rust-lang#100379 (triagebot: add translation-related mention groups)
 - rust-lang#100389 (Do not report cycle error when inferring return type for suggestion)
 - rust-lang#100489 (`is_knowable` use `Result` instead of `Option`)
 - rust-lang#100532 (unwind: don't build dependency when building for Miri)
 - rust-lang#100608 (needless separation of impl blocks)
 - rust-lang#100621 (Pass +atomics-32 feature for {arm,thumb}v4t-none-eabi)
 - rust-lang#100646 (Migrate emoji identifier diagnostics to `SessionDiagnostic` in rustc_interface)
 - rust-lang#100652 (Remove deferred sized checks (make them eager))
 - rust-lang#100655 (Update books)
 - rust-lang#100656 (Update cargo)
 - rust-lang#100660 (Fixed a few documentation errors)
 - rust-lang#100661 (Fixed a few documentation errors)

Failed merges:

r? `@ghost`
`@rustbot` modify labels: rollup
@davidtwco davidtwco added the A-translation Area: Translation infrastructure, and migrating existing diagnostics to SessionDiagnostic label Aug 17, 2022
@bors bors merged commit 989e4ff into rust-lang:master Aug 17, 2022
@rustbot rustbot added this to the 1.65.0 milestone Aug 17, 2022
@davidtwco davidtwco deleted the triagebot-diag branch August 17, 2022 17:36
calebcartwright pushed a commit to calebcartwright/rust that referenced this pull request Jan 24, 2023
@matthiaskrgr
Rollup merge of rust-lang#100379 - davidtwco:triagebot-diag, r=Mark-S…
6884e04 
…imulacrum

triagebot: add translation-related mention groups

- Move some code around so that triagebot can ping relevant parties when translation logic is modified.
- Add mention groups to triagebot for translation-related files/folders.
- Auto-label pull requests with changes to translation-related files/folders with `A-translation`.

r? `@Mark-Simulacrum`
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JohnTitor JohnTitor JohnTitor left review comments

@compiler-errors compiler-errors compiler-errors left review comments

@estebank estebank estebank left review comments

Assignees

@Mark-Simulacrum Mark-Simulacrum

Labels
A-translation Area: Translation infrastructure, and migrating existing diagnostics to SessionDiagnostic S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
1.65.0
Development

Successfully merging this pull request may close these issues.
9 participants
@davidtwco @rustbot @Mark-Simulacrum @rust-log-analyzer @compiler-errors @bors @estebank @JohnTitor @rust-highfive