Rollup of 15 pull requests #100677

matthiaskrgr · 2022-08-17T10:33:03Z

Successful merges:

Rustdoc json tests: New @ismany test command #99474 (Rustdoc json tests: New @hasexact test command)
interpret: only consider 1-ZST when searching for receiver #99972 (interpret: only consider 1-ZST when searching for receiver)
Clean up LitKind #100018 (Clean up LitKind)
triagebot: add translation-related mention groups #100379 (triagebot: add translation-related mention groups)
Do not report cycle error when inferring return type for suggestion #100389 (Do not report cycle error when inferring return type for suggestion)
is_knowable use Result instead of Option #100489 (is_knowable use Result instead of Option)
unwind: don't build dependency when building for Miri #100532 (unwind: don't build dependency when building for Miri)
needless separation of impl blocks #100608 (needless separation of impl blocks)
Pass +atomics-32 feature for {arm,thumb}v4t-none-eabi #100621 (Pass +atomics-32 feature for {arm,thumb}v4t-none-eabi)
Migrate emoji identifier diagnostics to SessionDiagnostic in rustc_interface #100646 (Migrate emoji identifier diagnostics to SessionDiagnostic in rustc_interface)
Remove deferred sized checks (make them eager) #100652 (Remove deferred sized checks (make them eager))
Update books #100655 (Update books)
Update cargo #100656 (Update cargo)
Fixed a few documentation errors #100660 (Fixed a few documentation errors)
Fixed a few documentation errors #100661 (Fixed a few documentation errors)

Failed merges:

r? @ghost
@rustbot modify labels: rollup

Just moving code around so that triagebot can ping relevant parties when translation logic is modified. Signed-off-by: David Wood <david.wood@huawei.com>

Add mention groups to `triagebot.toml` for diagnostic derive macros and diagnostic translation sources/resources. Signed-off-by: David Wood <david.wood@huawei.com>

Instruct triagebot to autolabel pull requests that modify the translation sources with the `A-translation` label. Signed-off-by: David Wood <david.wood@huawei.com>

The two methods are almost identical.

By using `expr_str` more and adding `expr_{char,byte_str}`.

- Rename `ast::Lit::token` as `ast::Lit::token_lit`, because its type is `token::Lit`, which is not a token. (This has been confusing me for a long time.) reasonable because we have an `ast::token::Lit` inside an `ast::Lit`. - Rename `LitKind::{from,to}_lit_token` as `LitKind::{from,to}_token_lit`, to match the above change and `token::Lit`.

IEEE-754, not IEEE-745. May save someone a second sometime

Quick pull request; IEEE-754, not IEEE-745. May save someone a quick second some time.

…-test-cleanup, r=CraftSpider Rustdoc json tests: New @hasexact test command Alot of the time, we wanted to assert that a module had an exact set of items. Most of the time this was done by asserting that the ```@count``` of the module was `n`, and then doing `n` ```@has``` checks on the module. This was tedious, so often shortcuts were done. This PR adds a new command to jsondocck to allow consistently expressing this behavior, and then uses it to clean up the tests. ``@rustbot`` modify labels: +A-rustdoc-json +A-testsuite

interpret: only consider 1-ZST when searching for receiver `repr(transparent)` currently entirely rejects ZST with alignment larger than 1 (which is odd, arguably [this](https://play.rust-lang.org/?version=stable&mode=debug&edition=2021&gist=02870f29396fa948c3123cb53d869ad1) should be accepted), so this should be safe. And if it ever isn't safe then that is very likely a bug elsewhere in the compiler.

…trochenkov Clean up `LitKind` r? ``@petrochenkov``

…imulacrum triagebot: add translation-related mention groups - Move some code around so that triagebot can ping relevant parties when translation logic is modified. - Add mention groups to triagebot for translation-related files/folders. - Auto-label pull requests with changes to translation-related files/folders with `A-translation`. r? `@Mark-Simulacrum`

…tion-cycle, r=cjgillot Do not report cycle error when inferring return type for suggestion The UI test is a good example of a case where this happens. The cycle is due to needing the value of the return type `-> _` to compute the variances of items in the crate, but then needing the variances of the items in the crate to do typechecking to infer what `-> _`'s real type is. Since we're already gonna emit an error in astconv, just delay the cycle bug as an error.

`is_knowable` use `Result` instead of `Option`

…acrum unwind: don't build dependency when building for Miri This is basically re-submitting rust-lang#94813. In that PR there was a suggestion to instead have bootstrap set a `RUST_CHECK` env var and use that rather than doing something Miri-specific. However, such an env var would mean that when switching between `./x.py check` and `./x.py build`, the build script gets re-run each time, which doesn't seem good. So I think for now checking for Miri probably causes fewer problems. r? ````@Mark-Simulacrum````

…KO8Ki needless separation of impl blocks

Pass +atomics-32 feature for {arm,thumb}v4t-none-eabi Similar to rust-lang@89582e8, but for ARMv4t. Pre-v6 ARM target does not have atomic CAS, except for Linux and Android where atomic CAS is provided by compiler-builtins. So, there is a similar issue as thumbv6m. I have confirmed that enabling the `atomics-32` target feature fixes the problem in the project affected by this issue. (taiki-e/portable-atomic#28 (comment)) Closes rust-lang#100619 r? ``@nikic`` cc ``@Lokathor``

bors · 2022-08-17T10:33:21Z

📌 Commit 1199dbd has been approved by matthiaskrgr

It is now in the queue for this repository.

bors · 2022-08-17T10:33:46Z

⌛ Testing commit 1199dbd with merge 6146e596b71fc154320e6c37fb645f0fe85184b3...

bors · 2022-08-17T14:48:46Z

💥 Test timed out

matthiaskrgr · 2022-08-17T14:48:59Z

@bors retry

bors · 2022-08-17T14:49:12Z

⌛ Testing commit 1199dbd with merge 9c20b2a...

rust-log-analyzer · 2022-08-17T14:59:21Z

A job failed! Check out the build log: (web) (plain)

Click to see the possible cause of the failure (guessed by this bot)

bors · 2022-08-17T17:30:11Z

☀️ Test successful - checks-actions
Approved by: matthiaskrgr
Pushing 9c20b2a to master...

rust-timer · 2022-08-17T17:34:27Z

📌 Perf builds for each rolled up PR:

PR#	Perf Build Sha
#100661	3d050a3f0bae5857a0949ace4758f7910fec8a57
#100660	003e948890aa04610a31994ce9f41d1518d126b0
#100656	224e9903059cf2431bd01ccb681c490b5677ab4f
#100655	ddec27d816bf0fc4f3313a5a484ab40e9d13a7e5
#100652	8203583dca6e7de881b6615120538fea7be69577
#100646	0e1c5a091b27624b3eb79c6b68cf026a68e77891
#100621	890b62d1ed38686d6fe9183206d5e088152f96b9
#100608	ba168b31f0759f85aafb6c889b50ef8121b63500
#100532	ce45188eea64870dbf2e45b8bfa64cfaa9ba7549
#100489	8d88e7c537ea80fabc12d472f2e59fdab8994c9b
#100389	54c433d4ef511eb968f736efbdffc03c78ce09bc
#100379	f3de4bd94673cb825863ac18a48c20528dfab299
#100018	3730cbea894eb2848c571ce93a823ee8ed5fd184
#99972	6db2e048fa6ad2489212d9d87d1291d6a6c1c91a
#99474	bceecfdea64374c85a7fa5b9797abbce671f40a1

In the case of a perf regression, run the following command for each PR you suspect might be the cause: @rust-timer build $SHA

rust-timer · 2022-08-17T18:46:58Z

Finished benchmarking commit (9c20b2a): comparison url.

Instruction count

Primary benchmarks: ❌ relevant regressions found
Secondary benchmarks: ❌ relevant regressions found

	mean¹	max	count²
Regressions ❌ (primary)	0.3%	0.3%	2
Regressions ❌ (secondary)	1.3%	1.9%	4
Improvements ✅ (primary)	-	-	0
Improvements ✅ (secondary)	-	-	0
All ❌✅ (primary)	0.3%	0.3%	2

Max RSS (memory usage)

Results

Primary benchmarks: ❌ relevant regression found
Secondary benchmarks: ✅ relevant improvements found

	mean¹	max	count²
Regressions ❌ (primary)	2.8%	2.8%	1
Regressions ❌ (secondary)	-	-	0
Improvements ✅ (primary)	-	-	0
Improvements ✅ (secondary)	-3.0%	-3.7%	8
All ❌✅ (primary)	2.8%	2.8%	1

Cycles

This benchmark run did not return any relevant results for this metric.

If you disagree with this performance assessment, please file an issue in rust-lang/rustc-perf.

Next Steps: If you can justify the regressions found in this perf run, please indicate this with @rustbot label: +perf-regression-triaged along with sufficient written justification. If you cannot justify the regressions please open an issue or create a new PR that fixes the regressions, add a comment linking to the newly created issue or PR, and then add the perf-regression-triaged label to this PR.

@rustbot label: +perf-regression
cc @rust-lang/wg-compiler-performance

the arithmetic mean of the percent change ↩ ↩²
number of relevant changes ↩ ↩²

lqd · 2022-08-17T19:48:28Z

Probably this one: @rust-timer build 8203583dca6e7de881b6615120538fea7be69577

rust-timer · 2022-08-17T19:48:31Z

Queued 8203583dca6e7de881b6615120538fea7be69577 with parent 86c6ebe, future comparison URL.

rust-timer · 2022-08-17T21:06:29Z

Finished benchmarking commit (8203583dca6e7de881b6615120538fea7be69577): comparison url.

Instruction count

Primary benchmarks: ❌ relevant regressions found
Secondary benchmarks: ❌ relevant regressions found

	mean¹	max	count²
Regressions ❌ (primary)	0.5%	1.0%	8
Regressions ❌ (secondary)	1.7%	2.2%	3
Improvements ✅ (primary)	-	-	0
Improvements ✅ (secondary)	-	-	0
All ❌✅ (primary)	0.5%	1.0%	8

Max RSS (memory usage)

Results

Primary benchmarks: ❌ relevant regression found
Secondary benchmarks: ✅ relevant improvements found

	mean¹	max	count²
Regressions ❌ (primary)	2.1%	2.1%	1
Regressions ❌ (secondary)	2.0%	2.0%	1
Improvements ✅ (primary)	-	-	0
Improvements ✅ (secondary)	-3.0%	-3.4%	7
All ❌✅ (primary)	2.1%	2.1%	1

Cycles

Results

Primary benchmarks: ❌ relevant regressions found
Secondary benchmarks: no relevant changes found

	mean¹	max	count²
Regressions ❌ (primary)	2.5%	3.0%	2
Regressions ❌ (secondary)	-	-	0
Improvements ✅ (primary)	-	-	0
Improvements ✅ (secondary)	-	-	0
All ❌✅ (primary)	2.5%	3.0%	2

If you disagree with this performance assessment, please file an issue in rust-lang/rustc-perf.

Benchmarking this pull request likely means that it is perf-sensitive, so we're automatically marking it as not fit for rolling up. While you can manually mark this PR as fit for rollup, we strongly recommend not doing so since this PR may lead to changes in compiler perf.

Next Steps: If you can justify the regressions found in this try perf run, please indicate this with @rustbot label: +perf-regression-triaged along with sufficient written justification. If you cannot justify the regressions please fix the regressions and do another perf run. If the next run shows neutral or positive results, the label will be automatically removed.

@bors rollup=never
@rustbot label: +S-waiting-on-review -S-waiting-on-perf +perf-regression

the arithmetic mean of the percent change ↩ ↩² ↩³
number of relevant changes ↩ ↩² ↩³

pnkfelix · 2022-08-24T14:27:06Z

Probably this one: @rust-timer build 8203583

indeed, the regressing benchmarks for PR #100652 include the serde, unify-linearly and deep-vector cases that the rollup suffered from, all by similar amounts. (only ucd was absent from the narrower view).

I tagged PR #100652 as a perf regression, and thus will mark this PR as triaged.

@rustbot label: +perf-regression-triaged

aDotInTheVoid and others added 30 commits July 18, 2022 16:59

Rustdoc-Json: Clean up tests

dacffd2

interpret: only consider 1-ZST when searching for receiver

5798555

Jsondocck: New @ismany command

64f790f

rustdoc-json: Use @ismany in tests

760b972

errors: move translation logic into module

510ba03

Just moving code around so that triagebot can ping relevant parties when translation logic is modified. Signed-off-by: David Wood <david.wood@huawei.com>

triagebot: add mention groups for diag translation

a9e6167

Add mention groups to `triagebot.toml` for diagnostic derive macros and diagnostic translation sources/resources. Signed-off-by: David Wood <david.wood@huawei.com>

triagebot: autolabel A-translation

ae02014

Instruct triagebot to autolabel pull requests that modify the translation sources with the `A-translation` label. Signed-off-by: David Wood <david.wood@huawei.com>

unwind: don't build dependency when building for Miri

63113c8

Avoid code duplication in {MetaItem,MetaItemKind}::value_str.

7d1e5a4

The two methods are almost identical.

Make ExtCtxt::expr_lit non-pub.

d7a041f

By using `expr_str` more and adding `expr_{char,byte_str}`.

needless separation of impl blocks

3f379f6

Do not report cycle error when inferring return type for suggestion

5309375

Pass +atomics-32 feature for {arm,thumb}v4t-none-eabi

8439080

Migrate emoji identifier diagnostics to SessionDiagnostic

c1a9841

Remove deferred sized checks

33212bf

Update books

b176f8b

Update cargo

f4674b4

Fixed a few documentation errors

89d9a35

IEEE-754, not IEEE-745. May save someone a second sometime

Fixed a few documentation errors

683b3f4

Quick pull request; IEEE-754, not IEEE-745. May save someone a quick second some time.

is_knowable use Result instead of Option

1cede2c

Rollup merge of rust-lang#100018 - nnethercote:clean-up-LitKind, r=pe…

d5dca26

…trochenkov Clean up `LitKind` r? ``@petrochenkov``

Rollup merge of rust-lang#100489 - lcnr:is_knowable-Result, r=davidtwco

1e93994

`is_knowable` use `Result` instead of `Option`

Rollup merge of rust-lang#100608 - tshepang:needless-separation, r=Ta…

d956734

…KO8Ki needless separation of impl blocks

bors added the S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. label Aug 17, 2022

bors added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Aug 17, 2022

bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Aug 17, 2022

bors mentioned this pull request Aug 17, 2022

implied bounds: explicitly state which types are assumed to be wf #100676

Merged

bors added the merged-by-bors This PR was explicitly merged by bors. label Aug 17, 2022

bors merged commit 9c20b2a into rust-lang:master Aug 17, 2022

rustbot added this to the 1.65.0 milestone Aug 17, 2022

This was referenced Aug 17, 2022

Add Rust std support for x86_64-unknown-uefi #100316

Closed

Improve rustdoc json tests #100678

Merged

rustbot added the perf-regression Performance regression. label Aug 17, 2022

rustbot added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Aug 17, 2022

pnkfelix mentioned this pull request Aug 24, 2022

Remove deferred sized checks (make them eager) #100652

Merged

rustbot added the perf-regression-triaged The performance regression has been triaged. label Aug 24, 2022

matthiaskrgr deleted the rollup-au41ho1 branch October 9, 2022 00:31

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Rollup of 15 pull requests #100677

Rollup of 15 pull requests #100677

matthiaskrgr commented Aug 17, 2022

bors commented Aug 17, 2022

bors commented Aug 17, 2022

bors commented Aug 17, 2022

matthiaskrgr commented Aug 17, 2022

bors commented Aug 17, 2022

rust-log-analyzer commented Aug 17, 2022

bors commented Aug 17, 2022

rust-timer commented Aug 17, 2022

rust-timer commented Aug 17, 2022

lqd commented Aug 17, 2022

rust-timer commented Aug 17, 2022

rust-timer commented Aug 17, 2022

pnkfelix commented Aug 24, 2022

Rollup of 15 pull requests #100677

Rollup of 15 pull requests #100677

Conversation

matthiaskrgr commented Aug 17, 2022

bors commented Aug 17, 2022

bors commented Aug 17, 2022

bors commented Aug 17, 2022

matthiaskrgr commented Aug 17, 2022

bors commented Aug 17, 2022

rust-log-analyzer commented Aug 17, 2022

bors commented Aug 17, 2022

rust-timer commented Aug 17, 2022

rust-timer commented Aug 17, 2022

Instruction count

Max RSS (memory usage)

Cycles

Footnotes

lqd commented Aug 17, 2022

rust-timer commented Aug 17, 2022

rust-timer commented Aug 17, 2022

Instruction count

Max RSS (memory usage)

Cycles

Footnotes

pnkfelix commented Aug 24, 2022