Field identifiers now include specific spans (Closes #8263). #10142
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This addresses the span part of the PR, but not the structure name part. I'll withhold my r+ in case someone else knows of a way to test this. |
|
@cmr Yeah, I don't know how to test it either (there's too much potential for drift to check for an exact span in the error string). I'm OK with this particular change going in so long as nothing else breaks :-) |
|
@cmr: Fixed the struct name part. |
bors
added a commit
that referenced
this pull request
Oct 29, 2013
This is, I think, the minimal change required. I would have included a test but as far as I can tell there is currently no way to precisely test that the span for an error underlines the correct word. I did verify it manually.
flip1995
pushed a commit
to flip1995/rust
that referenced
this pull request
Jan 12, 2023
[`drop_ref`]: don't lint idiomatic in match arm fixes rust-lang#10122 As established in issue rust-lang#9482, it is idiomatic to use a single `drop()` expression in a match arm to achieve a side-effect of a function while discarding its output. This should also apply to cases where the function returns a reference. The change to the lint's code was less than 1 line, because all the heavy lifting was done in PR rust-lang#9491. --- changelog: FP: [`drop_ref`]: No longer lints idiomatic expression in `match` arms [rust-lang#10142](rust-lang/rust-clippy#10142) <!-- changelog_checked -->
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is, I think, the minimal change required. I would have included a test but as far as I can tell there is currently no way to precisely test that the span for an error underlines the correct word. I did verify it manually.