rustpkg: Fix an assertion failure #10342
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I talked about this with @brson and the right thing is for rustpkg to call rustc::monitor in each task. So I'll do that and resubmit. |
|
This is painful because rustc::monitor takes an @ -closure (because it takes an @ Emitter as an argument). rustpkg already does a lot of this (cloning gratuitously so @ -closures can work), but I hate to add more of it. I wonder how easy it would be to change the @ Emitter argument to monitor's closure argument to be a ~ or & instead. |
…oin(p))` assertion failure This addresses the problem reported in rust-lang#10253 and possibly elsewhere. Closes rust-lang#10253
|
I removed the monitor stuff from this pull request since I don't know how to do it right. It just fixes the assertion failure now (which wasn't related anyway). Re-r?, anybody who's available. |
Jarcho
pushed a commit
to Jarcho/rust
that referenced
this pull request
Feb 26, 2023
… r=Alexendoo Add question-mark-used lint This lint complains when the question mark operator (try operator) is used. This is a restriction lint that can be useful on local scopes where a custom error handling macro is supposed to be used to augment the error based on local scope data before returning. Fixes rust-lang#10340 --- changelog: New lint [`question_mark_used`] [rust-lang#10342](rust-lang/rust-clippy#10342) <!-- changelog_checked -->
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
r? @brson