Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Suggest move in nested closure when appropriate #106575

Merged
merged 1 commit into from
Feb 3, 2023
Merged

Suggest move in nested closure when appropriate #106575

merged 1 commit into from
Feb 3, 2023

Conversation

estebank
Copy link
Contributor

@estebank estebank commented Jan 7, 2023

Fix #64008.

@rustbot
Copy link
Collaborator

rustbot commented Jan 7, 2023

r? @wesleywiser

(rustbot has picked a reviewer for you, use r? to override)

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Jan 7, 2023
@pnkfelix
Copy link
Member

pnkfelix commented Feb 2, 2023

@bors r+ rollup=always

@bors
Copy link
Contributor

bors commented Feb 2, 2023

📌 Commit 00f821f has been approved by pnkfelix

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Feb 2, 2023
matthiaskrgr added a commit to matthiaskrgr/rust that referenced this pull request Feb 2, 2023
@matthiaskrgr
Rollup merge of rust-lang#106575 - estebank:issue-64008, r=pnkfelix
52cb29d 
Suggest `move` in nested closure when appropriate

Fix rust-lang#64008.
@matthiaskrgr matthiaskrgr mentioned this pull request Feb 2, 2023
Closed
@matthiaskrgr
Copy link
Member

@bors r- build failure

@bors bors added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Feb 2, 2023
@estebank
Copy link
Contributor Author

estebank commented Feb 2, 2023

@bors r=pnkfelix

@bors
Copy link
Contributor

bors commented Feb 2, 2023

📌 Commit e6b84eb has been approved by pnkfelix

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Feb 2, 2023
@matthiaskrgr matthiaskrgr mentioned this pull request Feb 3, 2023
Merged
bors added a commit to rust-lang-ci/rust that referenced this pull request Feb 3, 2023
@bors
Auto merge of rust-lang#107625 - matthiaskrgr:rollup-xr9oldy, r=matth…
7c46fb2 
…iaskrgr

Rollup of 6 pull requests

Successful merges:

 - rust-lang#106575 (Suggest `move` in nested closure when appropriate)
 - rust-lang#106805 (Suggest `{var:?}` when finding `{?:var}` in inline format strings)
 - rust-lang#107500 (Add tests to assert current behavior of large future sizes)
 - rust-lang#107598 (Fix benchmarks in library/core with black_box)
 - rust-lang#107602 (Parse and recover from type ascription in patterns)
 - rust-lang#107608 (Use triple rather than arch for fuchsia test-runner)

Failed merges:

r? `@ghost`
`@rustbot` modify labels: rollup
@bors bors merged commit 6b94f4d into rust-lang:master Feb 3, 2023
@rustbot rustbot added this to the 1.69.0 milestone Feb 3, 2023
@estebank estebank deleted the issue-64008 branch November 9, 2023 05:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@wesleywiser wesleywiser

Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
1.69.0
Development

Successfully merging this pull request may close these issues.

Nested closures give suboptimal move suggestion
6 participants
@estebank @rustbot @pnkfelix @bors @matthiaskrgr @wesleywiser