Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use triple rather than arch for fuchsia test-runner #107608

Merged
merged 1 commit into from
Feb 3, 2023

Conversation

P1n3appl3
Copy link
Contributor

This allows the user of the test-runner script to specify a full triple rather than just an architecture which helps with the transition from the two component to three component target triples for fuchsia.

@rustbot
Copy link
Collaborator

rustbot commented Feb 2, 2023

r? @pietroalbini

(rustbot has picked a reviewer for you, use r? to override)

@rustbot rustbot added A-testsuite Area: The testsuite used to check the correctness of rustc S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-infra Relevant to the infrastructure team, which will review and decide on the PR/issue. labels Feb 2, 2023
@P1n3appl3 P1n3appl3 force-pushed the master branch 2 times, most recently from f7b332c to 33c2530 Compare February 2, 2023 19:30
@djkoloski
Copy link
Contributor

I'll review this.

r? @tmandry

@rustbot rustbot assigned tmandry and unassigned pietroalbini Feb 2, 2023
src/ci/docker/scripts/fuchsia-test-runner.py Outdated Show resolved Hide resolved
@tmandry
Copy link
Member

tmandry commented Feb 3, 2023

@bors r+ rollup

@bors
Copy link
Contributor

bors commented Feb 3, 2023

📌 Commit eb5e971 has been approved by tmandry

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Feb 3, 2023
bors added a commit to rust-lang-ci/rust that referenced this pull request Feb 3, 2023
…iaskrgr

Rollup of 6 pull requests

Successful merges:

 - rust-lang#106575 (Suggest `move` in nested closure when appropriate)
 - rust-lang#106805 (Suggest `{var:?}` when finding `{?:var}` in inline format strings)
 - rust-lang#107500 (Add tests to assert current behavior of large future sizes)
 - rust-lang#107598 (Fix benchmarks in library/core with black_box)
 - rust-lang#107602 (Parse and recover from type ascription in patterns)
 - rust-lang#107608 (Use triple rather than arch for fuchsia test-runner)

Failed merges:

r? `@ghost`
`@rustbot` modify labels: rollup
@bors bors merged commit b6e8ebf into rust-lang:master Feb 3, 2023
@rustbot rustbot added this to the 1.69.0 milestone Feb 3, 2023
@tmandry tmandry added the O-fuchsia Operating system: Fuchsia label May 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-testsuite Area: The testsuite used to check the correctness of rustc O-fuchsia Operating system: Fuchsia S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-infra Relevant to the infrastructure team, which will review and decide on the PR/issue.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants