Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rollup of 14 pull requests #106708

Merged
merged 30 commits into from
Jan 11, 2023
Merged

Rollup of 14 pull requests #106708

merged 30 commits into from
Jan 11, 2023

Commits on Jan 9, 2023

  1. Configuration menu
    Copy the full SHA
    9971018 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    c5ee72c View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    d0c47bd View commit details
    Browse the repository at this point in the history
  4. Remove myself from rust-lang/rust reviewers

    I don't have time to both review and work on my foundation grant.
    jyn514 committed Jan 9, 2023
    Configuration menu
    Copy the full SHA
    2ee546a View commit details
    Browse the repository at this point in the history
  5. Configuration menu
    Copy the full SHA
    c43faf1 View commit details
    Browse the repository at this point in the history

Commits on Jan 10, 2023

  1. remove E0280 and ICE instead

    oskgo committed Jan 10, 2023
    Configuration menu
    Copy the full SHA
    f75eb24 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    203bbfa View commit details
    Browse the repository at this point in the history
  3. create helper function for rustc_lint_defs::Level and remove it's d…

    …uplicated code r=ozkanonur
    
    Signed-off-by: ozkanonur <work@onurozkan.dev>
    onur-ozkan committed Jan 10, 2023
    Configuration menu
    Copy the full SHA
    5fb9ca3 View commit details
    Browse the repository at this point in the history
  4. Add comment to cleanup_kinds

    based on the original commit message 1ae7ae0
    tmiasko committed Jan 10, 2023
    Configuration menu
    Copy the full SHA
    836ef61 View commit details
    Browse the repository at this point in the history
  5. Configuration menu
    Copy the full SHA
    78075e1 View commit details
    Browse the repository at this point in the history
  6. Configuration menu
    Copy the full SHA
    72f8d6a View commit details
    Browse the repository at this point in the history
  7. Configuration menu
    Copy the full SHA
    2214c6d View commit details
    Browse the repository at this point in the history
  8. Configuration menu
    Copy the full SHA
    0399a63 View commit details
    Browse the repository at this point in the history
  9. Configuration menu
    Copy the full SHA
    719f545 View commit details
    Browse the repository at this point in the history
  10. Configuration menu
    Copy the full SHA
    36c9b49 View commit details
    Browse the repository at this point in the history

Commits on Jan 11, 2023

  1. Configuration menu
    Copy the full SHA
    7c2d48b View commit details
    Browse the repository at this point in the history
  2. Rollup merge of rust-lang#105194 - tmiasko:cleanup-kinds, r=davidtwco

    Add comment to cleanup_kinds
    
    based on the original commit message 1ae7ae0
    Yuki Okushi authored Jan 11, 2023
    Configuration menu
    Copy the full SHA
    8d7a06a View commit details
    Browse the repository at this point in the history
  3. Rollup merge of rust-lang#106521 - oskgo:remove-E0280, r=jackh726

    remove E0280
    
    After looking at rust-lang#61137 I tried my hand at E0280. I'm unable to find a reasonable example that emits the error. There are a couple of old examples that compile with the current compiler ([rust-lang#26217](rust-lang#26217), [rust-lang#42114](rust-lang#42114), [rust-lang#27113](rust-lang#27113)) and there is a [bug with chalk](https://github.com/rust-lang/rust/blob/b7cdb635c4b973572307ad288466fba64533369c/src/test/ui/chalkify/bugs/async.rs) that makes it emit the error, with a couple more chalk bugs on zulip.
    
    It seems like the error is supposed to be emitted from unfulfilled where bounds, of which two are related to borrow checking (error in where T: 'a or where 'a: 'b) and thus tend to emit errors like "lifetime may not live long enough" from borrow checking instead. The final case is with type equality constraints (where <T as Iterator>::Item == u32), which is unimplemented ([rust-lang#20041](rust-lang#20041)). That such different problems are supposed to have the same error code also seems strange to me.
    
    Since the error seems to only be emitted when using chalk I propose to remove it and replace it with an ICE instead. A crater run might be warranted.
    
    Pinging `@jackh726` due to removal of chalk test that now ICEs.
    Yuki Okushi authored Jan 11, 2023
    Configuration menu
    Copy the full SHA
    12b1242 View commit details
    Browse the repository at this point in the history
  4. Rollup merge of rust-lang#106628 - GuillaumeGomez:rm-itemid-primitive…

    …, r=notriddle
    
    Remove unneeded ItemId::Primitive variant
    
    As I mentioned [here](rust-lang#106412 (comment)), I wondered if `ItemId::Primitive` was actually used for anything. Apparently, it seems so because removing it led to no changes as far as I and tests could see.
    
    r? `@notriddle`
    Yuki Okushi authored Jan 11, 2023
    Configuration menu
    Copy the full SHA
    b0ffc11 View commit details
    Browse the repository at this point in the history
  5. Rollup merge of rust-lang#106635 - RalfJung:std-test-nits, r=thomcc

    std sync tests: better type name, clarifying comment
    
    Just resolving some confusion that I encountered while reading these tests.
    
    r? `@thomcc`
    Yuki Okushi authored Jan 11, 2023
    Configuration menu
    Copy the full SHA
    397013d View commit details
    Browse the repository at this point in the history
  6. Rollup merge of rust-lang#106642 - albertlarsan68:test-106062, r=John…

    …Titor
    
    Add test for rust-lang#106062
    
    Add a regression test for rust-lang#106062
    
    Closes rust-lang#106062
    Yuki Okushi authored Jan 11, 2023
    Configuration menu
    Copy the full SHA
    f547c4b View commit details
    Browse the repository at this point in the history
  7. Rollup merge of rust-lang#106645 - c410-f3r:rfc-2397-1, r=oli-obk

    [RFC 2397] Initial implementation
    
    cc rust-lang#51992
    
    Because of previous experiences where ppl didn't have the time to review large PRs (or any at all), the implementation of this feature will be delivered in small chunks to hopefully make things faster.
    
    In this initial PR, only the attribute is being declared and gated with ordinary tests.
    Yuki Okushi authored Jan 11, 2023
    Configuration menu
    Copy the full SHA
    e078d82 View commit details
    Browse the repository at this point in the history
  8. Rollup merge of rust-lang#106653 - ehuss:allow-features-help, r=nilst…

    …rieb
    
    Fix help docs for -Zallow-features
    
    The arguments for -Zallow-features are comma-separated (`parse_opt_comma_list`), not space separated (`parse_list`).
    Yuki Okushi authored Jan 11, 2023
    Configuration menu
    Copy the full SHA
    8f57062 View commit details
    Browse the repository at this point in the history
  9. Rollup merge of rust-lang#106657 - jyn514:review, r=Mark-Simulacrum

    Remove myself from rust-lang/rust reviewers
    
    I don't have time to both review and work on my foundation grant.
    Yuki Okushi authored Jan 11, 2023
    Configuration menu
    Copy the full SHA
    80c3ec8 View commit details
    Browse the repository at this point in the history
  10. Rollup merge of rust-lang#106662 - Ezrashaw:specialize-bool-tostring,…

    … r=cuviper
    
    specialize impl of `ToString` on `bool`
    
    Fixes rust-lang#106611
    
    Specialize `bool`s `ToString` impl by copying it from `Display`. This is a significant optimization as we avoid lots of dynamic dispatch. AFAIK, this doesn't require a API Change Proposal as this doesn't regress existing code and can be undone without regressing code.
    Yuki Okushi authored Jan 11, 2023
    Configuration menu
    Copy the full SHA
    feca61e View commit details
    Browse the repository at this point in the history
  11. Rollup merge of rust-lang#106669 - ozkanonur:helper-function-for-lint…

    …-level, r=Nilstrieb
    
    create helper function for `rustc_lint_defs::Level` and remove it's duplicated code
    
    Signed-off-by: ozkanonur <work@onurozkan.dev>
    Yuki Okushi authored Jan 11, 2023
    Configuration menu
    Copy the full SHA
    0e92e1d View commit details
    Browse the repository at this point in the history
  12. Rollup merge of rust-lang#106671 - tmiasko:opt-bool, r=wesleywiser

    Change flags with a fixed default value from Option<bool> to bool
    Yuki Okushi authored Jan 11, 2023
    Configuration menu
    Copy the full SHA
    c2d1cac View commit details
    Browse the repository at this point in the history
  13. Rollup merge of rust-lang#106689 - GuillaumeGomez:rustdoc-gui-files-a…

    …rray, r=notriddle
    
    Fix invalid files array re-creation in rustdoc-gui tester
    
    It fixes the error <code>expected `runTest` first argument to be a string</code>:
    
    ```
    {
      file_name: {
        file_name: '/home/imperio/rust/rust/src/test/rustdoc-gui/type-declation-overflow.goml',
        output: 'type-declation-overflow... FAILED\n' +
          '...'
      },
      output: Error: expected `runTest` first argument to be a string
          at runTest (/home/imperio/rust/rust/node_modules/browser-ui-test/src/index.js:591:15)
          at runTests (/home/imperio/rust/rust/src/tools/rustdoc-gui/tester.js:144:26)
          at main (/home/imperio/rust/rust/src/tools/rustdoc-gui/tester.js:278:15)
    } Error: expected `runTest` first argument to be a string
        at runTest (/home/imperio/rust/rust/node_modules/browser-ui-test/src/index.js:591:15)
        at runTests (/home/imperio/rust/rust/src/tools/rustdoc-gui/tester.js:144:26)
        at main (/home/imperio/rust/rust/src/tools/rustdoc-gui/tester.js:278:15)
    ```
    
    The problem was that I concatenated two arrays of object whereas `files` is supposed to be an array of string.
    
    r? `@notriddle`
    Yuki Okushi authored Jan 11, 2023
    Configuration menu
    Copy the full SHA
    2c946bc View commit details
    Browse the repository at this point in the history
  14. Rollup merge of rust-lang#106690 - GuillaumeGomez:item-declaration-sc…

    …rolling, r=notriddle
    
    Fix scrolling for item declaration block
    
    Fixes rust-lang#105580.
    
    The `contain: layout` was the issue here and the bug was actually on both mobile and desktop.
    
    r? `@notriddle`
    Yuki Okushi authored Jan 11, 2023
    Configuration menu
    Copy the full SHA
    8248f1d View commit details
    Browse the repository at this point in the history
  15. Rollup merge of rust-lang#106698 - compiler-errors:notify-mr-errs, r=…

    …Mark-Simulacrum
    
    Add compiler-errors to some trait system notification groups
    
    I care about these areas of the compiler.
    Yuki Okushi authored Jan 11, 2023
    Configuration menu
    Copy the full SHA
    a804980 View commit details
    Browse the repository at this point in the history