dont randomly use _ to print out const generic arguments
#106873
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
r? @davidtwco (rustbot has picked a reviewer for you, use r? to override) |
rustbot
added
S-waiting-on-review
BoxyUwU
added
A-diagnostics
BoxyUwU
force-pushed
the
ty_const_formatting
branch
from
b6883ae to
b683112
Compare
This comment has been minimized.
This comment has been minimized.
|
@bors r=me,compiler-errors |
|
📌 Commit 30ec367e0c0dc09c37531edae5000388d13221c1 has been approved by It is now in the queue for this repository. |
bors
added
S-waiting-on-bors
This comment has been minimized.
This comment has been minimized.
|
@bors r- needs mir-opt bless |
bors
added
S-waiting-on-author
|
i'm straight up not having a good time |
|
@bors r=compiler-errors |
|
📌 Commit 00c74aafacb94141741b26f0acc0d18ab869d6b7 has been approved by It is now in the queue for this repository. |
bors
added
S-waiting-on-bors
BoxyUwU
force-pushed
the
ty_const_formatting
branch
2 times, most recently
from
896a9ce to
733ed39
Compare
|
@bors r=me,compiler-errors |
|
📌 Commit 733ed3905cb42be5bfb595c252eb05fc0915dd27 has been approved by It is now in the queue for this repository. |
BoxyUwU
force-pushed
the
ty_const_formatting
branch
from
733ed39 to
91920d8
Compare
BoxyUwU
force-pushed
the
ty_const_formatting
branch
from
91920d8 to
1171fe5
Compare
|
@bors r=compiler-errors |
matthiaskrgr
added a commit
to matthiaskrgr/rust
that referenced
this pull request
Jan 18, 2023
…piler-errors dont randomly use `_` to print out const generic arguments const generics seem to get printed out as `_` for no reason a lot of the time, as someone who spends a lot of time with const generics this has gotten ✨ very annoying ✨. Latest example would be rust-lang#106423 where the ICE messaged formatted a `ty::Const` containing no infer vars, as `_`. For some reason printing of the const argument on arrays was custom instead of using the existing logic for printing `ty::Const`. Additionally the existing logic for printing `ty::Const` would print out `_` for anon consts that are in a separate crate leading to weird diagnostics (see second commit). There ought to be less cases of consts randomly getting printed as `_` hiding valuable info now.
This was referenced Jan 18, 2023
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Jan 18, 2023
…iaskrgr Rollup of 7 pull requests Successful merges: - rust-lang#106244 (Improve Markdown styling in README) - rust-lang#106747 (Add 'static lifetime suggestion when GAT implied 'static requirement from HRTB) - rust-lang#106873 (dont randomly use `_` to print out const generic arguments) - rust-lang#106992 (Remove unused `#![feature(box_syntax)]` in `alloc`) - rust-lang#106995 (bump failing assembly & codegen tests from LLVM 14 to LLVM 15) - rust-lang#106996 (rustdoc: instead of `.setting-name { width: 100% }`, use default div CSS) - rust-lang#106997 (Add heapsort fallback in `select_nth_unstable`) Failed merges: r? `@ghost` `@rustbot` modify labels: rollup
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
const generics seem to get printed out as
_for no reason a lot of the time, as someone who spends a lot of time with const generics this has gotten ✨ very annoying ✨. Latest example would be #106423 where the ICE messaged formatted aty::Constcontaining no infer vars, as_.For some reason printing of the const argument on arrays was custom instead of using the existing logic for printing
ty::Const. Additionally the existing logic for printingty::Constwould print out_for anon consts that are in a separate crate leading to weird diagnostics (see second commit). There ought to be less cases of consts randomly getting printed as_hiding valuable info now.