bump failing assembly & codegen tests from LLVM 14 to LLVM 15 #106995
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
(rustbot has picked a reviewer for you, use r? to override) |
rustbot
added
A-testsuite
lukas-code
changed the title
is_aligned assembly test versionis_aligned assembly test LLVM version
lukas-code
force-pushed
the
align_offset_assembly_test
branch
from
f5fa9c4
to
908fd64
Compare
| @@ -44,7 +44,7 @@ ENV NO_DOWNLOAD_CI_LLVM 1 | |||
| # Using llvm-link-shared due to libffi issues -- see #34486 | |||
| ENV RUST_CONFIGURE_ARGS \ | |||
| --build=x86_64-unknown-linux-gnu \ | |||
| --llvm-root=/usr/lib/llvm-13 \ | |||
| --llvm-root=/usr/lib/llvm-14 \ | |||
There was a problem hiding this comment.
These changes are very weird, considering that the file is named src/ci/docker/host-x86_64/x86_64-gnu-llvm-13/Dockerfile
There was a problem hiding this comment.
This is a temporary hack to test in CI if it works. If we do want to test LLVM 14 this should probably go in a new runner.
Maybe we can have two new runners for building rust with preinstalled LLVM 14 and 15 and that run in CI if and only if tests/assembly or tests/codegen is changed?
I didn't actually intend to change CI with this PR.
There was a problem hiding this comment.
It's probably time for us to drop LLVM 13 altogether, at which point I usually just rename the current minimum runner. I've also just asked on Zulip #t-infra about capacity for adding more runners. But either way, you're right not to mix that in this PR.
There was a problem hiding this comment.
lukas-code
force-pushed
the
align_offset_assembly_test
branch
from
908fd64
to
1216cc7
Compare
lukas-code
changed the title
is_aligned assembly test LLVM version
|
I confirmed these, thanks! @bors r+ rollup |
bors
added
S-waiting-on-bors
compiler-errors
added a commit
to compiler-errors/rust
that referenced
this pull request
Jan 18, 2023
…est, r=cuviper bump failing assembly & codegen tests from LLVM 14 to LLVM 15 These tests need LLVM 15. Found by `@Robert-Cunningham` in rust-lang#100601 (comment) Passed tests at 006506e93fc80318ebfd7939fe1fd4dc19ecd8cb in https://github.com/rust-lang/rust/actions/runs/3942442730/jobs/6746104740.
matthiaskrgr
added a commit
to matthiaskrgr/rust
that referenced
this pull request
Jan 18, 2023
…est, r=cuviper bump failing assembly & codegen tests from LLVM 14 to LLVM 15 These tests need LLVM 15. Found by ``@Robert-Cunningham`` in rust-lang#100601 (comment) Passed tests at 006506e93fc80318ebfd7939fe1fd4dc19ecd8cb in https://github.com/rust-lang/rust/actions/runs/3942442730/jobs/6746104740.
This was referenced Jan 18, 2023
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Jan 18, 2023
…iaskrgr Rollup of 7 pull requests Successful merges: - rust-lang#106244 (Improve Markdown styling in README) - rust-lang#106747 (Add 'static lifetime suggestion when GAT implied 'static requirement from HRTB) - rust-lang#106873 (dont randomly use `_` to print out const generic arguments) - rust-lang#106992 (Remove unused `#![feature(box_syntax)]` in `alloc`) - rust-lang#106995 (bump failing assembly & codegen tests from LLVM 14 to LLVM 15) - rust-lang#106996 (rustdoc: instead of `.setting-name { width: 100% }`, use default div CSS) - rust-lang#106997 (Add heapsort fallback in `select_nth_unstable`) Failed merges: r? `@ghost` `@rustbot` modify labels: rollup
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These tests need LLVM 15.
Found by @Robert-Cunningham in #100601 (comment)
Passed tests at 006506e93fc80318ebfd7939fe1fd4dc19ecd8cb in https://github.com/rust-lang/rust/actions/runs/3942442730/jobs/6746104740.