rustdoc: instead of .setting-name { width: 100% }, use default div CSS
#106996
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rustbot
added
S-waiting-on-review
|
Some changes occurred in HTML/CSS/JS. cc @GuillaumeGomez, @Folyd, @jsha |
|
Perfect time to add a GUI test to check the width of the checkbox and of its "setting name". :) |
|
Okay, I've added some test cases for the layout surrounding the setting-name (which is actually laid out next to the radio buttons, not the checkboxes). |
GuillaumeGomez
approved these changes
Jan 17, 2023
|
Thanks! r=me once CI pass |
|
@bors r=GuillaumeGomez rollup |
bors
added
S-waiting-on-bors
compiler-errors
added a commit
to compiler-errors/rust
that referenced
this pull request
Jan 18, 2023
…div, r=GuillaumeGomez
rustdoc: instead of `.setting-name { width: 100% }`, use default div CSS
This has no discernible change in appearance.
matthiaskrgr
added a commit
to matthiaskrgr/rust
that referenced
this pull request
Jan 18, 2023
…div, r=GuillaumeGomez
rustdoc: instead of `.setting-name { width: 100% }`, use default div CSS
This has no discernible change in appearance.
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Jan 18, 2023
…iaskrgr Rollup of 7 pull requests Successful merges: - rust-lang#106244 (Improve Markdown styling in README) - rust-lang#106747 (Add 'static lifetime suggestion when GAT implied 'static requirement from HRTB) - rust-lang#106873 (dont randomly use `_` to print out const generic arguments) - rust-lang#106992 (Remove unused `#![feature(box_syntax)]` in `alloc`) - rust-lang#106995 (bump failing assembly & codegen tests from LLVM 14 to LLVM 15) - rust-lang#106996 (rustdoc: instead of `.setting-name { width: 100% }`, use default div CSS) - rust-lang#106997 (Add heapsort fallback in `select_nth_unstable`) Failed merges: r? `@ghost` `@rustbot` modify labels: rollup
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This has no discernible change in appearance.