Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Updating Wake example to use new 'pin!' macro #110026

Closed
wants to merge 3 commits into from
Closed

Updating Wake example to use new 'pin!' macro #110026

wants to merge 3 commits into from

Conversation

madsravn
Copy link
Contributor

@madsravn madsravn commented Apr 6, 2023 •
edited
Loading

Updating the example for the Wake trait to use pin! macro instead of Box::pin.
#109965

@rustbot
Copy link
Collaborator

rustbot commented Apr 6, 2023

r? @Mark-Simulacrum

(rustbot has picked a reviewer for you, use r? to override)

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-libs Relevant to the library team, which will review and decide on the PR/issue. labels Apr 6, 2023
@rustbot
Copy link
Collaborator

rustbot commented Apr 6, 2023

Hey! It looks like you've submitted a new PR for the library teams!

If this PR contains changes to any rust-lang/rust public library APIs then please comment with @rustbot label +T-libs-api -T-libs to tag it appropriately. If this PR contains changes to any unstable APIs please edit the PR description to add a link to the relevant API Change Proposal or create one if you haven't already. If you're unsure where your change falls no worries, just leave it as is and the reviewer will take a look and make a decision to forward on if necessary.

Examples of T-libs-api changes:

  • Stabilizing library features
  • Introducing insta-stable changes such as new implementations of existing stable traits on existing stable types
  • Introducing new or changing existing unstable library APIs (excluding permanently unstable features / features without a tracking issue)
  • Changing public documentation in ways that create new stability guarantees
  • Changing observable runtime behavior of library APIs

@Mark-Simulacrum
Copy link
Member

@bors r+ rollup

@bors
Copy link
Contributor

bors commented Apr 9, 2023

📌 Commit 4698b9f has been approved by Mark-Simulacrum

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Apr 9, 2023
matthiaskrgr added a commit to matthiaskrgr/rust that referenced this pull request Apr 9, 2023
@matthiaskrgr
Rollup merge of rust-lang#110026 - madsravn:master, r=Mark-Simulacrum
8d427ce 
Updating Wake example to use new 'pin!' macro

Updating the example for the Wake trait to use `pin!` macro instead of `Box::pin`.
rust-lang#109965
@matthiaskrgr matthiaskrgr mentioned this pull request Apr 9, 2023
Closed
@rustbot rustbot added the T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap) label Apr 9, 2023
@madsravn madsravn closed this by deleting the head repository Apr 9, 2023
@madsravn madsravn mentioned this pull request Apr 25, 2023
Merged
matthiaskrgr added a commit to matthiaskrgr/rust that referenced this pull request Apr 25, 2023
@matthiaskrgr
Rollup merge of rust-lang#110796 - madsravn:wake-example, r=Mark-Simu…
7f0361d 
…lacrum

Updating Wake example to use new 'pin!' macro

Closes: rust-lang#109965

I have already had this reviewed and approved here: rust-lang#110026 . But because I had some git issues and chose the "nuke it" option as my solution it didn't get merged. I nuked it too quickly. I am sorry for trouble of reviewing twice.
matthiaskrgr added a commit to matthiaskrgr/rust that referenced this pull request Apr 25, 2023
@matthiaskrgr
Rollup merge of rust-lang#110796 - madsravn:wake-example, r=Mark-Simu…
77752a0 
…lacrum

Updating Wake example to use new 'pin!' macro

Closes: rust-lang#109965

I have already had this reviewed and approved here: rust-lang#110026 . But because I had some git issues and chose the "nuke it" option as my solution it didn't get merged. I nuked it too quickly. I am sorry for trouble of reviewing twice.
thomcc pushed a commit to tcdi/postgrestd that referenced this pull request Jul 18, 2023
@matthiaskrgr
Rollup merge of #110796 - madsravn:wake-example, r=Mark-Simulacrum
ea2c36a 
Updating Wake example to use new 'pin!' macro

Closes: rust-lang/rust#109965

I have already had this reviewed and approved here: rust-lang/rust#110026 . But because I had some git issues and chose the "nuke it" option as my solution it didn't get merged. I nuked it too quickly. I am sorry for trouble of reviewing twice.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@Mark-Simulacrum Mark-Simulacrum

Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap) T-libs Relevant to the library team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@madsravn @rustbot @Mark-Simulacrum @bors