Add impl_tag! macro to implement Tag for tagged pointer easily
#110615
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rustbot
added
S-waiting-on-review
This comment has been minimized.
This comment has been minimized.
rust-cloud-vms
bot
force-pushed
the
impl_tag
branch
from
a8dcee7
to
9ba03e4
Compare
This comment has been minimized.
This comment has been minimized.
rust-cloud-vms
bot
force-pushed
the
impl_tag
branch
from
9ba03e4
to
77c83c0
Compare
Noratrieb
reviewed
Apr 20, 2023
Noratrieb
reviewed
Apr 20, 2023
Noratrieb
reviewed
Apr 20, 2023
klensy
reviewed
Apr 20, 2023
rust-cloud-vms
bot
force-pushed
the
impl_tag
branch
from
a5ac778
to
1c74c71
Compare
This comment has been minimized.
This comment has been minimized.
rust-cloud-vms
bot
force-pushed
the
impl_tag
branch
from
1c74c71
to
ad8c7b6
Compare
cjgillot
reviewed
Apr 20, 2023
| ( | ||
| impl Tag for $Self:ty; | ||
| $( | ||
| $($path:ident)::* $( { $( $fields:tt )* })? <=> $tag:literal, |
There was a problem hiding this comment.
Is customization according to $tag useful?
If not, you can use ${index()} to generate it automatically, like rustc_metadata::rmeta::table does.
There was a problem hiding this comment.
I guess the answer is "it could, but probably isn't". I'll work on it next week.
WaffleLapkin
added
S-waiting-on-author
|
@rustbot ready |
rustbot
added
S-waiting-on-review
|
Great! |
bors
added
S-waiting-on-bors
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Apr 25, 2023
…iaskrgr Rollup of 6 pull requests Successful merges: - rust-lang#110556 (Switch to `EarlyBinder` for `explicit_item_bounds`) - rust-lang#110615 (Add `impl_tag!` macro to implement `Tag` for tagged pointer easily) - rust-lang#110649 (Fix no_global_oom_handling build) - rust-lang#110671 (Consider polarity in new solver) - rust-lang#110783 (Fix ICE on --print=... i/o errors) - rust-lang#110796 (Updating Wake example to use new 'pin!' macro) Failed merges: r? `@ghost` `@rustbot` modify labels: rollup
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
r? @Nilstrieb
This should also lifts the need to think about safety from the callers (
impl_tag!is robust (ish, see the macro issue)) and removes the possibility of making a "weird"Tagimpl.