More ImplSource nits
#112867
Merged
More ImplSource nits
#112867
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The only regression is one ambiguity in the new trait solver, having to do with two param-env candidates that may apply. I think this is fine, since the error message already kinda sucks.
rustbot
added
S-waiting-on-review
|
@bors r+ rollup |
bors
added
S-waiting-on-bors
matthiaskrgr
added a commit
to matthiaskrgr/rust
that referenced
this pull request
Jun 28, 2023
…its, r=lcnr More `ImplSource` nits Even more clean-ups, I'll put this up in parallel with the `select_in_new_trait_solver` PR. r? `@lcnr`
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Jun 28, 2023
Rollup of 6 pull requests Successful merges: - rust-lang#111571 (Implement proposed API for `proc_macro_span`) - rust-lang#112236 (Simplify computation of killed borrows) - rust-lang#112867 (More `ImplSource` nits) - rust-lang#113019 (add note for non-exhaustive matches with guards) - rust-lang#113094 (Fix invalid HTML DIV tag used in HEAD) - rust-lang#113111 (add myself to review for t-types stuff) r? `@ghost` `@rustbot` modify labels: rollup
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Even more clean-ups, I'll put this up in parallel with the
select_in_new_trait_solverPR.r? @lcnr