Rollup of 4 pull requests #113114
Closed
Rollup of 4 pull requests #113114
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The only regression is one ambiguity in the new trait solver, having to do with two param-env candidates that may apply. I think this is fine, since the error message already kinda sucks.
…s, r=davidtwco Validate fluent variable references in tests Closes rust-lang#101109 Under `cfg(test)`, the `fluent_messages` macro will emit a list of variables referenced by each message and its attributes. The derive attribute will now emit a `#[test]` that checks that each referenced variable exists in the structure it's applied to.
…its, r=lcnr More `ImplSource` nits Even more clean-ups, I'll put this up in parallel with the `select_in_new_trait_solver` PR. r? `@lcnr`
…-in-head, r=notriddle,fmease Fix invalid HTML DIV tag used in HEAD Fixes rust-lang#113067. The issue also nicely explains the whole problem. r? `@notriddle`
…piler-errors add myself to review for t-types stuff I think this is how the triagebot stuff works 😅 should mean that `r? types` can now assign me
rustbot
added
A-meta
|
@bors p=4 |
|
@bors r+ 🙃 |
bors
added
S-waiting-on-bors
|
⌛ Testing commit 3798eda with merge d2270c70ca93f41912e04bebe45ecaebc8274716... |
|
#111269 already merged? bors should prevent things like that. |
|
@bors r- |
bors
removed
the
S-waiting-on-bors
bors
added
the
S-waiting-on-author
|
☀️ Try build successful - checks-actions |
1 similar comment
|
☀️ Try build successful - checks-actions |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Successful merges:
ImplSourcenits #112867 (MoreImplSourcenits)r? @ghost
@rustbot modify labels: rollup
Create a similar rollup