Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add myself to review for t-types stuff #113111

Merged
merged 1 commit into from
Jun 28, 2023
Merged

add myself to review for t-types stuff #113111

merged 1 commit into from
Jun 28, 2023

Conversation

BoxyUwU
Copy link
Member

@BoxyUwU BoxyUwU commented Jun 27, 2023

I think this is how the triagebot stuff works 😅 should mean that r? types can now assign me

@rustbot
Copy link
Collaborator

rustbot commented Jun 27, 2023

r? @Mark-Simulacrum

(rustbot has picked a reviewer for you, use r? to override)

@rustbot rustbot added A-meta Area: Issues & PRs about the rust-lang/rust repository itself S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jun 27, 2023
@BoxyUwU BoxyUwU marked this pull request as ready for review June 27, 2023 23:12
@compiler-errors
Copy link
Member

@bors r+ rollup

@bors
Copy link
Contributor

bors commented Jun 27, 2023

📌 Commit acbab96 has been approved by compiler-errors

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jun 27, 2023
@matthiaskrgr matthiaskrgr mentioned this pull request Jun 28, 2023
Closed
matthiaskrgr added a commit to matthiaskrgr/rust that referenced this pull request Jun 28, 2023
@matthiaskrgr
Rollup merge of rust-lang#113111 - BoxyUwU:boxy_t_types_review, r=com…
3798eda 
…piler-errors

add myself to review for t-types stuff

I think this is how the triagebot stuff works 😅 should mean that `r? types` can now assign me
@Dylan-DPC Dylan-DPC mentioned this pull request Jun 28, 2023
Merged
bors added a commit to rust-lang-ci/rust that referenced this pull request Jun 28, 2023
@bors
Auto merge of rust-lang#113120 - Dylan-DPC:rollup-cz4qr3o, r=Dylan-DPC
eb76764 
Rollup of 6 pull requests

Successful merges:

 - rust-lang#111571 (Implement proposed API for `proc_macro_span`)
 - rust-lang#112236 (Simplify computation of killed borrows)
 - rust-lang#112867 (More `ImplSource` nits)
 - rust-lang#113019 (add note for non-exhaustive matches with guards)
 - rust-lang#113094 (Fix invalid HTML DIV tag used in HEAD)
 - rust-lang#113111 (add myself to review for t-types stuff)

r? `@ghost`
`@rustbot` modify labels: rollup
@bors bors merged commit 11c8dbf into rust-lang:master Jun 28, 2023
@rustbot rustbot added this to the 1.72.0 milestone Jun 28, 2023
@apiraino apiraino mentioned this pull request Sep 14, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@compiler-errors compiler-errors

Labels
A-meta Area: Issues & PRs about the rust-lang/rust repository itself S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
None yet
Milestone
1.72.0
Development

Successfully merging this pull request may close these issues.
5 participants
@BoxyUwU @rustbot @compiler-errors @bors @Mark-Simulacrum