Skip to content

Conversation

RalfJung
Copy link
Member

@RalfJung RalfJung commented Dec 5, 2023

needed to fix some errors in miri-test-libstd

RalfJung and others added 20 commits December 3, 2023 14:42
also test simd_select_bitmask on arrays for less than 8 elements
SIMD bitmasks: use 'round up to multiple of 8' rather than 'clamp to at least 8'

This should prepare us better for a future with non-power-of-2 vectors, if they ever happen.
fix promising a very large alignment

Also make use of rust-lang#118565 to simplify some SIMD intrinsics, while we are at it
@rustbot
Copy link
Collaborator

rustbot commented Dec 5, 2023

r? @Mark-Simulacrum

(rustbot has picked a reviewer for you, use r? to override)

@rustbot rustbot added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Dec 5, 2023
@rustbot
Copy link
Collaborator

rustbot commented Dec 5, 2023

The Miri subtree was changed

cc @rust-lang/miri

@RalfJung
Copy link
Member Author

RalfJung commented Dec 5, 2023

@bors r+ p=1

@bors
Copy link
Collaborator

bors commented Dec 5, 2023

📌 Commit 73db2e4 has been approved by RalfJung

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Dec 5, 2023
@bors
Copy link
Collaborator

bors commented Dec 5, 2023

⌛ Testing commit 73db2e4 with merge f536185...

@bors
Copy link
Collaborator

bors commented Dec 5, 2023

☀️ Test successful - checks-actions
Approved by: RalfJung
Pushing f536185 to master...

@bors bors added the merged-by-bors This PR was explicitly merged by bors. label Dec 5, 2023
@bors bors merged commit f536185 into rust-lang:master Dec 5, 2023
@rustbot rustbot added this to the 1.76.0 milestone Dec 5, 2023
@rust-timer
Copy link
Collaborator

Finished benchmarking commit (f536185): comparison URL.

Overall result: no relevant changes - no action needed

@rustbot label: -perf-regression

Instruction count

This benchmark run did not return any relevant results for this metric.

Max RSS (memory usage)

Results

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

mean range count
Regressions ❌
(primary)
1.5% [1.5%, 1.5%] 1
Regressions ❌
(secondary)
4.2% [4.2%, 4.2%] 1
Improvements ✅
(primary)
- - 0
Improvements ✅
(secondary)
-3.1% [-3.1%, -3.1%] 1
All ❌✅ (primary) 1.5% [1.5%, 1.5%] 1

Cycles

Results

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

mean range count
Regressions ❌
(primary)
- - 0
Regressions ❌
(secondary)
4.8% [4.8%, 4.9%] 3
Improvements ✅
(primary)
- - 0
Improvements ✅
(secondary)
-5.7% [-5.7%, -5.7%] 1
All ❌✅ (primary) - - 0

Binary size

This benchmark run did not return any relevant results for this metric.

Bootstrap: 674.295s -> 675.029s (0.11%)
Artifact size: 314.16 MiB -> 314.15 MiB (-0.00%)

@RalfJung RalfJung deleted the miri branch December 5, 2023 14:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
merged-by-bors This PR was explicitly merged by bors. S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants