Remove macOS 10.10 dynamic linker bug workaround #128209
Merged
+6
−86
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rustbot
added
S-waiting-on-review
|
Not one of the people you tagged, but this looks fine. Rust no longer supports either compiling from <10.12 or running there, so people building Rust should no longer be able to hit any buggy linkers or loaders that were involved in the original problem. |
BlackHoleFox
approved these changes
Aug 2, 2024
|
Let's try a few apple CI jobs... @bors try |
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Sep 4, 2024
Remove macOS 10.10 dynamic linker bug workaround Rust's current minimum macOS version is 10.12, so the hack can be removed. This PR also updates the `remove_dir_all` docs to reflect that all supported macOS versions are protected against TOCTOU race conditions (the fallback implementation was already removed in rust-lang#127683). try-job: dist-x86_64-apple try-job: dist-aarch64-apple try-job: dist-apple-various try-job: aarch64-apple try-job: x86_64-apple-1
This comment has been minimized.
This comment has been minimized.
|
💔 Test failed - checks-actions |
bors
added
S-waiting-on-author
beetrees
force-pushed
the
no-macos-10.10
branch
from
81b0b96
to
0444056
Compare
rustbot
added
S-waiting-on-review
|
@bors try |
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Sep 4, 2024
Remove macOS 10.10 dynamic linker bug workaround Rust's current minimum macOS version is 10.12, so the hack can be removed. This PR also updates the `remove_dir_all` docs to reflect that all supported macOS versions are protected against TOCTOU race conditions (the fallback implementation was already removed in rust-lang#127683). try-job: dist-x86_64-apple try-job: dist-aarch64-apple try-job: dist-apple-various try-job: aarch64-apple try-job: x86_64-apple-1
|
☀️ Try build successful - checks-actions |
|
Does this need compatibility relnotes? EDIT: no it does not, because min supported macOS version is higher than the hack's version. |
|
But otherwise, @bors r+ rollup |
bors
added
S-waiting-on-bors
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Sep 20, 2024
…llaumeGomez Rollup of 7 pull requests Successful merges: - rust-lang#128209 (Remove macOS 10.10 dynamic linker bug workaround) - rust-lang#130526 (Begin experimental support for pin reborrowing) - rust-lang#130611 (Address diagnostics regression for `const_char_encode_utf8`.) - rust-lang#130614 (Add arm64e-apple-tvos target) - rust-lang#130617 (bail if there are too many non-region infer vars in the query response) - rust-lang#130619 (Fix scraped examples height) - rust-lang#130624 (Add `Vec::as_non_null`) r? `@ghost` `@rustbot` modify labels: rollup
rust-timer
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Sep 20, 2024
Rollup merge of rust-lang#128209 - beetrees:no-macos-10.10, r=jieyouxu Remove macOS 10.10 dynamic linker bug workaround Rust's current minimum macOS version is 10.12, so the hack can be removed. This PR also updates the `remove_dir_all` docs to reflect that all supported macOS versions are protected against TOCTOU race conditions (the fallback implementation was already removed in rust-lang#127683). try-job: dist-x86_64-apple try-job: dist-aarch64-apple try-job: dist-apple-various try-job: aarch64-apple try-job: x86_64-apple-1
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rust's current minimum macOS version is 10.12, so the hack can be removed. This PR also updates the
remove_dir_alldocs to reflect that all supported macOS versions are protected against TOCTOU race conditions (the fallback implementation was already removed in #127683).try-job: dist-x86_64-apple
try-job: dist-aarch64-apple
try-job: dist-apple-various
try-job: aarch64-apple
try-job: x86_64-apple-1