Address diagnostics regression for const_char_encode_utf8.
#130611
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rustbot
added
S-waiting-on-review
4 tasks
bjoernager
force-pushed
the
const-char-encode-utf8
branch
from
947d5c8
to
86ec60c
Compare
|
@rustbot label: +T-libs-api, -T-libs |
rustbot
added
T-libs-api
|
r? libs-api |
This comment has been minimized.
This comment has been minimized.
|
I'm unsure whether this should be targeted libs-api but I assumed so after the previous PR. I apologise if this was the wrong decision. |
bjoernager
force-pushed
the
const-char-encode-utf8
branch
from
86ec60c
to
f02baf1
Compare
|
@bors r+ |
bors
added
S-waiting-on-bors
bjoernager
force-pushed
the
const-char-encode-utf8
branch
from
f02baf1
to
91b7f27
Compare
|
Added fixme note as recommended by @RalfJung. |
bjoernager
force-pushed
the
const-char-encode-utf8
branch
from
91b7f27
to
442f5d6
Compare
This comment has been minimized.
This comment has been minimized.
bjoernager
force-pushed
the
const-char-encode-utf8
branch
from
442f5d6
to
e04d14d
Compare
This comment has been minimized.
This comment has been minimized.
bjoernager
force-pushed
the
const-char-encode-utf8
branch
from
e04d14d
to
bfadadf
Compare
|
Thanks! @bors r=dtolnay |
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Sep 20, 2024
…llaumeGomez Rollup of 7 pull requests Successful merges: - rust-lang#128209 (Remove macOS 10.10 dynamic linker bug workaround) - rust-lang#130526 (Begin experimental support for pin reborrowing) - rust-lang#130611 (Address diagnostics regression for `const_char_encode_utf8`.) - rust-lang#130614 (Add arm64e-apple-tvos target) - rust-lang#130617 (bail if there are too many non-region infer vars in the query response) - rust-lang#130619 (Fix scraped examples height) - rust-lang#130624 (Add `Vec::as_non_null`) r? `@ghost` `@rustbot` modify labels: rollup
rust-timer
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Sep 20, 2024
Rollup merge of rust-lang#130611 - bjoernager:const-char-encode-utf8, r=dtolnay Address diagnostics regression for `const_char_encode_utf8`. Relevant tracking issue: rust-lang#130512 This PR regains full diagnostics for non-const calls to `char::encode_utf8`.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Relevant tracking issue: #130512
This PR regains full diagnostics for non-const calls to
char::encode_utf8.