Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add docs about slicing slices at the ends #131383

Merged
merged 1 commit into from
Oct 10, 2024
Merged

Add docs about slicing slices at the ends #131383

merged 1 commit into from
Oct 10, 2024

Conversation

AngelicosPhosphoros
Copy link
Contributor

Closes #60783

@rustbot
Copy link
Collaborator

rustbot commented Oct 7, 2024

r? @cuviper

rustbot has assigned @cuviper.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-libs Relevant to the library team, which will review and decide on the PR/issue. labels Oct 7, 2024
@cuviper
Copy link
Member

cuviper commented Oct 9, 2024

Works for me, thanks!

@bors r+ rollup

@bors
Copy link
Contributor

bors commented Oct 9, 2024

📌 Commit cb267b4 has been approved by cuviper

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Oct 9, 2024
@matthiaskrgr matthiaskrgr mentioned this pull request Oct 9, 2024
Merged
bors added a commit to rust-lang-ci/rust that referenced this pull request Oct 10, 2024
@bors
Auto merge of rust-lang#131466 - matthiaskrgr:rollup-3qtz83x, r=matth…
df1b5d3 
…iaskrgr

Rollup of 7 pull requests

Successful merges:

 - rust-lang#123951 (Reserve guarded string literals (RFC 3593))
 - rust-lang#130827 (Library: Rename "object safe" to "dyn compatible")
 - rust-lang#131383 (Add docs about slicing slices at the ends)
 - rust-lang#131403 (Fix needless_lifetimes in rustc_serialize)
 - rust-lang#131417 (Fix methods alignment on mobile)
 - rust-lang#131449 (Decouple WASIp2 sockets from WasiFd)
 - rust-lang#131462 (Mention allocation errors for `open_buffered`)

r? `@ghost`
`@rustbot` modify labels: rollup
@bors bors merged commit d583450 into rust-lang:master Oct 10, 2024
6 checks passed
@rustbot rustbot added this to the 1.83.0 milestone Oct 10, 2024
rust-timer added a commit to rust-lang-ci/rust that referenced this pull request Oct 10, 2024
@rust-timer
Unrolled build for rust-lang#131383
084167c 
Rollup merge of rust-lang#131383 - AngelicosPhosphoros:better_doc_for_slice_slicing_at_ends, r=cuviper

Add docs about slicing slices at the ends

Closes rust-lang#60783
@bors

This comment was marked as off-topic.

Sign in to view
@jieyouxu

This comment was marked as off-topic.

Sign in to view
@bors bors added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Oct 11, 2024
@jieyouxu

This comment was marked as off-topic.

Sign in to view
@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Oct 11, 2024
@jieyouxu

This comment was marked as off-topic.

Sign in to view
@bors bors added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Oct 11, 2024
@AngelicosPhosphoros AngelicosPhosphoros deleted the better_doc_for_slice_slicing_at_ends branch October 12, 2024 02:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@cuviper cuviper

Labels
S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. T-libs Relevant to the library team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
1.83.0
Development

Successfully merging this pull request may close these issues.

Document the behavior of creating empty subslice at end of slice
5 participants
@AngelicosPhosphoros @rustbot @cuviper @bors @jieyouxu