Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove x86_64-fuchsia and aarch64-fuchsia target aliases #130657

Merged
merged 1 commit into from
Sep 23, 2024
Merged

Remove x86_64-fuchsia and aarch64-fuchsia target aliases #130657

merged 1 commit into from
Sep 23, 2024

Conversation

arttet
Copy link
Contributor

@arttet arttet commented Sep 21, 2024 •
edited by jieyouxu
Loading

Closes #106649.

@rustbot
Copy link
Collaborator

rustbot commented Sep 21, 2024

r? @lcnr

rustbot has assigned @lcnr.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

@rustbot
Copy link
Collaborator

rustbot commented Sep 21, 2024

These commits modify compiler targets.
(See the Target Tier Policy.)

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Sep 21, 2024
@rust-log-analyzer

This comment has been minimized.

Sign in to view
@rustbot
Copy link
Collaborator

rustbot commented Sep 21, 2024

Failed to set assignee to BlackHoleFox: invalid assignee

Note: Only org members with at least the repository "read" role, users with write permissions, or people who have commented on the PR may be assigned.

@arttet
Copy link
Contributor Author

arttet commented Sep 21, 2024

r? @jieyouxu

@rustbot rustbot assigned jieyouxu and unassigned lcnr Sep 21, 2024
jieyouxu
jieyouxu approved these changes Sep 21, 2024
View reviewed changes
Copy link
Member

@jieyouxu jieyouxu left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This seems reasonable to me given that sufficient time has passed since last time this was attempted, and since this is T2 target I don't think this needs an FCP. But I'll ask T-compiler leads to double check. In any case, this should get compatibility relnotes, and I'll cc the target maintainers.

@jieyouxu
Copy link
Member

Dear Fuchsia team, are you okay with removing these target aliases?
@rustbot ping fuchsia

@rustbot rustbot added the O-fuchsia Operating system: Fuchsia label Sep 21, 2024
@rustbot
Copy link
Collaborator

rustbot commented Sep 21, 2024

Hey friends of Fuchsia! This issue could use some guidance on how this should be
resolved/implemented on Fuchsia. Could one of you weigh in?

cc @djkoloski @erickt @P1n3appl3 @tmandry

@jieyouxu
Copy link
Member

@rustbot label +relnotes

@rustbot rustbot added the relnotes Marks issues that should be documented in the release notes of the next release. label Sep 21, 2024
@rustbot rustbot mentioned this pull request Sep 21, 2024
Open
3 tasks
@tmandry
Copy link
Member

tmandry commented Sep 21, 2024

Yep this looks good, thanks for the cleanup!

@jieyouxu
Copy link
Member

Since this is desired by the target maintainers themselves and this is removing Tier 2 target aliases in favor of the more unambiguous ones (with suitable relnotes to clearly communicate to users), I think this is good to go without needing a compiler FCP.

@bors r+ rollup

@bors
Copy link
Contributor

bors commented Sep 22, 2024

📌 Commit 019435b has been approved by jieyouxu

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Sep 22, 2024
workingjubilee added a commit to workingjubilee/rustc that referenced this pull request Sep 23, 2024
@workingjubilee
Rollup merge of rust-lang#130657 - arttet:fix/fuchsia, r=jieyouxu
c51bb32 
Remove x86_64-fuchsia and aarch64-fuchsia target aliases

Closes rust-lang#106649.
@workingjubilee workingjubilee mentioned this pull request Sep 23, 2024
Closed
workingjubilee added a commit to workingjubilee/rustc that referenced this pull request Sep 23, 2024
@workingjubilee
Rollup merge of rust-lang#130657 - arttet:fix/fuchsia, r=jieyouxu
4f46b63 
Remove x86_64-fuchsia and aarch64-fuchsia target aliases

Closes rust-lang#106649.
This was referenced Sep 23, 2024
Closed
Merged
bors added a commit to rust-lang-ci/rust that referenced this pull request Sep 23, 2024
@bors
Auto merge of rust-lang#130755 - workingjubilee:rollup-zpja9b3, r=wor…
9d6039c 
…kingjubilee

Rollup of 7 pull requests

Successful merges:

 - rust-lang#129201 (std: implement the `random` feature (alternative version))
 - rust-lang#130536 (bootstrap: Set the dylib path when building books with rustdoc)
 - rust-lang#130551 (Fix `break_last_token`.)
 - rust-lang#130657 (Remove x86_64-fuchsia and aarch64-fuchsia target aliases)
 - rust-lang#130721 (Add more test cases for block-no-opening-brace)
 - rust-lang#130736 (Add rustfmt 2024 reformatting to git blame ignore)
 - rust-lang#130746 (readd `@tgross35` and `@joboet` to the review rotation)

r? `@ghost`
`@rustbot` modify labels: rollup
@bors bors merged commit 021ae2c into rust-lang:master Sep 23, 2024
6 checks passed
@rustbot rustbot added this to the 1.83.0 milestone Sep 23, 2024
rust-timer added a commit to rust-lang-ci/rust that referenced this pull request Sep 23, 2024
@rust-timer
Unrolled build for rust-lang#130657
1d4d3fa 
Rollup merge of rust-lang#130657 - arttet:fix/fuchsia, r=jieyouxu

Remove x86_64-fuchsia and aarch64-fuchsia target aliases

Closes rust-lang#106649.
@arttet arttet deleted the fix/fuchsia branch September 24, 2024 08:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jieyouxu jieyouxu jieyouxu approved these changes

Assignees

@jieyouxu jieyouxu

Labels
O-fuchsia Operating system: Fuchsia relnotes Marks issues that should be documented in the release notes of the next release. S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
1.83.0
Development

Successfully merging this pull request may close these issues.

Remove x86_64-fuchsia and aarch64-fuchsia target triple aliases
7 participants
@arttet @rustbot @rust-log-analyzer @jieyouxu @tmandry @bors @lcnr