Clippy subtree update #131892

flip1995 · 2024-10-18T11:46:26Z

One day late with the sync, as I was sick yesterday.

Cargo.lock update includes Clippy version bump and some deps cleanup we did in Clippy to match more versions used in the Rust repo.

r? @Manishearth

@Centri3

…ule. Fixes <rust-lang/rust-clippy#8524>. There is still a warning (as there should be) if the item is reexported by name, but not by glob; that would require further work to examine the names in the glob, and I haven't looked into that. Credit to @Centri3 for suggesting approximately this simple fix in <rust-lang/rust-clippy#8524 (comment)>. However, per later comment <rust-lang/rust-clippy#8524 (comment)>, I am not making it configuration-dependent, but *always* checking public items in public modules only.

…macro

…han once

…dering

…before first rendering

Since all angular code was removed, there is no conflict anymore before angular and jinja2 syntaxes so we can just use plain jinja2 syntax.

Remove `GenKillAnalysis` There are two kinds of dataflow analysis in the compiler: `Analysis`, which is the basic kind, and `GenKillAnalysis`, which is a more specialized kind for gen/kill analyses that is intended as an optimization. However, it turns out that `GenKillAnalysis` is actually a pessimization! It's faster (and much simpler) to do all the gen/kill analyses via `Analysis`. This lets us remove `GenKillAnalysis`, and `GenKillSet`, and a few other things, and also merge `AnalysisDomain` into `Analysis`. The PR removes 500 lines of code and improves performance. r? `@tmiasko`

Documentation fixes - In [the page describing the lints](https://rust-lang.github.io/rust-clippy/master/index.html), the View Source links are incorrect. This PR removes the extra segment causing them to fail. - Example before: https://github.com/rust-lang/rust-clippy/blob/master/clippy_lints/clippy_lints/src/absolute_paths.rs#L13 - Example after: https://github.com/rust-lang/rust-clippy/blob/master/clippy_lints/src/absolute_paths.rs#L13 - I think this was introduced in rust-lang#13269. - I've only checked a few of the lints with the new template, but from what I can tell the metadata is generated in the same way for all of them. The `id_location` contains the full path of the lint declaration in the repository, which is why `clippy_lints` was repeated in the URL. - Separately, fixing a typo in the explanation of `unnecessary_get_then_check`. changelog: none

Changelog for Clippy 1.82 ✈️ ``` Roses are red, Violets are blue, EuroRust in Austria, RustConf in Canada. ``` --- ### The cat of this release is *Racka*: <img height=500 src="https://github.com/user-attachments/assets/e5e3cc95-6fc3-4214-aab0-4f26e0967ae5" alt="The cats of this Clippy release" /> Cats for the next release can be nominated in the comments :D --- changelog: none

Rustup r? `@ghost` changelog: none

…ubtree-update

rustbot · 2024-10-18T11:46:35Z

Some changes occurred in src/tools/clippy

cc @rust-lang/clippy

These commits modify the Cargo.lock file. Unintentional changes to Cargo.lock can be introduced when switching branches and rebasing PRs.

If this was unintentional then you should revert the changes before this PR is merged.
Otherwise, you can ignore this comment.

Manishearth · 2024-10-18T15:32:21Z

@bors r+ p=1 rollup=never

bors · 2024-10-18T15:32:25Z

📌 Commit cf918d5 has been approved by Manishearth

It is now in the queue for this repository.

pulldown-cmark: don't pull getopts dep Don't pull getopts, as it unused. Noticed in rust-lang/rust#131892 changelog: none

bors · 2024-10-18T20:06:36Z

⌛ Testing commit cf918d5 with merge e92993d...

bors · 2024-10-18T22:47:47Z

☀️ Test successful - checks-actions
Approved by: Manishearth
Pushing e92993d to master...

rust-timer · 2024-10-19T00:05:45Z

Finished benchmarking commit (e92993d): comparison URL.

Overall result: no relevant changes - no action needed

@rustbot label: -perf-regression

Instruction count

This benchmark run did not return any relevant results for this metric.

Max RSS (memory usage)

Results (primary -0.5%)

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

	mean	range	count
Regressions ❌ (primary)	2.1%	[2.1%, 2.1%]	1
Regressions ❌ (secondary)	-	-	0
Improvements ✅ (primary)	-3.0%	[-3.0%, -3.0%]	1
Improvements ✅ (secondary)	-	-	0
All ❌✅ (primary)	-0.5%	[-3.0%, 2.1%]	2

Cycles

Results (primary -3.7%, secondary 7.2%)

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

	mean	range	count
Regressions ❌ (primary)	-	-	0
Regressions ❌ (secondary)	7.2%	[3.5%, 9.7%]	12
Improvements ✅ (primary)	-3.7%	[-3.7%, -3.7%]	1
Improvements ✅ (secondary)	-	-	0
All ❌✅ (primary)	-3.7%	[-3.7%, -3.7%]	1

Binary size

This benchmark run did not return any relevant results for this metric.

Bootstrap: 780.883s -> 781.3s (0.05%)
Artifact size: 333.82 MiB -> 333.79 MiB (-0.01%)

GnomedDev and others added 30 commits September 21, 2024 12:46

Implement lint for regex::Regex compilation inside a loop

9f5bfe2

Generate lint list in HTML directly instead of JS

b522e7a

Update cargo dev serve command to look over the correct files

9661ba0

Replace search with vanilla JS

0055ceb

Finish porting lint functionalities to vanilla JS

574e3dd

Completely remove angular and generate parts of settings in JS

f2193c6

Turn declare_clippy_lint into a declarative macro

4997ee7

Move tag removing to --explain

0735031

Add sanitize_explanation

daf730c

Remove the control_flow_enum feature from clippy

d232d09

add proc macro check to needless_return

c8725f7

deal with differing syntax contexts for subexpressions in check_proc_…

55834a3

…macro

Add manual_ignore_cast_cmp lint

d1dec19

Also sanitize configuration

13e2633

Remove crashes and fix tests

3ac3c34

Remove redundant in_trait from hir::TyKind::OpaqueDef

ce22fd3

Use named fields for OpaqueTyOrigin

cbd64a4

Fix lint manual_slice_size_calculation when the slice is ref more t…

2080634

…han once

Put back interactions with settings menus

aeb548a

Support all filters except versions

59ccebe

Add support for version filtering

00c11df

Add support for URL arguments

4bb4cc6

Support version filter URL parameters

e0b0851

Improve rendering speed by moving settings generation after theme ren…

47f40d4

…dering

Move theme handling JS into its own file to make theme being applied …

d52b9aa

…before first rendering

Replace rinja custom syntax with default syntax

8a3d4e1

Since all angular code was removed, there is no conflict anymore before angular and jinja2 syntaxes so we can just use plain jinja2 syntax.

Move inlined CSS into style.css

823c124

Run syntax highlighting only when needed

80eb9cf

Greatly reduce generated HTML page size

6039343

ageorgou and others added 10 commits October 15, 2024 22:47

Correct typo in lint description

4863625

Merge remote-tracking branch 'upstream/master' into rustup

224d1e3

Bump Clippy version -> 0.1.84

4d5eaa0

Bump nightly version -> 2024-10-18

4b5d189

Auto merge of rust-lang#13561 - flip1995:rustup, r=flip1995

a109190

Rustup r? `@ghost` changelog: none

Merge commit 'a109190d7060236e655fc75533373fa274ec5343' into clippy-s…

849a19f

…ubtree-update

Update Cargo.lock

375ca8d

rustbot assigned Manishearth Oct 18, 2024

rustbot added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Oct 18, 2024

This comment has been minimized.

Sign in to view

flip1995 mentioned this pull request Oct 18, 2024

Reduce default 'large array' threshold rust-lang/rust-clippy#13485

Merged

Hotfix TRAIT_METHODS static->const

cf918d5

klensy mentioned this pull request Oct 18, 2024

pulldown-cmark: don't pull getopts dep rust-lang/rust-clippy#13562

Merged

bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Oct 18, 2024

bors added a commit to rust-lang/rust-clippy that referenced this pull request Oct 18, 2024

Auto merge of #13562 - klensy:pc, r=flip1995

47effe4

pulldown-cmark: don't pull getopts dep Don't pull getopts, as it unused. Noticed in rust-lang/rust#131892 changelog: none

bors added the merged-by-bors This PR was explicitly merged by bors. label Oct 18, 2024

bors merged commit e92993d into rust-lang:master Oct 18, 2024
7 checks passed

rustbot added this to the 1.84.0 milestone Oct 18, 2024

This was referenced Oct 18, 2024

Continue to get rid of ty::Const::{try_}eval* #130950

Merged

Hir attributes #131808

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Clippy subtree update #131892

Clippy subtree update #131892

flip1995 commented Oct 18, 2024

rustbot commented Oct 18, 2024

This comment has been minimized.

Manishearth commented Oct 18, 2024

bors commented Oct 18, 2024

bors commented Oct 18, 2024

bors commented Oct 18, 2024

rust-timer commented Oct 19, 2024

Clippy subtree update #131892

Clippy subtree update #131892

Conversation

flip1995 commented Oct 18, 2024

rustbot commented Oct 18, 2024

This comment has been minimized.

Manishearth commented Oct 18, 2024

bors commented Oct 18, 2024

bors commented Oct 18, 2024

bors commented Oct 18, 2024

rust-timer commented Oct 19, 2024

Overall result: no relevant changes - no action needed

Instruction count

Max RSS (memory usage)

Cycles

Binary size