Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rollup of 6 pull requests #133287

Merged
merged 14 commits into from
Nov 21, 2024
Merged

Rollup of 6 pull requests #133287

merged 14 commits into from
Nov 21, 2024

Commits on Oct 11, 2024

  1. Make asm label blocks safe context

    `asm!()` is forced to be wrapped inside unsafe. If there's no special
    treatment, the label blocks would also always be unsafe with no way
    of opting out.
    nbdd0121 committed Oct 11, 2024
    Configuration menu
    Copy the full SHA
    809dc73 View commit details
    Browse the repository at this point in the history

Commits on Nov 2, 2024

  1. Configuration menu
    Copy the full SHA
    78bbc64 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    cbacb6d View commit details
    Browse the repository at this point in the history

Commits on Nov 14, 2024

  1. Support s390x z13 vector ABI

    taiki-e committed Nov 14, 2024
    Configuration menu
    Copy the full SHA
    7652e34 View commit details
    Browse the repository at this point in the history

Commits on Nov 16, 2024

  1. Configuration menu
    Copy the full SHA
    98ab898 View commit details
    Browse the repository at this point in the history

Commits on Nov 20, 2024

  1. unstable feature usage metrics

    yaahc committed Nov 20, 2024
    Configuration menu
    Copy the full SHA
    dc97db1 View commit details
    Browse the repository at this point in the history
  2. Update tests/run-make/unstable-feature-usage-metrics/rmake.rs

    Co-authored-by: Esteban Kuber <estebank@users.noreply.github.com>
    yaahc and estebank authored Nov 20, 2024
    Configuration menu
    Copy the full SHA
    0a14f71 View commit details
    Browse the repository at this point in the history

Commits on Nov 21, 2024

  1. Configuration menu
    Copy the full SHA
    61a03fa View commit details
    Browse the repository at this point in the history
  2. Rollup merge of rust-lang#130236 - yaahc:unstable-feature-usage, r=es…

    …tebank
    
    unstable feature usage metrics
    
    example output
    
    ```
    test-lib on  master [?] is 📦 v0.1.0 via 🦀 v1.80.1
    ❯ cat src/lib.rs
    ───────┬───────────────────────────────────────────────────────
           │ File: src/lib.rs
    ───────┼───────────────────────────────────────────────────────
       1   │ #![feature(unix_set_mark)]
       2   │ pub fn add(left: u64, right: u64) -> u64 {
       3   │     left + right
       4   │ }
       5   │
       6   │ #[cfg(test)]
       7   │ mod tests {
       8   │     use super::*;
       9   │
      10   │     #[test]
      11   │     fn it_works() {
      12   │         let result = add(2, 2);
      13   │         assert_eq!(result, 4);
      14   │     }
      15   │ }
    ───────┴───────────────────────────────────────────────────────
    
    test-lib on  master [?] is 📦 v0.1.0 via 🦀 v1.80.1
    ❯ cargo +stage1 rustc -- -Zmetrics-dir=$PWD/metrics
       Compiling test-lib v0.1.0 (/home/yaahc/tmp/test-lib)
        Finished `dev` profile [unoptimized + debuginfo] target(s) in 0.08s
    
    test-lib on  master [?] is 📦 v0.1.0 via 🦀 v1.80.1
    ❯ cat metrics/unstable_feature_usage.json
    ───────┬─────────────────────────────────────────────────────────────────────
           │ File: metrics/unstable_feature_usage.json
    ───────┼─────────────────────────────────────────────────────────────────────
       1   │ {"lib_features":[{"symbol":"unix_set_mark"}],"lang_features":[]}
       ```
    
       related to rust-lang#129485
    matthiaskrgr authored Nov 21, 2024
    Configuration menu
    Copy the full SHA
    fe5403f View commit details
    Browse the repository at this point in the history
  3. Rollup merge of rust-lang#131544 - nbdd0121:asm_goto_safe_block, r=pe…

    …trochenkov
    
    Make asm label blocks safe context
    
    Tracking issue: rust-lang#119364
    
    `asm!()` is forced to be wrapped inside unsafe. If there's no special treatment, the label blocks would also always be unsafe with no way of opting out. It was suggested that a simple fix is to make asm label blocks safe: rust-lang#119364 (comment).
    
    `@rustbot` labels: +A-inline-assembly +F-asm
    matthiaskrgr authored Nov 21, 2024
    Configuration menu
    Copy the full SHA
    3956495 View commit details
    Browse the repository at this point in the history
  4. Rollup merge of rust-lang#131586 - taiki-e:s390x-vector-abi, r=compil…

    …er-errors,uweigand
    
    Support s390x z13 vector ABI
    
    cc rust-lang#130869
    
    This resolves the following fixmes:
    - https://github.com/rust-lang/rust/blob/58420a065b68ecb3eec03b942740c761cdadd5c4/compiler/rustc_target/src/abi/call/s390x.rs#L1-L2
    - https://github.com/rust-lang/rust/blob/58420a065b68ecb3eec03b942740c761cdadd5c4/compiler/rustc_target/src/spec/targets/s390x_unknown_linux_gnu.rs#L9-L11
    
    Refs: Section 1.2.3 "Parameter Passing" and section 1.2.5 "Return Values" in ELF Application Binary Interface s390x Supplement, Version 1.6.1 (lzsabi_s390x.pdf in https://github.com/IBM/s390x-abi/releases/tag/v1.6.1)
    
    This PR extends ~~rust-lang#127731 rust-lang#132173 (merged) 's ABI check to handle cases where `vector` target feature is disabled.
    If we do not do ABI check, we run into the ABI problems as described in rust-lang#116558 and rust-lang#130869 (comment), and the problem of the compiler generating strange code (rust-lang#131586 (comment)).
    
    cc `@uweigand`
    
    `@rustbot` label +O-SystemZ +A-ABI
    matthiaskrgr authored Nov 21, 2024
    Configuration menu
    Copy the full SHA
    379b221 View commit details
    Browse the repository at this point in the history
  5. Rollup merge of rust-lang#132489 - compiler-errors:fn-sugg-tweaks, r=…

    …BoxyUwU
    
    Fix closure arg extraction in `extract_callable_info`, generalize it to async closures
    
    * Fix argument extraction in `extract_callable_info`
    * FIx `extract_callable_info` to work for async closures
    * Remove redundant `is_fn_ty` which is just a less general `extract_callable_info`
    * More precisely name what is being called (i.e. call it a "closure" not a "function")
    
    Review this without whitespace -- I ended up reformatting `extract_callable_info` because some pesky `//` comments were keeping the let-chains from being formatted.
    matthiaskrgr authored Nov 21, 2024
    Configuration menu
    Copy the full SHA
    c064f6e View commit details
    Browse the repository at this point in the history
  6. Rollup merge of rust-lang#133078 - matthiaskrgr:uiuiui, r=davidtwco

    tests: ui/inline-consts: add issue number to a test, rename other tests
    
    rename other tests from a_b_c to a-b-c
    matthiaskrgr authored Nov 21, 2024
    Configuration menu
    Copy the full SHA
    8259859 View commit details
    Browse the repository at this point in the history
  7. Rollup merge of rust-lang#133283 - jieyouxu:triage-relnotes, r=BoxyUwU

    Don't exclude relnotes from `needs-triage` label
    
    So initially we *didn't* exclude `needs-triage` label, then we did exclude them in rust-lang#132825 as sometimes the `needs-triage` is redundant. However, I think they are probably worth double-checking because often some of the labels are only accurate/relevant for the *implementation* PR, but not for the purposes of the relnotes tracking issue. Furthermore, sometimes relevant team labels can be removed. So to make it less likely for relnotes to slip through, I think we should still label relnotes-tracking-issues with `needs-triage`.
    
    cc https://rust-lang.zulipchat.com/#narrow/channel/241545-t-release/topic/Please.20CC.20lang
    
    r? release
    matthiaskrgr authored Nov 21, 2024
    Configuration menu
    Copy the full SHA
    df2413c View commit details
    Browse the repository at this point in the history