Skip to content

Make Vec::pop_if a bit more presentable #135956

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jan 24, 2025
Merged

Make Vec::pop_if a bit more presentable #135956

merged 1 commit into from
Jan 24, 2025

Conversation

GrigorenkoPV
Copy link
Contributor

#135488 minus stabilization.

As suggested in #135488 (comment).

r? tgross35

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-libs Relevant to the library team, which will review and decide on the PR/issue. labels Jan 23, 2025
@GrigorenkoPV GrigorenkoPV mentioned this pull request Jan 23, 2025
Merged
@GrigorenkoPV
Copy link
Contributor Author

The change to the signature was approved by a t-libs-api member: #122741 (comment)

dtolnay
dtolnay approved these changes Jan 23, 2025
View reviewed changes
Copy link
Member

@dtolnay dtolnay left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@dtolnay
Copy link
Member

dtolnay commented Jan 23, 2025

@bors r+ rollup

@bors
Copy link
Collaborator

bors commented Jan 23, 2025

📌 Commit b2ad126 has been approved by dtolnay

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jan 23, 2025
@dtolnay dtolnay assigned dtolnay and unassigned tgross35 Jan 23, 2025
This was referenced Jan 24, 2025
Closed
Merged
@bors bors merged commit b344e14 into rust-lang:master Jan 24, 2025
6 checks passed
@rustbot rustbot added this to the 1.86.0 milestone Jan 24, 2025
@GrigorenkoPV GrigorenkoPV deleted the vec_pop_off branch January 24, 2025 22:08
@GrigorenkoPV GrigorenkoPV mentioned this pull request Jan 24, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@dtolnay dtolnay dtolnay approved these changes

Assignees

@dtolnay dtolnay

Labels

S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-libs Relevant to the library team, which will review and decide on the PR/issue.

Projects

None yet

Milestone

1.86.0

Development

Successfully merging this pull request may close these issues.

5 participants

@GrigorenkoPV @dtolnay @bors @tgross35 @rustbot